[Bug] Refresh restart time when failover a workflow instance (#17344)

Co-authored-by: xiangzihao <460888207@qq.com>

Author: ruanwenjun

dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/MasterServer.java

@@ -117,7 +117,6 @@ public static void main(String[] args) {
     @PostConstruct
     public void initialized() {
         ServerLifeCycleManager.toRunning();
-        final long startupTime = System.currentTimeMillis();
 
         // init rpc server
         this.masterRPCServer.start();
@@ -140,7 +139,8 @@ public void initialized() {
 
         this.schedulerApi.start();
 
-        this.systemEventBus.publish(GlobalMasterFailoverEvent.of(new Date(startupTime)));
+        this.systemEventBus
+                .publish(GlobalMasterFailoverEvent.of(new Date(ServerLifeCycleManager.getServerStartupTime())));
         this.systemEventBusFireWorker.start();
 
         MasterServerMetrics.registerMasterCpuUsageGauge(() -> {
@@ -161,7 +161,8 @@ public void initialized() {
                 close("MasterServer shutdownHook");
             }
         }));
-        log.info("MasterServer initialized successfully in {} ms", System.currentTimeMillis() - startupTime);
+        log.info("MasterServer initialized successfully in {} ms",
+                System.currentTimeMillis() - ServerLifeCycleManager.getServerStartupTime());
     }
 
     @PreDestroy

dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/command/handler/WorkflowFailoverCommandHandler.java

@@ -33,6 +33,7 @@
 import org.apache.dolphinscheduler.server.master.engine.task.runnable.TaskExecutionRunnableBuilder;
 import org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteContext.WorkflowExecuteContextBuilder;
 
+import java.util.Date;
 import java.util.Map;
 import java.util.Set;
 import java.util.function.BiConsumer;
@@ -89,6 +90,7 @@ protected void assembleWorkflowInstance(
             throw new IllegalArgumentException(
                     "The WorkflowFailoverCommandParam: " + command.getCommandParam() + " is invalid");
         }
+        workflowInstance.setRestartTime(new Date());
         workflowInstance.setState(workflowFailoverCommandParam.getWorkflowExecutionStatus());
         workflowInstance.setHost(masterConfig.getMasterAddress());
         workflowInstanceDao.updateById(workflowInstance);

dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/failover/FailoverCoordinator.java

@@ -83,15 +83,15 @@ public void globalMasterFailover(final GlobalMasterFailoverEvent globalMasterFai
                 doMasterFailover(
                         masterAddress,
                         aliveMasterServerMetadata.getServerStartupTime(),
-                        RegistryUtils.getFailoveredNodePathWhichStartupTimeIsUnknown(
+                        RegistryUtils.getGlobalMasterFailoverNodePath(
                                 masterAddress));
             } else {
                 // If the master is not alive, then we use the event time as the failover deadline.
                 log.info("The master[{}] is not alive, do global master failover on it", masterAddress);
                 doMasterFailover(
                         masterAddress,
                         globalMasterFailoverEvent.getEventTime().getTime(),
-                        RegistryUtils.getFailoveredNodePathWhichStartupTimeIsUnknown(masterAddress));
+                        RegistryUtils.getGlobalMasterFailoverNodePath(masterAddress));
             }
         }
 

dolphinscheduler-master/src/test/java/org/apache/dolphinscheduler/server/master/integration/cases/WorkflowInstanceFailoverTestCase.java

@@ -568,7 +568,7 @@ public void testGlobalFailover_runningWorkflow_fromAnotherMaster() {
 
         systemEventBus.publish(GlobalMasterFailoverEvent.of(new Date()));
 
-        final String masterFailoverNodePath = RegistryUtils.getFailoveredNodePathWhichStartupTimeIsUnknown(
+        final String masterFailoverNodePath = RegistryUtils.getGlobalMasterFailoverNodePath(
                 "127.0.0.1:15678");
         // wait failover process
         await()

dolphinscheduler-registry/dolphinscheduler-registry-api/src/main/java/org/apache/dolphinscheduler/registry/api/utils/RegistryUtils.java

@@ -29,7 +29,7 @@ public static String getMasterFailoverLockPath(final String masterAddress) {
         return RegistryNodeType.MASTER_FAILOVER_LOCK.getRegistryPath() + "/" + masterAddress;
     }
 
-    public static String getFailoveredNodePathWhichStartupTimeIsUnknown(final String serverAddress) {
+    public static String getGlobalMasterFailoverNodePath(final String serverAddress) {
         return RegistryNodeType.FAILOVER_FINISH_NODES.getRegistryPath() + "/" + serverAddress + "-" + "unknown" + "-"
                 + "unknown";
     }