Skip to content

Commit 01856e0

Browse files
authored
[Improvement-18151] Simplify the code with lombok annotations (#18152)
1 parent 0c8e646 commit 01856e0

312 files changed

Lines changed: 244 additions & 4113 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-aliyunVoice/src/main/java/org/apache/dolphinscheduler/plugin/alert/voice/VoiceParam.java

Lines changed: 3 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -22,53 +22,24 @@
2222
@Data
2323
public class VoiceParam {
2424

25-
/**
26-
* called Number
27-
*/
2825
private String calledNumber;
29-
/**
30-
* called Show Number
31-
*/
26+
3227
private String calledShowNumber;
33-
/**
34-
* tts code
35-
*/
28+
3629
private String ttsCode;
37-
/**
38-
* tts param
39-
*/
30+
4031
private String ttsParam;
4132

42-
/**
43-
* connection info
44-
*/
4533
private Connection connection;
4634

47-
/**
48-
* outId
49-
*/
5035
private String outId;
5136

5237
@Data
5338
public static class Connection {
5439

55-
/**
56-
* address
57-
*/
5840
private String address;
59-
60-
/**
61-
* accessKeyId
62-
*/
6341
private String accessKeyId;
64-
/**
65-
* accessKeySecret
66-
*/
6742
private String accessKeySecret;
68-
69-
/**
70-
* tts Code
71-
*/
7243
private String ttsCode;
7344
}
7445
}

dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-aliyunVoice/src/test/java/org/apache/dolphinscheduler/plugin/alert/voice/VoiceAlertChannelFactoryTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,6 @@
2626
import org.junit.jupiter.api.Assertions;
2727
import org.junit.jupiter.api.Test;
2828

29-
/**
30-
* VoiceAlertChannelFactoryTest
31-
*/
3229
class VoiceAlertChannelFactoryTest {
3330

3431
@Test

dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-aliyunVoice/src/test/java/org/apache/dolphinscheduler/plugin/alert/voice/VoiceSenderTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@
2323
import org.junit.jupiter.api.BeforeEach;
2424
import org.junit.jupiter.api.Test;
2525

26-
/**
27-
* VoiceSenderTest
28-
*/
2926
class VoiceSenderTest {
3027

3128
private static VoiceParam voiceParam = new VoiceParam();

dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-api/src/main/java/org/apache/dolphinscheduler/alert/api/AlertChannelFactory.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@
2323

2424
import java.util.List;
2525

26-
/**
27-
* alert channel factory
28-
*/
2926
public interface AlertChannelFactory extends PrioritySPI {
3027

3128
/**

dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-api/src/main/java/org/apache/dolphinscheduler/alert/api/AlertData.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,6 @@
2222
import lombok.Data;
2323
import lombok.NoArgsConstructor;
2424

25-
/**
26-
* alert data
27-
*/
2825
@AllArgsConstructor
2926
@Builder
3027
@Data

dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-api/src/main/java/org/apache/dolphinscheduler/alert/api/AlertResult.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,6 @@
2222
import lombok.Data;
2323
import lombok.NoArgsConstructor;
2424

25-
/**
26-
* alert result
27-
*/
2825
@Builder
2926
@AllArgsConstructor
3027
@Data

dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-script/src/test/java/org/apache/dolphinscheduler/plugin/alert/script/ProcessUtilsTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@
1919

2020
import org.junit.jupiter.api.Test;
2121

22-
/**
23-
* ProcessUtilsTest
24-
*/
2522
public class ProcessUtilsTest {
2623

2724
private static final String rootPath = System.getProperty("user.dir");

dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-script/src/test/java/org/apache/dolphinscheduler/plugin/alert/script/ScriptAlertChannelFactoryTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,6 @@
2525
import org.junit.jupiter.api.Assertions;
2626
import org.junit.jupiter.api.Test;
2727

28-
/**
29-
* ScriptAlertChannelFactoryTest
30-
*/
3128
public class ScriptAlertChannelFactoryTest {
3229

3330
@Test

dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-script/src/test/java/org/apache/dolphinscheduler/plugin/alert/script/ScriptSenderTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,6 @@
2828
import org.junit.jupiter.api.BeforeEach;
2929
import org.junit.jupiter.api.Test;
3030

31-
/**
32-
* ScriptSenderTest
33-
*/
3431
public class ScriptSenderTest {
3532

3633
private static final String rootPath = System.getProperty("user.dir");

dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-wechat/src/main/java/org/apache/dolphinscheduler/plugin/alert/wechat/WechatAppChatMessage.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,10 @@
2121

2222
import java.util.Map;
2323

24-
import lombok.Getter;
24+
import lombok.Data;
2525
import lombok.NoArgsConstructor;
26-
import lombok.Setter;
2726

28-
@Getter
29-
@Setter
27+
@Data
3028
@NoArgsConstructor
3129
public class WechatAppChatMessage {
3230

0 commit comments

Comments
 (0)