Skip to content

Commit e208b17

Browse files
committed
Improve Javadoc wording
1 parent 3ec34cb commit e208b17

7 files changed

Lines changed: 12 additions & 12 deletions

File tree

src/main/java/org/apache/datasketches/quantiles/DirectUpdateDoublesSketch.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ private DirectUpdateDoublesSketch(final int k, final MemorySegment seg, final Me
8787
* @param dstSeg the non-null destination MemorySegment that will be initialized to hold the data for this sketch.
8888
* It must initially be at least (16 * MIN_K + 32) bytes, where MIN_K defaults to 2. As it grows
8989
* it will request more MemorySegment using the MemorySegmentRequest callback.
90-
* @param mSegReq the MemorySegmentRequest used if the incoming MemorySegment needs to expand.
90+
* @param mSegReq the MemorySegmentRequest used if the given MemorySegment needs to expand.
9191
* Otherwise, it can be null and the default MemorySegmentRequest will be used.
9292
* @return a DirectUpdateDoublesSketch
9393
*/
@@ -117,7 +117,7 @@ static DirectUpdateDoublesSketch newInstance(final int k, final MemorySegment ds
117117
* Wrap this sketch around the given updatable MemorySegment image of a DoublesSketch.
118118
*
119119
* @param srcSeg the given MemorySegment image of an UpdateDoublesSketch and must not be null.
120-
* @param mSegReq the MemorySegmentRequest used if the incoming MemorySegment needs to expand.
120+
* @param mSegReq the MemorySegmentRequest used if the given MemorySegment needs to expand.
121121
* Otherwise, it can be null and the default MemorySegmentRequest will be used.
122122
* @return a sketch that wraps the given srcSeg
123123
*/

src/main/java/org/apache/datasketches/quantiles/DoublesSketch.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,8 @@ public static DoublesSketch heapify(final MemorySegment srcSeg) {
154154
* Wrap this sketch around the given updatable MemorySegment image of a DoublesSketch, compact or updatable.
155155
*
156156
* @param srcSeg the given MemorySegment image of a DoublesSketch that may have data
157-
* @param mSegReq the MemorySegmentRequest used if the incoming MemorySegment is in updatable form and needs to expand.
158-
* Otherwise, it can be null.
157+
* @param mSegReq the MemorySegmentRequest used if the given MemorySegment needs to expand.
158+
* Otherwise, it can be null and the default MemorySegmentRequest will be used.
159159
* @return a sketch that wraps the given srcSeg in read-only mode.
160160
*/
161161
public static DoublesSketch wrap(final MemorySegment srcSeg, final MemorySegmentRequest mSegReq) {
@@ -394,7 +394,7 @@ public static String toString(final MemorySegment seg) {
394394
* It is required that this.getK() = smallerK * 2^(nonnegative integer).
395395
* @param dstSeg the destination MemorySegment. It must not overlap the MemorySegment of this sketch.
396396
* If null, a heap sketch will be returned, otherwise it will be MemorySegment based.
397-
* @param mSegReq the MemorySegmentRequest used if the incoming MemorySegment needs to expand.
397+
* @param mSegReq the MemorySegmentRequest used if the given MemorySegment needs to expand.
398398
* Otherwise, it can be null and the default MemorySegmentRequest will be used.
399399
* @return the new sketch.
400400
*/

src/main/java/org/apache/datasketches/quantiles/DoublesSketchBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public UpdateDoublesSketch build(final MemorySegment dstSeg) {
8787
* Returns a UpdateDoublesSketch with the current configuration of this builder
8888
* and the specified backing destination MemorySegment store that can grow.
8989
* @param dstSeg destination MemorySegment for use by the sketch
90-
* @param mSegReq the MemorySegmentRequest used if the incoming MemorySegment needs to expand.
90+
* @param mSegReq the MemorySegmentRequest used if the given MemorySegment needs to expand.
9191
* Otherwise, it can be null and the default MemorySegmentRequest will be used.
9292
* @return an UpdateDoublesSketch
9393
*/

src/main/java/org/apache/datasketches/quantiles/DoublesUnion.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ public static DoublesUnion heapify(final MemorySegment srcSeg) {
6464
* The data structures of the Union remain in the MemorySegment.
6565
*
6666
* @param srcSeg A MemorySegment to be used as the data structure for the sketch and will be modified.
67-
* @param mSegReq the MemorySegmentRequest used if the incoming MemorySegment needs to expand.
67+
* @param mSegReq the MemorySegmentRequest used if the given MemorySegment needs to expand.
6868
* Otherwise, it can be null and the default MemorySegmentRequest will be used.
6969
* @return a Union object
7070
*/
@@ -151,7 +151,7 @@ public static DoublesUnion writableWrap(final MemorySegment srcSeg, final Memory
151151
* been changed, which allows further union operations.
152152
*
153153
* @param dstSeg the destination MemorySegment for the result
154-
* @param mSegReq the MemorySegmentRequest used if the incoming MemorySegment needs to expand.
154+
* @param mSegReq the MemorySegmentRequest used if the given MemorySegment needs to expand.
155155
* Otherwise, it can be null and the default MemorySegmentRequest will be used.
156156
* @return the result of this Union operation
157157
*/

src/main/java/org/apache/datasketches/quantiles/DoublesUnionBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public DoublesUnion build() {
7474
* Returns a new empty Union object with the current configuration of this Builder
7575
* and the specified backing destination MemorySegment store.
7676
* @param dstSeg the destination MemorySegment
77-
* @param mSegReq the MemorySegmentRequest used if the incoming MemorySegment needs to expand.
77+
* @param mSegReq the MemorySegmentRequest used if the given MemorySegment needs to expand.
7878
* Otherwise, it can be null and the default MemorySegmentRequest will be used.
7979
* @return a Union object
8080
*/

src/main/java/org/apache/datasketches/quantiles/DoublesUnionImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ static DoublesUnionImpl heapInstance(final int maxK) {
6464
* It is recommended that <i>maxK</i> be a power of 2 to enable unioning of sketches with
6565
* different <i>k</i>.
6666
* @param dstSeg the MemorySegment to be used by the internal sketch and must not be null.
67-
* @param mSegReq the MemorySegmentRequest used if the incoming MemorySegment needs to expand.
67+
* @param mSegReq the MemorySegmentRequest used if the given MemorySegment needs to expand.
6868
* Otherwise, it can be null and the default MemorySegmentRequest will be used.
6969
* @return a DoublesUnion object
7070
*/
@@ -115,7 +115,7 @@ static DoublesUnionImpl heapifyInstance(final MemorySegment srcSeg) {
115115
* image of a updatable DoublesSketch. The data of the Union will remain in the MemorySegment.
116116
*
117117
* @param srcSeg A writable MemorySegment image of a updatable DoublesSketch to be used as data for the union.
118-
* @param mSegReq the MemorySegmentRequest used if the incoming MemorySegment needs to expand.
118+
* @param mSegReq the MemorySegmentRequest used if the given MemorySegment needs to expand.
119119
* Otherwise, it can be null and the default MemorySegmentRequest will be used.
120120
* @return a Union object
121121
*/

src/main/java/org/apache/datasketches/quantiles/UpdateDoublesSketch.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public abstract class UpdateDoublesSketch extends DoublesSketch {
3737
* Wrap this sketch around the given MemorySegment image of an UpdateDoublesSketch.
3838
*
3939
* @param srcSeg the given MemorySegment image of an UpdateDoublesSketch and must not be null.
40-
* @param mSegReq the MemorySegmentRequest used if the incoming MemorySegment needs to expand.
40+
* @param mSegReq the MemorySegmentRequest used if the given MemorySegment needs to expand.
4141
* Otherwise, it can be null and the default MemorySegmentRequest will be used.
4242
* @return a sketch that wraps the given srcSeg
4343
*/

0 commit comments

Comments
 (0)