In process commit

Author: leerho

src/main/java/org/apache/datasketches/quantiles/DirectUpdateDoublesSketch.java

@@ -62,6 +62,7 @@
 final class DirectUpdateDoublesSketch extends DirectUpdateDoublesSketchR {
   private MemorySegmentRequest mSegReq = null;
 
+  //**CONSTRUCTORS**
   private DirectUpdateDoublesSketch(final int k, final MemorySegment seg, final MemorySegmentRequest mSegReq) {
     super(k, seg); //Checks k
     this.mSegReq = mSegReq;
@@ -99,6 +100,10 @@ static DirectUpdateDoublesSketch newInstance(final int k, final MemorySegment ds
     return new DirectUpdateDoublesSketch(k, dstSeg, mSegReq);
   }
 
+  static DirectUpdateDoublesSketch(final DirectUpdateDoublesSketch skIn) {
+    return null;
+  }
+
   /**
    * Wrap this sketch around the given non-compact MemorySegment image of a DoublesSketch.
    *
@@ -130,6 +135,8 @@ static DirectUpdateDoublesSketch wrapInstance(final MemorySegment srcSeg, final
     return new DirectUpdateDoublesSketch(k, srcSeg, mSegReq);
   }
 
+  //**END CONSTRUCTORS**
+
   @Override
   public boolean isReadOnly() {
     return false;

src/main/java/org/apache/datasketches/quantiles/HeapUpdateDoublesSketch.java

@@ -96,7 +96,7 @@ final class HeapUpdateDoublesSketch extends UpdateDoublesSketch {
    */
   private double[] combinedBuffer_;
 
-  //**CONSTRUCTORS**********************************************************
+  //**CONSTRUCTORS**
   private HeapUpdateDoublesSketch(final int k) {
     super(k); //Checks k
   }
@@ -120,6 +120,24 @@ static HeapUpdateDoublesSketch newInstance(final int k) {
     return huds;
   }
 
+  /**
+   * Returns a copy of the given sketch
+   * @param skIn the given sketch
+   * @return a copy of the given sketch
+   */
+  static HeapUpdateDoublesSketch copy(final HeapUpdateDoublesSketch skIn) {
+    final HeapUpdateDoublesSketch skCopy = HeapUpdateDoublesSketch.newInstance(skIn.k_);
+    if (skIn.n_ > 0) {
+      skCopy.n_ = skIn.n_;
+      skCopy.combinedBuffer_ = skIn.combinedBuffer_.clone();
+      skCopy.baseBufferCount_ = skIn.baseBufferCount_;
+      skCopy.bitPattern_ = skIn.bitPattern_;
+      skCopy.minItem_ = skIn.minItem_;
+      skCopy.maxItem_ = skIn.maxItem_;
+    }
+    return skCopy;
+  }
+
   /**
    * Heapifies the given srcSeg, which must be a MemorySegment image of a DoublesSketch and may have data.
    *
@@ -166,6 +184,8 @@ static HeapUpdateDoublesSketch heapifyInstance(final MemorySegment srcSeg) {
     return huds;
   }
 
+  //**END CONSTRUCTORS**
+
   @Override
   public double getMaxItem() {
     if (isEmpty()) { throw new IllegalArgumentException(QuantilesAPI.EMPTY_MSG); }
@@ -183,6 +203,13 @@ public long getN() {
     return n_;
   }
 
+  @Override
+  HeapUpdateDoublesSketch getResultAndReset() {
+    final HeapUpdateDoublesSketch skCopy = HeapUpdateDoublesSketch.copy(this);
+    reset();
+    return skCopy;
+  }
+
   @Override
   public boolean hasMemorySegment() {
     return false;

src/main/java/org/apache/datasketches/quantiles/UpdateDoublesSketch.java

@@ -72,16 +72,26 @@ public CompactDoublesSketch compact(final MemorySegment dstSeg) {
     return DirectCompactDoublesSketch.createFromUpdateSketch(this, dstSeg);
   }
 
-  @Override
-  public abstract void update(double item);
+  /**
+   * Returns a copy of this sketch and then resets this sketch with the same value of <i>k</i>.
+   * @return a copy of this sketch and then resets this sketch with the same value of <i>k</i>.
+   */
+  abstract UpdateDoublesSketch getResultAndReset();
+
+  /**
+   * Grows the combined buffer to the given spaceNeeded
+   *
+   * @param currentSpace the current allocated space
+   * @param spaceNeeded  the space needed
+   * @return the enlarged combined buffer with data from the original combined buffer.
+   */
+  abstract double[] growCombinedBuffer(int currentSpace, int spaceNeeded);
 
   @Override
   boolean isCompact() {
     return false;
   }
 
-  //Puts
-
   /**
    * Puts the minimum item
    *
@@ -124,12 +134,7 @@ boolean isCompact() {
    */
   abstract void putBitPattern(long bitPattern);
 
-  /**
-   * Grows the combined buffer to the given spaceNeeded
-   *
-   * @param currentSpace the current allocated space
-   * @param spaceNeeded  the space needed
-   * @return the enlarged combined buffer with data from the original combined buffer.
-   */
-  abstract double[] growCombinedBuffer(int currentSpace, int spaceNeeded);
+  @Override
+  public abstract void update(double item);
+
 }