From 050efbc08613054f7357f26d8be948433066981e Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 3 Sep 2026 02:43:16 +0000 Subject: [PATCH 1/3] Bump net.sourceforge.pmd:pmd-java from 7.26.0 to 7.27.0 Bumps [net.sourceforge.pmd:pmd-java](https://github.com/pmd/pmd) from 7.26.0 to 7.27.0. - [Release notes](https://github.com/pmd/pmd/releases) - [Commits](https://github.com/pmd/pmd/compare/pmd_releases/7.26.0...pmd_releases/7.27.0) --- updated-dependencies: - dependency-name: net.sourceforge.pmd:pmd-java dependency-version: 7.27.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- parent/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/parent/pom.xml b/parent/pom.xml index 48e50e1b254..98061b405b6 100644 --- a/parent/pom.xml +++ b/parent/pom.xml @@ -442,7 +442,7 @@ net.sourceforge.pmd pmd-java - 7.26.0 + 7.27.0 From 12902a58512f067595c708aec1aa2c4f2bc73e9c Mon Sep 17 00:00:00 2001 From: Andriy Redko Date: Thu, 3 Sep 2026 13:24:38 -0400 Subject: [PATCH 2/3] Apply suggestion from @reta --- parent/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/parent/pom.xml b/parent/pom.xml index 98061b405b6..35281f4872e 100644 --- a/parent/pom.xml +++ b/parent/pom.xml @@ -437,7 +437,7 @@ net.sourceforge.pmd pmd-core - 7.26.0 + 7.27.0 net.sourceforge.pmd From 2ff1125533e38e012a731e91caccb2b71addf874 Mon Sep 17 00:00:00 2001 From: Andriy Redko Date: Mon, 7 Sep 2026 14:24:30 -0400 Subject: [PATCH 3/3] Fix PMD violations --- .../java/org/apache/cxf/common/jaxb/JAXBUtils.java | 2 +- .../org/apache/cxf/common/logging/JDKBugHacks.java | 2 +- .../java/org/apache/cxf/common/logging/LogUtils.java | 4 ++-- .../org/apache/cxf/configuration/jsse/SSLUtils.java | 2 +- .../cxf/staxutils/transform/TransformUtils.java | 4 ++-- .../apache/cxf/ws/addressing/VersionTransformer.java | 1 + .../cxf/attachment/AttachmentDeserializerTest.java | 1 + .../org/apache/cxf/resource/URIResolverTest.java | 1 + .../jca/core/classloader/PlugInClassLoaderTest.java | 2 +- .../jaxws/CxfJaxwsAutoConfiguration.java | 1 + .../SpringBasedTimedAnnotationProviderTest.java | 2 +- .../cxf/maven_plugin/wsdl2java/WsdlOptionLoader.java | 2 +- .../apache/cxf/maven_plugin/wadlto/OptionLoader.java | 2 +- .../types/CorbaObjectReferenceEventProducer.java | 2 +- .../org/apache/cxf/jaxb/JAXBContextInitializer.java | 2 +- .../org/apache/cxf/jaxb/JAXBDataBindingTest.java | 2 +- .../cxf/ext/logging/event/LogMessageFormatter.java | 4 ++-- .../provider/DefaultExceptionClassProviderTest.java | 2 +- .../provider/DefaultTimedAnnotationProviderTest.java | 2 +- .../micrometer/provider/StandardTagsTest.java | 2 +- .../provider/jaxws/JaxwsFaultCodeProviderTest.java | 2 +- .../java/org/apache/cxf/jaxrs/impl/ResponseImpl.java | 4 ++-- .../cxf/jaxrs/provider/ServerProviderFactory.java | 4 ++-- .../org/apache/cxf/jaxws/EndpointReferenceTest.java | 2 +- .../apache/cxf/jaxws/spi/WrapperClassLoaderTest.java | 2 +- .../java/org/apache/cxf/jaxrs/client/WebClient.java | 2 +- .../cxf/jaxrs/client/JAXRSClientFactoryBeanTest.java | 2 +- .../common/openapi/DefaultApplicationFactory.java | 2 +- .../apache/cxf/rt/security/SecurityConstants.java | 1 + .../cxf/rt/security/rs/RSSecurityConstants.java | 1 + .../http/spring/HttpConduitConfigurationTest.java | 2 ++ .../jms/util/PollingMessageListenerContainer.java | 2 +- .../apache/cxf/transport/jms/AbstractJMSTester.java | 1 + .../org/apache/cxf/transport/local/LocalConduit.java | 3 ++- .../apache/cxf/transport/local/LocalDestination.java | 2 +- .../org/apache/cxf/ws/rm/EncoderDecoder10AImpl.java | 1 + .../org/apache/cxf/ws/rm/EncoderDecoder10Impl.java | 1 + .../org/apache/cxf/ws/rm/EncoderDecoder11Impl.java | 1 + .../java/org/apache/cxf/ws/rm/RMContextUtils.java | 2 +- .../apache/cxf/ws/rm/AbstractRMInterceptorTest.java | 2 +- .../java/org/apache/cxf/ws/rm/RMManagerTest.java | 1 + .../cxf/ws/rm/persistence/PersistenceUtilsTest.java | 1 + .../cxf/systest/jaxrs/BookContinuationStore.java | 2 +- .../jaxrs/ClientHttpConnectionOutInterceptor.java | 3 ++- .../systest/jaxrs/reactive/RxJava2MaybeService.java | 1 + .../systest/jaxrs/reactive/RxJava2SingleService.java | 1 + .../systest/jaxrs/reactive/RxJava3MaybeService.java | 1 + .../systest/jaxrs/reactive/RxJava3SingleService.java | 1 + .../apache/cxf/systest/swa/ClientServerSwaTest.java | 1 + .../apache/cxf/systest/swa/SwANoMimeServiceImpl.java | 1 + .../org/apache/cxf/systest/swa/SwAServiceImpl.java | 1 + .../cxf/systest/jms/swa/ClientServerSwaTest.java | 1 + .../apache/cxf/systest/jms/swa/SwAServiceImpl.java | 1 + .../multipart/SwANoMimeServiceImpl.java | 1 + .../http_undertow/multipart/SwAServiceImpl.java | 1 + .../cxf/systest/http_jetty/EngineLifecycleTest.java | 1 + .../cxf/systest/https/conduit/HTTPSClientTest.java | 2 ++ .../apache/cxf/systest/mtom/ClientMtomXopTest.java | 1 + .../cxf/systest/mtom/ClientMtomXopWithJMSTest.java | 1 + .../apache/cxf/systest/ws/transfer/TestUtils.java | 12 ++++++------ .../apache/cxf/mtom_xop/TestMtomProviderImpl.java | 1 + .../apache/cxf/tools/common/model/JAnnotation.java | 2 +- .../java/org/apache/cxf/tools/util/NameUtil.java | 10 +++++----- .../cxf/tools/corba/common/idltypes/CorbaUtils.java | 2 +- .../java2wsdl/generator/WSDLGeneratorFactory.java | 2 +- .../generator/wsdl11/DateTypeCustomGenerator.java | 6 +++--- .../generator/wsdl11/FaultBeanGenerator.java | 3 ++- .../generator/wsdl11/WrapperBeanGenerator.java | 1 + .../internal/SpringServiceBuilderFactory.java | 2 +- .../processor/internal/jaxws/ResponseWrapper.java | 2 +- .../apache/cxf/tools/wsdlto/core/PluginLoader.java | 6 +++--- .../jaxws/customization/CustomizationParser.java | 8 ++++---- 72 files changed, 98 insertions(+), 63 deletions(-) diff --git a/core/src/main/java/org/apache/cxf/common/jaxb/JAXBUtils.java b/core/src/main/java/org/apache/cxf/common/jaxb/JAXBUtils.java index 1aa817177ea..8cf4907b7eb 100644 --- a/core/src/main/java/org/apache/cxf/common/jaxb/JAXBUtils.java +++ b/core/src/main/java/org/apache/cxf/common/jaxb/JAXBUtils.java @@ -249,7 +249,7 @@ public static Class holderClass(String type) { * @return true if the word is a keyword. * @see org.apache.cxf.helpers.JavaUtils */ - protected static boolean isJavaKeyword(String word) { + private static boolean isJavaKeyword(String word) { return JavaUtils.isJavaKeyword(word); } diff --git a/core/src/main/java/org/apache/cxf/common/logging/JDKBugHacks.java b/core/src/main/java/org/apache/cxf/common/logging/JDKBugHacks.java index a05c58c15ac..aeabdca943a 100644 --- a/core/src/main/java/org/apache/cxf/common/logging/JDKBugHacks.java +++ b/core/src/main/java/org/apache/cxf/common/logging/JDKBugHacks.java @@ -86,7 +86,7 @@ public String run() { } - @SuppressWarnings("PMD.UselessPureMethodCall") + @SuppressWarnings("PMD.UnusedReturnValue") public static void doHacks() { if (skipHack("org.apache.cxf.JDKBugHacks.all")) { return; diff --git a/core/src/main/java/org/apache/cxf/common/logging/LogUtils.java b/core/src/main/java/org/apache/cxf/common/logging/LogUtils.java index d7135180d6d..58fcbca5bec 100644 --- a/core/src/main/java/org/apache/cxf/common/logging/LogUtils.java +++ b/core/src/main/java/org/apache/cxf/common/logging/LogUtils.java @@ -226,8 +226,8 @@ public static Logger getL7dLogger(Class cls, /** * Create a logger */ - @SuppressWarnings("PMD.UselessPureMethodCall") - protected static Logger createLogger(Class cls, + @SuppressWarnings("PMD.UnusedReturnValue") + private static Logger createLogger(Class cls, String name, String loggerName) { ClassLoader orig = getContextClassLoader(); diff --git a/core/src/main/java/org/apache/cxf/configuration/jsse/SSLUtils.java b/core/src/main/java/org/apache/cxf/configuration/jsse/SSLUtils.java index 57a44026167..eb83bfa9d37 100644 --- a/core/src/main/java/org/apache/cxf/configuration/jsse/SSLUtils.java +++ b/core/src/main/java/org/apache/cxf/configuration/jsse/SSLUtils.java @@ -192,7 +192,7 @@ public static KeyManager[] loadKeyStore(KeyManagerFactory kmf, return keystoreManagers; } - protected static byte[] loadFile(String fileName) throws IOException { + private static byte[] loadFile(String fileName) throws IOException { if (fileName == null) { return null; } diff --git a/core/src/main/java/org/apache/cxf/staxutils/transform/TransformUtils.java b/core/src/main/java/org/apache/cxf/staxutils/transform/TransformUtils.java index dfe6051b1d0..52cd22b92ed 100644 --- a/core/src/main/java/org/apache/cxf/staxutils/transform/TransformUtils.java +++ b/core/src/main/java/org/apache/cxf/staxutils/transform/TransformUtils.java @@ -116,7 +116,7 @@ public static XMLStreamReader createTransformReaderIfNeeded(XMLStreamReader read return reader; } - protected static void convertToQNamesMap(Map map, + static void convertToQNamesMap(Map map, QNamesMap elementsMap, Map nsMap) { if (map != null) { @@ -163,7 +163,7 @@ static void convertToMapOfElementProperties(Map map, } } - protected static void convertToSetOfQNames(List set, + static void convertToSetOfQNames(List set, Set elementsSet) { if (set != null) { for (String entry : set) { diff --git a/core/src/main/java/org/apache/cxf/ws/addressing/VersionTransformer.java b/core/src/main/java/org/apache/cxf/ws/addressing/VersionTransformer.java index 053bfb7d2db..af20658ba70 100644 --- a/core/src/main/java/org/apache/cxf/ws/addressing/VersionTransformer.java +++ b/core/src/main/java/org/apache/cxf/ws/addressing/VersionTransformer.java @@ -60,6 +60,7 @@ * version of WS-Adressing (for example WS-RM depends on the * 2004/08 version). */ +@SuppressWarnings("PMD.InstantiableUtilityClass") public class VersionTransformer { protected static final String NATIVE_VERSION = Names.WSA_NAMESPACE_NAME; diff --git a/core/src/test/java/org/apache/cxf/attachment/AttachmentDeserializerTest.java b/core/src/test/java/org/apache/cxf/attachment/AttachmentDeserializerTest.java index 3589eac71d8..60572e06b88 100644 --- a/core/src/test/java/org/apache/cxf/attachment/AttachmentDeserializerTest.java +++ b/core/src/test/java/org/apache/cxf/attachment/AttachmentDeserializerTest.java @@ -367,6 +367,7 @@ public void testDeserializerWithCachedFile() throws Exception { @Test + @SuppressWarnings("PMD.UnusedReturnValue") public void testSmallStream() throws Exception { byte[] messageBytes = ("------=_Part_1\n\nJJJJ\n------=_Part_1\n\n" + "Content-Transfer-Encoding: binary\n\n=3D=3D=3D\n------=_Part_1\n").getBytes(); diff --git a/core/src/test/java/org/apache/cxf/resource/URIResolverTest.java b/core/src/test/java/org/apache/cxf/resource/URIResolverTest.java index 99e2b0c3d03..4de9f5cf00c 100644 --- a/core/src/test/java/org/apache/cxf/resource/URIResolverTest.java +++ b/core/src/test/java/org/apache/cxf/resource/URIResolverTest.java @@ -48,6 +48,7 @@ public class URIResolverTest { private Throwable checkingThreadThrowable; // assumes single-thread test execution @Test + @SuppressWarnings("PMD.UnusedReturnValue") public void testJARProtocol() throws Exception { uriResolver = new URIResolver(); diff --git a/integration/jca/src/test/java/org/apache/cxf/jca/core/classloader/PlugInClassLoaderTest.java b/integration/jca/src/test/java/org/apache/cxf/jca/core/classloader/PlugInClassLoaderTest.java index ddbe64e7448..cf1ddc74bcd 100644 --- a/integration/jca/src/test/java/org/apache/cxf/jca/core/classloader/PlugInClassLoaderTest.java +++ b/integration/jca/src/test/java/org/apache/cxf/jca/core/classloader/PlugInClassLoaderTest.java @@ -38,7 +38,7 @@ import static org.junit.Assert.assertTrue; import static org.junit.Assert.fail; - +@SuppressWarnings("PMD.UnusedReturnValue") public class PlugInClassLoaderTest { private static final Logger LOG = LogUtils.getLogger(PlugInClassLoaderTest.class); private static boolean debug; diff --git a/integration/spring-boot/autoconfigure/src/main/java/org/apache/cxf/spring/boot/autoconfigure/jaxws/CxfJaxwsAutoConfiguration.java b/integration/spring-boot/autoconfigure/src/main/java/org/apache/cxf/spring/boot/autoconfigure/jaxws/CxfJaxwsAutoConfiguration.java index c8cb94fdcfb..948f8aa70cd 100644 --- a/integration/spring-boot/autoconfigure/src/main/java/org/apache/cxf/spring/boot/autoconfigure/jaxws/CxfJaxwsAutoConfiguration.java +++ b/integration/spring-boot/autoconfigure/src/main/java/org/apache/cxf/spring/boot/autoconfigure/jaxws/CxfJaxwsAutoConfiguration.java @@ -33,6 +33,7 @@ @Configuration @ConditionalOnClass({ Resource.class, WebServiceContext.class }) +@SuppressWarnings("PMD.InstantiableUtilityClass") public class CxfJaxwsAutoConfiguration { @Bean static BeanFactoryPostProcessor jaxwsBeanFactoryPostProcessor() { diff --git a/integration/spring-boot/autoconfigure/src/test/java/org/apache/cxf/spring/boot/autoconfigure/micrometer/provider/SpringBasedTimedAnnotationProviderTest.java b/integration/spring-boot/autoconfigure/src/test/java/org/apache/cxf/spring/boot/autoconfigure/micrometer/provider/SpringBasedTimedAnnotationProviderTest.java index bbada8a885e..2bcf813a839 100644 --- a/integration/spring-boot/autoconfigure/src/test/java/org/apache/cxf/spring/boot/autoconfigure/micrometer/provider/SpringBasedTimedAnnotationProviderTest.java +++ b/integration/spring-boot/autoconfigure/src/test/java/org/apache/cxf/spring/boot/autoconfigure/micrometer/provider/SpringBasedTimedAnnotationProviderTest.java @@ -54,7 +54,7 @@ public class SpringBasedTimedAnnotationProviderTest { private MethodDispatcher methodDispatcher; @Before - @SuppressWarnings("PMD.UselessPureMethodCall") + @SuppressWarnings("PMD.UnusedReturnValue") public void setUp() { openMocks(this); underTest = new SpringBasedTimedAnnotationProvider(); diff --git a/maven-plugins/codegen-plugin/src/main/java/org/apache/cxf/maven_plugin/wsdl2java/WsdlOptionLoader.java b/maven-plugins/codegen-plugin/src/main/java/org/apache/cxf/maven_plugin/wsdl2java/WsdlOptionLoader.java index f70e0896b62..be8ebbd66af 100644 --- a/maven-plugins/codegen-plugin/src/main/java/org/apache/cxf/maven_plugin/wsdl2java/WsdlOptionLoader.java +++ b/maven-plugins/codegen-plugin/src/main/java/org/apache/cxf/maven_plugin/wsdl2java/WsdlOptionLoader.java @@ -121,7 +121,7 @@ private static String[] readOptionsFromFile(File dir, String wsdlName) throws Mo } } - protected static WsdlOption generateWsdlOptionFromFile(final File wsdl, + private static WsdlOption generateWsdlOptionFromFile(final File wsdl, File defaultOutputDir) throws MojoExecutionException { diff --git a/maven-plugins/wadl2java-plugin/src/main/java/org/apache/cxf/maven_plugin/wadlto/OptionLoader.java b/maven-plugins/wadl2java-plugin/src/main/java/org/apache/cxf/maven_plugin/wadlto/OptionLoader.java index 85e0254b51c..36ff02ca79b 100644 --- a/maven-plugins/wadl2java-plugin/src/main/java/org/apache/cxf/maven_plugin/wadlto/OptionLoader.java +++ b/maven-plugins/wadl2java-plugin/src/main/java/org/apache/cxf/maven_plugin/wadlto/OptionLoader.java @@ -138,7 +138,7 @@ private static List getWadlFiles(File dir, String[] includes, String[] exc } - protected static WadlOption generateWadlOptionFromFile(final File wadl, + private static WadlOption generateWadlOptionFromFile(final File wadl, final Option defaultOptions, File defaultOutputDir) throws MojoExecutionException { diff --git a/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaObjectReferenceEventProducer.java b/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaObjectReferenceEventProducer.java index e99a7e65794..4cd802a19d9 100644 --- a/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaObjectReferenceEventProducer.java +++ b/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaObjectReferenceEventProducer.java @@ -135,7 +135,7 @@ public List getAttributes() { return refAttrs; } - protected EprMetaData getObjectReferenceBinding(Definition wsdlDef, QName bindingName) { + private EprMetaData getObjectReferenceBinding(Definition wsdlDef, QName bindingName) { EprMetaData info = new EprMetaData(); Binding wsdlBinding = wsdlDef.getBinding(bindingName); diff --git a/rt/databinding/jaxb/src/main/java/org/apache/cxf/jaxb/JAXBContextInitializer.java b/rt/databinding/jaxb/src/main/java/org/apache/cxf/jaxb/JAXBContextInitializer.java index 131d2fe3a0c..f76b35486a3 100644 --- a/rt/databinding/jaxb/src/main/java/org/apache/cxf/jaxb/JAXBContextInitializer.java +++ b/rt/databinding/jaxb/src/main/java/org/apache/cxf/jaxb/JAXBContextInitializer.java @@ -83,7 +83,7 @@ class JAXBContextInitializer extends ServiceModelVisitor { } @Override - @SuppressWarnings("PMD.UselessPureMethodCall") + @SuppressWarnings("PMD.UnusedReturnValue") public void begin(MessagePartInfo part) { Class clazz = part.getTypeClass(); if (clazz == null) { diff --git a/rt/databinding/jaxb/src/test/java/org/apache/cxf/jaxb/JAXBDataBindingTest.java b/rt/databinding/jaxb/src/test/java/org/apache/cxf/jaxb/JAXBDataBindingTest.java index 145405b01bf..15f3e314f39 100644 --- a/rt/databinding/jaxb/src/test/java/org/apache/cxf/jaxb/JAXBDataBindingTest.java +++ b/rt/databinding/jaxb/src/test/java/org/apache/cxf/jaxb/JAXBDataBindingTest.java @@ -304,7 +304,7 @@ public void testResursiveType() throws Exception { assertEquals(2, classes.size()); } - public abstract static class Type2 extends AddressEntity { //NOPMD + public abstract static class Type2 extends AddressEntity { } public abstract static class AddressEntity> { diff --git a/rt/features/logging/src/main/java/org/apache/cxf/ext/logging/event/LogMessageFormatter.java b/rt/features/logging/src/main/java/org/apache/cxf/ext/logging/event/LogMessageFormatter.java index d83e01f0fed..b0d5f0e217f 100644 --- a/rt/features/logging/src/main/java/org/apache/cxf/ext/logging/event/LogMessageFormatter.java +++ b/rt/features/logging/src/main/java/org/apache/cxf/ext/logging/event/LogMessageFormatter.java @@ -55,11 +55,11 @@ public static String format(LogEvent event) { } return b.toString(); } - protected static String localPart(QName name) { + private static String localPart(QName name) { return name == null ? null : name.getLocalPart(); } - protected static void write(StringBuilder b, String key, String value) { + private static void write(StringBuilder b, String key, String value) { if (value != null) { b.append(" ").append(key).append(": ").append(value).append('\n'); } diff --git a/rt/features/metrics/src/test/java/org/apache/cxf/metrics/micrometer/provider/DefaultExceptionClassProviderTest.java b/rt/features/metrics/src/test/java/org/apache/cxf/metrics/micrometer/provider/DefaultExceptionClassProviderTest.java index 3088122d61c..865edefd82c 100644 --- a/rt/features/metrics/src/test/java/org/apache/cxf/metrics/micrometer/provider/DefaultExceptionClassProviderTest.java +++ b/rt/features/metrics/src/test/java/org/apache/cxf/metrics/micrometer/provider/DefaultExceptionClassProviderTest.java @@ -34,7 +34,7 @@ import static org.mockito.Mockito.doReturn; import static org.mockito.MockitoAnnotations.openMocks; -@SuppressWarnings("PMD.UselessPureMethodCall") +@SuppressWarnings("PMD.UnusedReturnValue") public class DefaultExceptionClassProviderTest { private static final Exception EXCEPTION_CAUSE = new CauseException(); diff --git a/rt/features/metrics/src/test/java/org/apache/cxf/metrics/micrometer/provider/DefaultTimedAnnotationProviderTest.java b/rt/features/metrics/src/test/java/org/apache/cxf/metrics/micrometer/provider/DefaultTimedAnnotationProviderTest.java index 3f9eb581ed2..11198ba9661 100644 --- a/rt/features/metrics/src/test/java/org/apache/cxf/metrics/micrometer/provider/DefaultTimedAnnotationProviderTest.java +++ b/rt/features/metrics/src/test/java/org/apache/cxf/metrics/micrometer/provider/DefaultTimedAnnotationProviderTest.java @@ -42,7 +42,7 @@ import static org.mockito.Mockito.doReturn; import static org.mockito.MockitoAnnotations.openMocks; -@SuppressWarnings({"unused", "PMD.UselessPureMethodCall"}) +@SuppressWarnings({"unused", "PMD.UnusedReturnValue"}) public class DefaultTimedAnnotationProviderTest { private DefaultTimedAnnotationProvider underTest; diff --git a/rt/features/metrics/src/test/java/org/apache/cxf/metrics/micrometer/provider/StandardTagsTest.java b/rt/features/metrics/src/test/java/org/apache/cxf/metrics/micrometer/provider/StandardTagsTest.java index 1550aa5fa67..9937d249919 100644 --- a/rt/features/metrics/src/test/java/org/apache/cxf/metrics/micrometer/provider/StandardTagsTest.java +++ b/rt/features/metrics/src/test/java/org/apache/cxf/metrics/micrometer/provider/StandardTagsTest.java @@ -37,7 +37,7 @@ import static org.mockito.MockitoAnnotations.openMocks; -@SuppressWarnings("PMD.UselessPureMethodCall") +@SuppressWarnings("PMD.UnusedReturnValue") public class StandardTagsTest { private static final String DUMMY_METHOD_NAME = "dummyMethod"; diff --git a/rt/features/metrics/src/test/java/org/apache/cxf/metrics/micrometer/provider/jaxws/JaxwsFaultCodeProviderTest.java b/rt/features/metrics/src/test/java/org/apache/cxf/metrics/micrometer/provider/jaxws/JaxwsFaultCodeProviderTest.java index 0879e8211dc..8a160f4f3b7 100644 --- a/rt/features/metrics/src/test/java/org/apache/cxf/metrics/micrometer/provider/jaxws/JaxwsFaultCodeProviderTest.java +++ b/rt/features/metrics/src/test/java/org/apache/cxf/metrics/micrometer/provider/jaxws/JaxwsFaultCodeProviderTest.java @@ -35,7 +35,7 @@ import static org.mockito.Mockito.doReturn; import static org.mockito.MockitoAnnotations.openMocks; -@SuppressWarnings("PMD.UselessPureMethodCall") +@SuppressWarnings("PMD.UnusedReturnValue") public class JaxwsFaultCodeProviderTest { private static final String RUNTIME_FAULT_STRING = "RUNTIME_FAULT"; diff --git a/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/ResponseImpl.java b/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/ResponseImpl.java index 1b7a37dbae6..1052895faaa 100644 --- a/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/ResponseImpl.java +++ b/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/ResponseImpl.java @@ -553,11 +553,11 @@ private void reportMessageHandlerProblem(String name, Class cls, MediaType ct throw new ResponseProcessingException(this, errorMessage, cause); } - protected void autoClose(Class cls, boolean exception) { + void autoClose(Class cls, boolean exception) { autoCloseWithHint(cls, false, exception); } - protected void autoCloseWithHint(Class cls, boolean autoCloseHint, boolean exception) { + void autoCloseWithHint(Class cls, boolean autoCloseHint, boolean exception) { if (!entityBufferred && !JAXRSUtils.isStreamingOutType(cls) && (exception || MessageUtils.getContextualBoolean(outMessage, RESPONSE_STREAM_AUTO_CLOSE, autoCloseHint))) { diff --git a/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/provider/ServerProviderFactory.java b/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/provider/ServerProviderFactory.java index beb06b382ea..d9be9178050 100644 --- a/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/provider/ServerProviderFactory.java +++ b/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/provider/ServerProviderFactory.java @@ -281,7 +281,7 @@ protected void setProviders(boolean custom, boolean busGlobal, Object... provide containerResponseFilters.values()); } - protected void injectApplicationIntoFeature(Feature feature) { + private void injectApplicationIntoFeature(Feature feature) { if (application != null) { AbstractResourceInfo info = new AbstractResourceInfo(feature.getClass(), ClassHelper.getRealClass(feature), @@ -451,7 +451,7 @@ private FeatureContext createServerFeatureContext() { return featureContext; } - protected static boolean isPrematching(Class filterCls) { + private static boolean isPrematching(Class filterCls) { return AnnotationUtils.getClassAnnotation(filterCls, PreMatching.class) != null; } diff --git a/rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/EndpointReferenceTest.java b/rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/EndpointReferenceTest.java index f7875d9a522..7781e86d4d9 100644 --- a/rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/EndpointReferenceTest.java +++ b/rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/EndpointReferenceTest.java @@ -326,7 +326,7 @@ public void testProviderGetPort() throws Exception { } final class MyEndpointReference extends EndpointReference { - protected MyEndpointReference() { + MyEndpointReference() { } public void writeTo(Result result) { diff --git a/rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/spi/WrapperClassLoaderTest.java b/rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/spi/WrapperClassLoaderTest.java index cdbc9f51e25..715ce0101c2 100644 --- a/rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/spi/WrapperClassLoaderTest.java +++ b/rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/spi/WrapperClassLoaderTest.java @@ -140,7 +140,7 @@ public void testWrapperClassLoaderWithWrappedOperationsAndLegacyConvention() thr loadedClassNames); } - @SuppressWarnings("PMD.UselessPureMethodCall") + @SuppressWarnings("PMD.UnusedReturnValue") private List testWrapperClassLoaderWithNamingConvention(WrapperClassNamingConvention convention) throws Exception { bus.setExtension(convention, WrapperClassNamingConvention.class); diff --git a/rt/rs/client/src/main/java/org/apache/cxf/jaxrs/client/WebClient.java b/rt/rs/client/src/main/java/org/apache/cxf/jaxrs/client/WebClient.java index f8753f68385..74f79e11681 100644 --- a/rt/rs/client/src/main/java/org/apache/cxf/jaxrs/client/WebClient.java +++ b/rt/rs/client/src/main/java/org/apache/cxf/jaxrs/client/WebClient.java @@ -1201,7 +1201,7 @@ protected Response handleResponse(Message outMessage, Class responseClass, Ty } } - + @SuppressWarnings("PMD.ProtectedMemberInFinalClass") private final class BodyWriter extends AbstractBodyWriter { protected void doWriteBody(Message outMessage, diff --git a/rt/rs/client/src/test/java/org/apache/cxf/jaxrs/client/JAXRSClientFactoryBeanTest.java b/rt/rs/client/src/test/java/org/apache/cxf/jaxrs/client/JAXRSClientFactoryBeanTest.java index f9162ec1b73..f33c9348b9b 100644 --- a/rt/rs/client/src/test/java/org/apache/cxf/jaxrs/client/JAXRSClientFactoryBeanTest.java +++ b/rt/rs/client/src/test/java/org/apache/cxf/jaxrs/client/JAXRSClientFactoryBeanTest.java @@ -321,7 +321,7 @@ protected void initializeProvider(InterceptorProvider provider, Bus bus) { provider.getOutInterceptors().add(testInterceptor); } - protected boolean isInitialized() { + private boolean isInitialized() { return testInterceptor.isInitialized(); } } diff --git a/rt/rs/description-common-openapi/src/main/java/org/apache/cxf/jaxrs/common/openapi/DefaultApplicationFactory.java b/rt/rs/description-common-openapi/src/main/java/org/apache/cxf/jaxrs/common/openapi/DefaultApplicationFactory.java index 0df99605476..796d99dab54 100644 --- a/rt/rs/description-common-openapi/src/main/java/org/apache/cxf/jaxrs/common/openapi/DefaultApplicationFactory.java +++ b/rt/rs/description-common-openapi/src/main/java/org/apache/cxf/jaxrs/common/openapi/DefaultApplicationFactory.java @@ -33,7 +33,7 @@ import org.apache.cxf.jaxrs.provider.ServerProviderFactory; public final class DefaultApplicationFactory { - protected static class DefaultApplication extends Application { + static class DefaultApplication extends Application { private final Set> serviceClasses; DefaultApplication(final Set> serviceClasses) { diff --git a/rt/security/src/main/java/org/apache/cxf/rt/security/SecurityConstants.java b/rt/security/src/main/java/org/apache/cxf/rt/security/SecurityConstants.java index 01a1339600c..d29f91c4dbb 100644 --- a/rt/security/src/main/java/org/apache/cxf/rt/security/SecurityConstants.java +++ b/rt/security/src/main/java/org/apache/cxf/rt/security/SecurityConstants.java @@ -36,6 +36,7 @@ * More specific configuration tags for WS-SecurityPolicy are configured in the SecurityConstants * class in the cxf-rt-ws-security module, which extends this class. */ +@SuppressWarnings("PMD.InstantiableUtilityClass") public class SecurityConstants { // diff --git a/rt/security/src/main/java/org/apache/cxf/rt/security/rs/RSSecurityConstants.java b/rt/security/src/main/java/org/apache/cxf/rt/security/rs/RSSecurityConstants.java index e77d6b0f49c..20a843f9dbd 100644 --- a/rt/security/src/main/java/org/apache/cxf/rt/security/rs/RSSecurityConstants.java +++ b/rt/security/src/main/java/org/apache/cxf/rt/security/rs/RSSecurityConstants.java @@ -23,6 +23,7 @@ * Some common security constants that can be used RS-Security (for now they are used in the * JOSE + HTTP Signature modules). */ +@SuppressWarnings("PMD.InstantiableUtilityClass") public class RSSecurityConstants { /** diff --git a/rt/transports/http/src/test/java/org/apache/cxf/transport/http/spring/HttpConduitConfigurationTest.java b/rt/transports/http/src/test/java/org/apache/cxf/transport/http/spring/HttpConduitConfigurationTest.java index e6a14b924e0..f652dfac3e4 100644 --- a/rt/transports/http/src/test/java/org/apache/cxf/transport/http/spring/HttpConduitConfigurationTest.java +++ b/rt/transports/http/src/test/java/org/apache/cxf/transport/http/spring/HttpConduitConfigurationTest.java @@ -116,6 +116,8 @@ private void verifyConduit(HTTPConduit conduit) { public static final class ManagersFactory { + private ManagersFactory() { + } public static KeyManager[] getKeyManagers() { KeyManagersType kmt = new KeyManagersType(); diff --git a/rt/transports/jms/src/main/java/org/apache/cxf/transport/jms/util/PollingMessageListenerContainer.java b/rt/transports/jms/src/main/java/org/apache/cxf/transport/jms/util/PollingMessageListenerContainer.java index 1756cde2795..180bebd70ef 100644 --- a/rt/transports/jms/src/main/java/org/apache/cxf/transport/jms/util/PollingMessageListenerContainer.java +++ b/rt/transports/jms/src/main/java/org/apache/cxf/transport/jms/util/PollingMessageListenerContainer.java @@ -107,7 +107,7 @@ public void run() { } } - protected void safeRollBack(Session session) { + void safeRollBack(Session session) { try { if (session != null && session.getTransacted()) { session.rollback(); diff --git a/rt/transports/jms/src/test/java/org/apache/cxf/transport/jms/AbstractJMSTester.java b/rt/transports/jms/src/test/java/org/apache/cxf/transport/jms/AbstractJMSTester.java index d0f807fbae9..7329dd32e92 100644 --- a/rt/transports/jms/src/test/java/org/apache/cxf/transport/jms/AbstractJMSTester.java +++ b/rt/transports/jms/src/test/java/org/apache/cxf/transport/jms/AbstractJMSTester.java @@ -252,6 +252,7 @@ protected static Message createMessage(String correlationId) { return outMessage; } + @SuppressWarnings("PMD.UnusedReturnValue") protected static void verifyReceivedMessage(Message message) { String response = ""; InputStream bis = message.getContent(InputStream.class); diff --git a/rt/transports/local/src/main/java/org/apache/cxf/transport/local/LocalConduit.java b/rt/transports/local/src/main/java/org/apache/cxf/transport/local/LocalConduit.java index f189497be29..ade8a99e668 100644 --- a/rt/transports/local/src/main/java/org/apache/cxf/transport/local/LocalConduit.java +++ b/rt/transports/local/src/main/java/org/apache/cxf/transport/local/LocalConduit.java @@ -64,7 +64,8 @@ public void close() throws IOException { protected void onFirstWrite() throws IOException { dispatchToService(false); } - protected void dispatchToService(boolean empty) throws IOException { + + void dispatchToService(boolean empty) throws IOException { final MessageImpl inMsg = new MessageImpl(); transportFactory.copy(message, inMsg); diff --git a/rt/transports/local/src/main/java/org/apache/cxf/transport/local/LocalDestination.java b/rt/transports/local/src/main/java/org/apache/cxf/transport/local/LocalDestination.java index 16d558aa6c7..8dae831f710 100644 --- a/rt/transports/local/src/main/java/org/apache/cxf/transport/local/LocalDestination.java +++ b/rt/transports/local/src/main/java/org/apache/cxf/transport/local/LocalDestination.java @@ -97,7 +97,7 @@ protected void onFirstWrite() throws IOException { dispatchToClient(false); } - protected void dispatchToClient(boolean empty) throws IOException { + void dispatchToClient(boolean empty) throws IOException { final MessageImpl m = new MessageImpl(); localDestinationFactory.copy(message, m); if (!empty) { diff --git a/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/EncoderDecoder10AImpl.java b/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/EncoderDecoder10AImpl.java index 775aa899bda..58ea2690bdb 100644 --- a/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/EncoderDecoder10AImpl.java +++ b/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/EncoderDecoder10AImpl.java @@ -54,6 +54,7 @@ * WS-ReliableMessaging 1.0 encoding and decoding. This converts between the standard WS-RM objects and the * 1.0 representation using the WS-Addressing recommendation 200508 namespace. */ +@SuppressWarnings("PMD.ProtectedMemberInFinalClass") public final class EncoderDecoder10AImpl extends EncoderDecoder { public static final EncoderDecoder10AImpl INSTANCE = new EncoderDecoder10AImpl(); diff --git a/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/EncoderDecoder10Impl.java b/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/EncoderDecoder10Impl.java index 8cb62a7c1d0..899fc5aa0a2 100644 --- a/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/EncoderDecoder10Impl.java +++ b/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/EncoderDecoder10Impl.java @@ -54,6 +54,7 @@ * WS-ReliableMessaging 1.0 encoding and decoding. This converts between the standard WS-RM objects and the * 1.0 representation using the WS-Addressing 200408 namespace specified in the WS-RM 1.0 recommendation. */ +@SuppressWarnings("PMD.ProtectedMemberInFinalClass") public final class EncoderDecoder10Impl extends EncoderDecoder { public static final EncoderDecoder10Impl INSTANCE = new EncoderDecoder10Impl(); diff --git a/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/EncoderDecoder11Impl.java b/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/EncoderDecoder11Impl.java index fdfcfcc71db..14f73537b4c 100644 --- a/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/EncoderDecoder11Impl.java +++ b/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/EncoderDecoder11Impl.java @@ -56,6 +56,7 @@ * WS-ReliableMessaging 1.1/1.2 encoding and decoding. This just works with the standard internal form of the * WS-RM data structures. */ +@SuppressWarnings("PMD.ProtectedMemberInFinalClass") public final class EncoderDecoder11Impl extends EncoderDecoder { public static final EncoderDecoder11Impl INSTANCE = new EncoderDecoder11Impl(); diff --git a/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/RMContextUtils.java b/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/RMContextUtils.java index 5a0dda766e5..d813e549782 100644 --- a/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/RMContextUtils.java +++ b/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/RMContextUtils.java @@ -26,7 +26,7 @@ /** * Holder for utility methods relating to contexts. */ - +@SuppressWarnings({ "PMD.InstantiableUtilityClass", "PMD.ProtectedMemberInFinalClass" }) public final class RMContextUtils { /** diff --git a/rt/ws/rm/src/test/java/org/apache/cxf/ws/rm/AbstractRMInterceptorTest.java b/rt/ws/rm/src/test/java/org/apache/cxf/ws/rm/AbstractRMInterceptorTest.java index 5c60035db81..867b5a567c7 100644 --- a/rt/ws/rm/src/test/java/org/apache/cxf/ws/rm/AbstractRMInterceptorTest.java +++ b/rt/ws/rm/src/test/java/org/apache/cxf/ws/rm/AbstractRMInterceptorTest.java @@ -48,7 +48,7 @@ /** * */ -@SuppressWarnings("PMD.UselessPureMethodCall") +@SuppressWarnings("PMD.UnusedReturnValue") public class AbstractRMInterceptorTest { @Test public void testAccessors() { diff --git a/rt/ws/rm/src/test/java/org/apache/cxf/ws/rm/RMManagerTest.java b/rt/ws/rm/src/test/java/org/apache/cxf/ws/rm/RMManagerTest.java index b0a57cd1eaf..4579a30eea6 100644 --- a/rt/ws/rm/src/test/java/org/apache/cxf/ws/rm/RMManagerTest.java +++ b/rt/ws/rm/src/test/java/org/apache/cxf/ws/rm/RMManagerTest.java @@ -704,6 +704,7 @@ public void testDefaultSequenceIdentifierGenerator() { } // just read the begining of the input and compare it against the specified string + @SuppressWarnings("PMD.UnusedReturnValue") private static boolean assertStartsWith(InputStream in, String starting) { assertNotNull(in); byte[] buf = new byte[starting.length()]; diff --git a/rt/ws/rm/src/test/java/org/apache/cxf/ws/rm/persistence/PersistenceUtilsTest.java b/rt/ws/rm/src/test/java/org/apache/cxf/ws/rm/persistence/PersistenceUtilsTest.java index 9d406b84029..3fe324733c8 100644 --- a/rt/ws/rm/src/test/java/org/apache/cxf/ws/rm/persistence/PersistenceUtilsTest.java +++ b/rt/ws/rm/src/test/java/org/apache/cxf/ws/rm/persistence/PersistenceUtilsTest.java @@ -149,6 +149,7 @@ private static void addAttachment(Message msg) throws IOException { } // just read the beginning of the input and compare it against the specified string + @SuppressWarnings("PMD.UnusedReturnValue") private static boolean assertStartsWith(InputStream in, String starting) { assertNotNull(in); byte[] buf = new byte[starting.length()]; diff --git a/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/BookContinuationStore.java b/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/BookContinuationStore.java index 65c869db094..278542d1162 100644 --- a/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/BookContinuationStore.java +++ b/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/BookContinuationStore.java @@ -96,7 +96,7 @@ public void getBookNoContentInterface(@Suspended AsyncResponse async) { @GET @Path("/books/cancel") - @SuppressWarnings("PMD.UselessPureMethodCall") + @SuppressWarnings("PMD.UnusedReturnValue") public void getBookDescriptionWithCancel(@PathParam("id") String id, @Suspended AsyncResponse async) { PhaseInterceptorChain.getCurrentMessage().getClass(); diff --git a/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/ClientHttpConnectionOutInterceptor.java b/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/ClientHttpConnectionOutInterceptor.java index 3820587308d..a78c2c8041a 100644 --- a/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/ClientHttpConnectionOutInterceptor.java +++ b/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/ClientHttpConnectionOutInterceptor.java @@ -54,7 +54,8 @@ public boolean checkAllClosed() { .anyMatch(this::isClosedInputStream); } } - + + @SuppressWarnings("PMD.UnusedReturnValue") private boolean isClosedInputStream(Message message) { try { final InputStream inputStream = message.getExchange().getInMessage().getContent(InputStream.class); diff --git a/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/reactive/RxJava2MaybeService.java b/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/reactive/RxJava2MaybeService.java index 06b66a9b1e0..108d9619683 100644 --- a/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/reactive/RxJava2MaybeService.java +++ b/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/reactive/RxJava2MaybeService.java @@ -43,6 +43,7 @@ public Maybe getJson() { @GET @Produces("text/plain") @Path("textAsync") + @SuppressWarnings("PMD.UnusedReturnValue") public void getTextAsync(@Suspended final AsyncResponse ar) { final StringAsyncSubscriber subscriber = new StringAsyncSubscriber(ar); diff --git a/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/reactive/RxJava2SingleService.java b/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/reactive/RxJava2SingleService.java index 0a4eed832e3..88b14dd94cd 100644 --- a/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/reactive/RxJava2SingleService.java +++ b/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/reactive/RxJava2SingleService.java @@ -41,6 +41,7 @@ public Single getJson() { @GET @Produces("text/plain") @Path("textAsync") + @SuppressWarnings("PMD.UnusedReturnValue") public void getTextAsync(@Suspended final AsyncResponse ar) { final StringAsyncSubscriber subscriber = new StringAsyncSubscriber(ar); diff --git a/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/reactive/RxJava3MaybeService.java b/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/reactive/RxJava3MaybeService.java index c4c524de7f7..5359c80ffcb 100644 --- a/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/reactive/RxJava3MaybeService.java +++ b/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/reactive/RxJava3MaybeService.java @@ -43,6 +43,7 @@ public Maybe getJson() { @GET @Produces("text/plain") @Path("textAsync") + @SuppressWarnings("PMD.UnusedReturnValue") public void getTextAsync(@Suspended final AsyncResponse ar) { final StringAsyncSubscriber subscriber = new StringAsyncSubscriber(ar); diff --git a/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/reactive/RxJava3SingleService.java b/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/reactive/RxJava3SingleService.java index 162126dcaaa..fc4da158f4f 100644 --- a/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/reactive/RxJava3SingleService.java +++ b/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/reactive/RxJava3SingleService.java @@ -41,6 +41,7 @@ public Single getJson() { @GET @Produces("text/plain") @Path("textAsync") + @SuppressWarnings("PMD.UnusedReturnValue") public void getTextAsync(@Suspended final AsyncResponse ar) { final StringAsyncSubscriber subscriber = new StringAsyncSubscriber(ar); diff --git a/systests/jaxws/src/test/java/org/apache/cxf/systest/swa/ClientServerSwaTest.java b/systests/jaxws/src/test/java/org/apache/cxf/systest/swa/ClientServerSwaTest.java index e574acb0957..283b6d04b75 100644 --- a/systests/jaxws/src/test/java/org/apache/cxf/systest/swa/ClientServerSwaTest.java +++ b/systests/jaxws/src/test/java/org/apache/cxf/systest/swa/ClientServerSwaTest.java @@ -64,6 +64,7 @@ import static org.junit.Assert.assertTrue; @RunWith(value = Parameterized.class) +@SuppressWarnings("PMD.UnusedReturnValue") public class ClientServerSwaTest extends AbstractBusClientServerTestBase { static String serverPort = TestUtil.getPortNumber(SwaServer.class); static String serverPortInvalid = TestUtil.getPortNumber(SwaServer.class, 1); diff --git a/systests/jaxws/src/test/java/org/apache/cxf/systest/swa/SwANoMimeServiceImpl.java b/systests/jaxws/src/test/java/org/apache/cxf/systest/swa/SwANoMimeServiceImpl.java index 0c8e17f9f04..9c525194875 100644 --- a/systests/jaxws/src/test/java/org/apache/cxf/systest/swa/SwANoMimeServiceImpl.java +++ b/systests/jaxws/src/test/java/org/apache/cxf/systest/swa/SwANoMimeServiceImpl.java @@ -98,6 +98,7 @@ public void echoData(Holder text, Holder data) { data.value = ("test" + new String(data.value, 0, 6)).getBytes(StandardCharsets.UTF_8); } + @SuppressWarnings("PMD.UnusedReturnValue") public void echoDataRef(Holder data) { try { InputStream bis = null; diff --git a/systests/jaxws/src/test/java/org/apache/cxf/systest/swa/SwAServiceImpl.java b/systests/jaxws/src/test/java/org/apache/cxf/systest/swa/SwAServiceImpl.java index abdeac71e88..7abd1216479 100644 --- a/systests/jaxws/src/test/java/org/apache/cxf/systest/swa/SwAServiceImpl.java +++ b/systests/jaxws/src/test/java/org/apache/cxf/systest/swa/SwAServiceImpl.java @@ -40,6 +40,7 @@ serviceName = "SwAService", targetNamespace = "http://cxf.apache.org/swa", portName = "SwAServiceHttpPort") +@SuppressWarnings("PMD.UnusedReturnValue") public class SwAServiceImpl implements SwAServiceInterface { public void echoDataRef(Holder data) { diff --git a/systests/transport-jms/src/test/java/org/apache/cxf/systest/jms/swa/ClientServerSwaTest.java b/systests/transport-jms/src/test/java/org/apache/cxf/systest/jms/swa/ClientServerSwaTest.java index e8dd84a465b..17bf0fafb88 100644 --- a/systests/transport-jms/src/test/java/org/apache/cxf/systest/jms/swa/ClientServerSwaTest.java +++ b/systests/transport-jms/src/test/java/org/apache/cxf/systest/jms/swa/ClientServerSwaTest.java @@ -41,6 +41,7 @@ import static org.junit.Assert.assertEquals; +@SuppressWarnings("PMD.UnusedReturnValue") public class ClientServerSwaTest extends AbstractBusClientServerTestBase { public static final String ADDRESS = "jms:jndi:dynamicQueues/test.cxf.jmstransport.swa.queue" diff --git a/systests/transport-jms/src/test/java/org/apache/cxf/systest/jms/swa/SwAServiceImpl.java b/systests/transport-jms/src/test/java/org/apache/cxf/systest/jms/swa/SwAServiceImpl.java index bb3f711d3fc..912870c81f8 100644 --- a/systests/transport-jms/src/test/java/org/apache/cxf/systest/jms/swa/SwAServiceImpl.java +++ b/systests/transport-jms/src/test/java/org/apache/cxf/systest/jms/swa/SwAServiceImpl.java @@ -40,6 +40,7 @@ serviceName = "SwAService", targetNamespace = "http://cxf.apache.org/swa", portName = "SwAServiceHttpPort") +@SuppressWarnings("PMD.UnusedReturnValue") public class SwAServiceImpl implements SwAServiceInterface { public void echoDataRef(Holder data) { diff --git a/systests/transport-undertow/src/test/java/org/apache/cxf/systest/http_undertow/multipart/SwANoMimeServiceImpl.java b/systests/transport-undertow/src/test/java/org/apache/cxf/systest/http_undertow/multipart/SwANoMimeServiceImpl.java index 751925340e0..b8faec049f5 100644 --- a/systests/transport-undertow/src/test/java/org/apache/cxf/systest/http_undertow/multipart/SwANoMimeServiceImpl.java +++ b/systests/transport-undertow/src/test/java/org/apache/cxf/systest/http_undertow/multipart/SwANoMimeServiceImpl.java @@ -98,6 +98,7 @@ public void echoData(Holder text, Holder data) { data.value = ("test" + new String(data.value, 0, 6)).getBytes(StandardCharsets.UTF_8); } + @SuppressWarnings("PMD.UnusedReturnValue") public void echoDataRef(Holder data) { try { InputStream bis = null; diff --git a/systests/transport-undertow/src/test/java/org/apache/cxf/systest/http_undertow/multipart/SwAServiceImpl.java b/systests/transport-undertow/src/test/java/org/apache/cxf/systest/http_undertow/multipart/SwAServiceImpl.java index 30d215c72d6..19a22e3c1e4 100644 --- a/systests/transport-undertow/src/test/java/org/apache/cxf/systest/http_undertow/multipart/SwAServiceImpl.java +++ b/systests/transport-undertow/src/test/java/org/apache/cxf/systest/http_undertow/multipart/SwAServiceImpl.java @@ -40,6 +40,7 @@ serviceName = "SwAService", targetNamespace = "http://cxf.apache.org/swa", portName = "SwAServiceHttpPort") +@SuppressWarnings("PMD.UnusedReturnValue") public class SwAServiceImpl implements SwAServiceInterface { public void echoDataRef(Holder data) { diff --git a/systests/transports/src/test/java/org/apache/cxf/systest/http_jetty/EngineLifecycleTest.java b/systests/transports/src/test/java/org/apache/cxf/systest/http_jetty/EngineLifecycleTest.java index 7c7d4fec466..b0ad8c885d8 100644 --- a/systests/transports/src/test/java/org/apache/cxf/systest/http_jetty/EngineLifecycleTest.java +++ b/systests/transports/src/test/java/org/apache/cxf/systest/http_jetty/EngineLifecycleTest.java @@ -126,6 +126,7 @@ private void invokeService8801() { assertEquals("We should get out put from this client", "hello world", client.echo("hello world")); } + @SuppressWarnings("PMD.UnusedReturnValue") private static void verifyStaticHtml() throws Exception { String response = null; for (int i = 0; i < 50 && null == response; i++) { diff --git a/systests/transports/src/test/java/org/apache/cxf/systest/https/conduit/HTTPSClientTest.java b/systests/transports/src/test/java/org/apache/cxf/systest/https/conduit/HTTPSClientTest.java index ab692e4c068..34eaf1c6fff 100644 --- a/systests/transports/src/test/java/org/apache/cxf/systest/https/conduit/HTTPSClientTest.java +++ b/systests/transports/src/test/java/org/apache/cxf/systest/https/conduit/HTTPSClientTest.java @@ -193,6 +193,7 @@ public final void testResourceKeySpecEndpointURL() throws Exception { } + @SuppressWarnings("PMD.InstantiableUtilityClass") public static class ServerManagersFactory { public static KeyManager[] getKeyManagers() { KeyManagersType kmt = new KeyManagersType(); @@ -226,6 +227,7 @@ public static TrustManager[] getTrustManagers() { } } + @SuppressWarnings("PMD.InstantiableUtilityClass") public static class ClientManagersFactory { public static KeyManager[] getKeyManagers() { KeyManagersType kmt = new KeyManagersType(); diff --git a/systests/uncategorized/src/test/java/org/apache/cxf/systest/mtom/ClientMtomXopTest.java b/systests/uncategorized/src/test/java/org/apache/cxf/systest/mtom/ClientMtomXopTest.java index 21ab9a7afed..5432e474f9f 100644 --- a/systests/uncategorized/src/test/java/org/apache/cxf/systest/mtom/ClientMtomXopTest.java +++ b/systests/uncategorized/src/test/java/org/apache/cxf/systest/mtom/ClientMtomXopTest.java @@ -70,6 +70,7 @@ import static org.junit.Assert.assertTrue; import static org.junit.Assert.fail; +@SuppressWarnings("PMD.UnusedReturnValue") public class ClientMtomXopTest extends AbstractBusClientServerTestBase { public static final String PORT = allocatePort(ClientMtomXopTest.class); public static final QName MTOM_PORT = new QName("http://cxf.apache.org/mime", "TestMtomPort"); diff --git a/systests/uncategorized/src/test/java/org/apache/cxf/systest/mtom/ClientMtomXopWithJMSTest.java b/systests/uncategorized/src/test/java/org/apache/cxf/systest/mtom/ClientMtomXopWithJMSTest.java index 84e0657c3f3..9764c7518fd 100644 --- a/systests/uncategorized/src/test/java/org/apache/cxf/systest/mtom/ClientMtomXopWithJMSTest.java +++ b/systests/uncategorized/src/test/java/org/apache/cxf/systest/mtom/ClientMtomXopWithJMSTest.java @@ -80,6 +80,7 @@ public static void stopServers() throws Exception { } @Test + @SuppressWarnings("PMD.UnusedReturnValue") public void testMtomXop() throws Exception { TestMtom mtomPort = createPort(MTOM_SERVICE, MTOM_PORT, TestMtom.class, true); InputStream pre = this.getClass().getResourceAsStream("/wsdl/mtom_xop.wsdl"); diff --git a/systests/ws-transfer/src/test/java/org/apache/cxf/systest/ws/transfer/TestUtils.java b/systests/ws-transfer/src/test/java/org/apache/cxf/systest/ws/transfer/TestUtils.java index 967c52a7c60..d9b94ad0b49 100644 --- a/systests/ws-transfer/src/test/java/org/apache/cxf/systest/ws/transfer/TestUtils.java +++ b/systests/ws-transfer/src/test/java/org/apache/cxf/systest/ws/transfer/TestUtils.java @@ -60,14 +60,14 @@ private TestUtils() { } - protected static ResourceFactory createResourceFactoryClient(String port) { + static ResourceFactory createResourceFactoryClient(String port) { JaxWsProxyFactoryBean factory = new JaxWsProxyFactoryBean(); factory.setServiceClass(org.apache.cxf.ws.transfer.resourcefactory.ResourceFactory.class); factory.setAddress("http://localhost:" + port + "/ResourceFactory"); return (ResourceFactory) factory.create(); } - protected static Resource createResourceClient(EndpointReferenceType ref) { + static Resource createResourceClient(EndpointReferenceType ref) { JaxWsProxyFactoryBean factory = new JaxWsProxyFactoryBean(); factory.setServiceClass(Resource.class); factory.setAddress(ref.getAddress().getValue()); @@ -81,14 +81,14 @@ protected static Resource createResourceClient(EndpointReferenceType ref) { return proxy; } - protected static void createStudentsServers(String port, String port2) { + static void createStudentsServers(String port, String port2) { UIDManager.reset(); ResourceManager studentsResourceManager = new MemoryResourceManager(); resourceFactoryServer = createResourceFactory(studentsResourceManager, port, port2); studentsResourceServer = createStudentsResource(studentsResourceManager, port); } - protected static void createTeachersServers(String port) { + static void createTeachersServers(String port) { ResourceManager teachersResourceManager = new MemoryResourceManager(); ResourceRemote resource = new ResourceRemote(); resource.setManager(teachersResourceManager); @@ -101,12 +101,12 @@ protected static void createTeachersServers(String port) { teachersResourceServer = createTeacherResourceEndpoint(resource, port); } - protected static void destroyStudentsServers() { + static void destroyStudentsServers() { resourceFactoryServer.destroy(); studentsResourceServer.destroy(); } - protected static void destroyTeachersServers() { + static void destroyTeachersServers() { teachersResourceFactoryServer.destroy(); teachersResourceServer.destroy(); } diff --git a/testutils/src/main/java/org/apache/cxf/mtom_xop/TestMtomProviderImpl.java b/testutils/src/main/java/org/apache/cxf/mtom_xop/TestMtomProviderImpl.java index a22260745ed..fef567a1ed1 100644 --- a/testutils/src/main/java/org/apache/cxf/mtom_xop/TestMtomProviderImpl.java +++ b/testutils/src/main/java/org/apache/cxf/mtom_xop/TestMtomProviderImpl.java @@ -46,6 +46,7 @@ public class TestMtomProviderImpl implements Provider { + @SuppressWarnings("PMD.UnusedReturnValue") public SOAPMessage invoke(final SOAPMessage request) { try { System.out.println("=== Received client request ==="); diff --git a/tools/common/src/main/java/org/apache/cxf/tools/common/model/JAnnotation.java b/tools/common/src/main/java/org/apache/cxf/tools/common/model/JAnnotation.java index b861bbcce74..ea219bf58ae 100644 --- a/tools/common/src/main/java/org/apache/cxf/tools/common/model/JAnnotation.java +++ b/tools/common/src/main/java/org/apache/cxf/tools/common/model/JAnnotation.java @@ -46,7 +46,7 @@ public Set getImports() { return imports; } - @SuppressWarnings("PMD.UselessPureMethodCall") + @SuppressWarnings("PMD.UnusedReturnValue") private void prompt() { toString(); } diff --git a/tools/common/src/main/java/org/apache/cxf/tools/util/NameUtil.java b/tools/common/src/main/java/org/apache/cxf/tools/util/NameUtil.java index 47f93d472b5..e846e8c80f8 100644 --- a/tools/common/src/main/java/org/apache/cxf/tools/util/NameUtil.java +++ b/tools/common/src/main/java/org/apache/cxf/tools/util/NameUtil.java @@ -51,13 +51,13 @@ private NameUtil() { } } - protected static boolean isPunct(char c) { + private static boolean isPunct(char c) { boolean isPunct = c == '-' || c == '.' || c == ':' || c == '_'; boolean isUnicodePunct = c == '\u00b7' || c == '\u0387' || c == '\u06dd' || c == '\u06de'; return isPunct || isUnicodePunct; } - protected static boolean isLower(char c) { + private static boolean isLower(char c) { return c >= 'a' && c <= 'z' || Character.isLowerCase(c); } @@ -120,7 +120,7 @@ private static boolean xor(boolean x, boolean y) { return (x && y) || (!x && !y); } - protected static int classify(char c0) { + private static int classify(char c0) { switch (Character.getType(c0)) { case Character.UPPERCASE_LETTER: return UPPER_LETTER; @@ -166,7 +166,7 @@ public static List toWordList(String s, boolean allowUnderscore) { return ss; } - protected static String toMixedCaseName(List ss, boolean startUpper) { + private static String toMixedCaseName(List ss, boolean startUpper) { StringBuilder sb = new StringBuilder(); if (!ss.isEmpty()) { sb.append(startUpper ? ss.get(0) : ss.get(0).toLowerCase()); @@ -177,7 +177,7 @@ protected static String toMixedCaseName(List ss, boolean startUpper) { return sb.toString(); } - protected static String toMixedCaseVariableName(String[] ss, + static String toMixedCaseVariableName(String[] ss, boolean startUpper, boolean cdrUpper) { if (cdrUpper) { diff --git a/tools/corba/src/main/java/org/apache/cxf/tools/corba/common/idltypes/CorbaUtils.java b/tools/corba/src/main/java/org/apache/cxf/tools/corba/common/idltypes/CorbaUtils.java index e429d4dfbd5..488b1f38f10 100644 --- a/tools/corba/src/main/java/org/apache/cxf/tools/corba/common/idltypes/CorbaUtils.java +++ b/tools/corba/src/main/java/org/apache/cxf/tools/corba/common/idltypes/CorbaUtils.java @@ -23,6 +23,7 @@ import java.util.StringTokenizer; import java.util.TreeSet; +@SuppressWarnings("PMD.InstantiableUtilityClass") public class CorbaUtils { protected static final Set IDL_RESERVED_WORDS = new TreeSet<>(); @@ -174,5 +175,4 @@ public static boolean isTimeBaseDef(String name) { public static boolean ignoreModule(String name) { return IGNORED_MODULES.contains(name); } - } diff --git a/tools/javato/ws/src/main/java/org/apache/cxf/tools/java2wsdl/generator/WSDLGeneratorFactory.java b/tools/javato/ws/src/main/java/org/apache/cxf/tools/java2wsdl/generator/WSDLGeneratorFactory.java index 8e9b81f5f37..435c7723920 100644 --- a/tools/javato/ws/src/main/java/org/apache/cxf/tools/java2wsdl/generator/WSDLGeneratorFactory.java +++ b/tools/javato/ws/src/main/java/org/apache/cxf/tools/java2wsdl/generator/WSDLGeneratorFactory.java @@ -34,7 +34,7 @@ public void setWSDLVersion(WSDLConstants.WSDLVersion v) { this.wsdlVersion = v; } - protected String getGeneratorClassName() { + String getGeneratorClassName() { String pkgName = PackageUtils.getPackageName(getClass()); return pkgName + '.' + wsdlVersion.toString().toLowerCase() + '.' + wsdlVersion + "Generator"; } diff --git a/tools/javato/ws/src/main/java/org/apache/cxf/tools/java2wsdl/generator/wsdl11/DateTypeCustomGenerator.java b/tools/javato/ws/src/main/java/org/apache/cxf/tools/java2wsdl/generator/wsdl11/DateTypeCustomGenerator.java index 8fa4c5e4ddb..bae48006021 100644 --- a/tools/javato/ws/src/main/java/org/apache/cxf/tools/java2wsdl/generator/wsdl11/DateTypeCustomGenerator.java +++ b/tools/javato/ws/src/main/java/org/apache/cxf/tools/java2wsdl/generator/wsdl11/DateTypeCustomGenerator.java @@ -106,18 +106,18 @@ public File generate(File outputdir) { return xjb; } - protected File getJAXBCustFile(File outputdir) { + File getJAXBCustFile(File outputdir) { return new File(outputdir, wsdlName + ".xjb"); } - protected String getAdapterMethod(final Class clz, final String methodName) { + String getAdapterMethod(final Class clz, final String methodName) { if (clz == Date.class) { return DATE_ADAPTER + methodName; } return CALENDAR_ADAPTER + methodName; } - protected Class getDateType() { + Class getDateType() { if (getServiceModel() == null) { return null; } diff --git a/tools/javato/ws/src/main/java/org/apache/cxf/tools/java2wsdl/generator/wsdl11/FaultBeanGenerator.java b/tools/javato/ws/src/main/java/org/apache/cxf/tools/java2wsdl/generator/wsdl11/FaultBeanGenerator.java index 82d2ba566fa..d4f079e4f90 100644 --- a/tools/javato/ws/src/main/java/org/apache/cxf/tools/java2wsdl/generator/wsdl11/FaultBeanGenerator.java +++ b/tools/javato/ws/src/main/java/org/apache/cxf/tools/java2wsdl/generator/wsdl11/FaultBeanGenerator.java @@ -35,6 +35,7 @@ import org.apache.cxf.tools.common.model.JavaClass; import org.apache.cxf.tools.java2wsdl.processor.internal.jaxws.FaultBean; +@SuppressWarnings("PMD.ProtectedMemberInFinalClass") public final class FaultBeanGenerator extends BeanGenerator { private String getSEIPackage(final Method method) { @@ -66,7 +67,7 @@ protected Collection generateBeanClasses(final ServiceInfo serviceInf return faultBeanClasses; } - protected Set> getExceptionClasses(final Method method) { + Set> getExceptionClasses(final Method method) { Set> exps = new HashSet<>(); final Class[] exceptionClasses = method.getExceptionTypes(); for (int i = 0; i < exceptionClasses.length; i++) { diff --git a/tools/javato/ws/src/main/java/org/apache/cxf/tools/java2wsdl/generator/wsdl11/WrapperBeanGenerator.java b/tools/javato/ws/src/main/java/org/apache/cxf/tools/java2wsdl/generator/wsdl11/WrapperBeanGenerator.java index 2b3197e34a8..ca5a9bac327 100644 --- a/tools/javato/ws/src/main/java/org/apache/cxf/tools/java2wsdl/generator/wsdl11/WrapperBeanGenerator.java +++ b/tools/javato/ws/src/main/java/org/apache/cxf/tools/java2wsdl/generator/wsdl11/WrapperBeanGenerator.java @@ -29,6 +29,7 @@ import org.apache.cxf.tools.java2wsdl.processor.internal.jaxws.RequestWrapper; import org.apache.cxf.tools.java2wsdl.processor.internal.jaxws.ResponseWrapper; +@SuppressWarnings("PMD.ProtectedMemberInFinalClass") public final class WrapperBeanGenerator extends BeanGenerator { protected Collection generateBeanClasses(final ServiceInfo serviceInfo) { Collection wrapperClasses = new HashSet<>(); diff --git a/tools/javato/ws/src/main/java/org/apache/cxf/tools/java2wsdl/processor/internal/SpringServiceBuilderFactory.java b/tools/javato/ws/src/main/java/org/apache/cxf/tools/java2wsdl/processor/internal/SpringServiceBuilderFactory.java index ebb0db48f71..97f446b8c3e 100644 --- a/tools/javato/ws/src/main/java/org/apache/cxf/tools/java2wsdl/processor/internal/SpringServiceBuilderFactory.java +++ b/tools/javato/ws/src/main/java/org/apache/cxf/tools/java2wsdl/processor/internal/SpringServiceBuilderFactory.java @@ -103,7 +103,7 @@ public ServiceBuilder newBuilder(FrontendFactory.Style s) { * @param s Style of service * @return name of bean. */ - protected String getBuilderBeanName(FrontendFactory.Style s) { + String getBuilderBeanName(FrontendFactory.Style s) { return s + "ServiceBuilderBean"; } diff --git a/tools/javato/ws/src/main/java/org/apache/cxf/tools/java2wsdl/processor/internal/jaxws/ResponseWrapper.java b/tools/javato/ws/src/main/java/org/apache/cxf/tools/java2wsdl/processor/internal/jaxws/ResponseWrapper.java index c7f395e15f8..c3f3c372996 100644 --- a/tools/javato/ws/src/main/java/org/apache/cxf/tools/java2wsdl/processor/internal/jaxws/ResponseWrapper.java +++ b/tools/javato/ws/src/main/java/org/apache/cxf/tools/java2wsdl/processor/internal/jaxws/ResponseWrapper.java @@ -66,7 +66,7 @@ protected List buildFields() { return buildFields(getMethod(), getOperationInfo().getUnwrappedOperation().getOutput()); } - protected List buildFields(final Method method, final MessageInfo message) { + List buildFields(final Method method, final MessageInfo message) { List fields = new ArrayList<>(); final Class returnType = method.getReturnType(); diff --git a/tools/wsdlto/core/src/main/java/org/apache/cxf/tools/wsdlto/core/PluginLoader.java b/tools/wsdlto/core/src/main/java/org/apache/cxf/tools/wsdlto/core/PluginLoader.java index 1ef05078eda..79c2539fb50 100644 --- a/tools/wsdlto/core/src/main/java/org/apache/cxf/tools/wsdlto/core/PluginLoader.java +++ b/tools/wsdlto/core/src/main/java/org/apache/cxf/tools/wsdlto/core/PluginLoader.java @@ -143,7 +143,7 @@ public void loadPlugin(String resource) { } - protected void loadPlugin(Plugin plugin) { + void loadPlugin(Plugin plugin) { if (plugin.getFrontend().size() > 0) { LOG.log(Level.FINE, "FOUND_FRONTENDS", new Object[]{plugin.getName(), plugin.getFrontend().size()}); @@ -186,7 +186,7 @@ protected void loadPlugin(Plugin plugin) { } } - protected Plugin getPlugin(URL url) throws IOException, JAXBException, FileNotFoundException { + Plugin getPlugin(URL url) throws IOException, JAXBException, FileNotFoundException { Plugin plugin = plugins.get(url.toString()); if (plugin == null) { try (InputStream is = url.openStream()) { @@ -202,7 +202,7 @@ protected Plugin getPlugin(URL url) throws IOException, JAXBException, FileNotFo return plugin; } - protected Plugin getPlugin(String resource) throws JAXBException, IOException, FileNotFoundException { + Plugin getPlugin(String resource) throws JAXBException, IOException, FileNotFoundException { Plugin plugin = plugins.get(resource); if (plugin == null) { File resourceFile = new File(resource); diff --git a/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/customization/CustomizationParser.java b/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/customization/CustomizationParser.java index 4f8b29d6e85..3930b19d579 100644 --- a/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/customization/CustomizationParser.java +++ b/tools/wsdlto/frontend/jaxws/src/main/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/customization/CustomizationParser.java @@ -249,7 +249,7 @@ private void appendJaxbVersion(final Element schemaElement) { } } - protected void copyAllJaxbDeclarations(final Node schemaNode, final Element jaxwsBindingNode) { + void copyAllJaxbDeclarations(final Node schemaNode, final Element jaxwsBindingNode) { if (isSchemaElement(schemaNode)) { appendJaxbVersion((Element)schemaNode); } @@ -342,7 +342,7 @@ private void copyJaxbAttributes(Node childNode, Element schemaNode) { } - protected void internalizeBinding(Element bindings, Element targetNode, String expression) { + void internalizeBinding(Element bindings, Element targetNode, String expression) { if (isOldJAXWSBindings(bindings)) { LOG.warning(new Message("OLD_JAXWS_NAMESPACE", LOG).toString()); } @@ -615,7 +615,7 @@ private boolean isValidJaxwsBindingFile(String bindingLocation, XMLStreamReader } - protected void setWSDLNode(final Element node) { + void setWSDLNode(final Element node) { this.wsdlNode = node; } @@ -647,7 +647,7 @@ private boolean isJaxbBindingsElement(Node bindings) { return "bindings".equals(bindings.getLocalName()); } - protected boolean hasJaxbBindingDeclaration(Node bindings) { + boolean hasJaxbBindingDeclaration(Node bindings) { for (Node childNode = bindings.getFirstChild(); childNode != null; childNode = childNode.getNextSibling()) {