Skip to content

apisix-ingress-controller chart missing podLabels support #978

Description

@luarx

Chart version: apisix-ingress-controller v1.2.0

The deployment template renders pod labels exclusively via selectorLabels:

  template:
    metadata:
      labels:
        {{- include "apisix-ingress-controller-manager.selectorLabels" . | nindent 8 }}

There is no podLabels (or equivalent) value that gets merged into the pod template labels, making it impossible to add custom labels to pods for observability, scheduling, or policy purposes.

The apisix chart in the same repo supports this via service.labelsOverride. A straightforward fix for the ingress controller would be a deployment.podLabels value merged alongside
selectorLabels:

  labels:
    {{- include "apisix-ingress-controller-manager.selectorLabels" . | nindent 8 }}
    {{- with .Values.deployment.podLabels }}
    {{- toYaml . | nindent 8 }}
    {{- end }}

Note: deployment.podAnnotations is already supported. The missing piece is labels only.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions