Remove silent rejection handling

Author: tolyo

eslint.config.js

@@ -125,7 +125,6 @@ const angularTsRuntimeCompatibilityRules = {
   "promise/catch-or-return": ["error", { allowThen: true }],
   "promise/no-callback-in-promise": "error",
   "promise/no-nesting": "error",
-  "promise/no-promise-in-callback": "off",
   "promise/valid-params": "error",
 };
 

src/router/state/state-transition.ts

@@ -30,9 +30,9 @@ export function silenceUncaughtInPromise<T>(promise: Promise<T>): Promise<T> {
  *
  * @internal
  */
-export function silentRejection(error: unknown): Promise<never> {
+export function silentRejection(reason: unknown): Promise<never> {
   const promise = Promise.reject(
-    error instanceof Error ? error : Rejection.errored(error),
+    reason instanceof Error ? reason : Rejection.errored(reason),
   );
 
   return silenceUncaughtInPromise(promise);