Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

fix backspace event for android#142

Open
d42f wants to merge 1 commit into
angular-ui:masterfrom
d42f:master
Open

fix backspace event for android#142
d42f wants to merge 1 commit into
angular-ui:masterfrom
d42f:master

Conversation

@d42f

@d42f d42f commented Apr 5, 2016

Copy link
Copy Markdown

http://stackoverflow.com/questions/25043934/is-it-ok-to-ignore-keydown-events-with-keycode-229/25509350

Input has placeholder and mask +0 999 999 99 99. On android device (nexus 7 android 6) if press backspace then catch event with key code 229, not 8.

@lukepfeiffer10

Copy link
Copy Markdown
Contributor

I'm hesitant to accept this change because a quick Google search on the key code 229 does not necessarily indicate a backspace key press. It actually seems to just represent the browser being told the input buffer is busy and not finished accepting input which is most likely the case on the android keyboard especially if it has autocomplete or word suggestion enabled.

@d42f

d42f commented Apr 5, 2016

Copy link
Copy Markdown
Author

@lukepfeiffer10 ok, I'll try to make demo tomorrow

@mrsnowin

Copy link
Copy Markdown

Just made the same changes to mask.js, and wanted to make pull request because my nexus 3 generate code 229 when backspace. But here it is :)

@ivanovevgeny

ivanovevgeny commented Sep 22, 2016

Copy link
Copy Markdown

I can confirm this PR solves the issue #123

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants