Skip to content

Address ChannelRuntime callback review comments #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
eanzhao wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Address ChannelRuntime callback review comments #679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/adr/0011-lark-nyx-relay-webhook.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ The required order is:
2. Build and validate `channel-relay/reply`
3. Switch the Lark console callback URL to Nyx
4. Remove the direct Aevatar Lark callback path from the supported runtime contract
5. Historical transition note: the retired direct endpoint could temporarily return `410 Gone`; the current runtime deletes the direct endpoint entirely.
5. Return `410 Gone` for `POST /api/channels/lark/callback/{registrationId}` or delete that endpoint entirely

## Consequences

Expand Down
8 changes: 4 additions & 4 deletions test/Aevatar.GAgents.ChannelRuntime.Tests/ChannelCallbackEndpointsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ namespace Aevatar.GAgents.ChannelRuntime.Tests;
public sealed class ChannelCallbackEndpointsTests
{
[Fact]
public void MapChannelCallbackEndpoints_ShouldRequireAuthorization_ForDiagnosticErrors()
public async Task MapChannelCallbackEndpoints_ShouldRequireAuthorization_ForDiagnosticErrors()
{
var builder = WebApplication.CreateBuilder(new WebApplicationOptions
{
EnvironmentName = "Development",
});

var app = builder.Build();
await using var app = builder.Build();
var routeBuilder = (IEndpointRouteBuilder)app;
app.MapChannelCallbackEndpoints();

Expand All @@ -41,14 +41,14 @@ public void MapChannelCallbackEndpoints_ShouldRequireAuthorization_ForDiagnostic
}

[Fact]
public void MapChannelCallbackEndpoints_ShouldNotRegisterRetiredDirectPlatformCallback()
public async Task MapChannelCallbackEndpoints_ShouldNotRegisterRetiredDirectPlatformCallback()
{
var builder = WebApplication.CreateBuilder(new WebApplicationOptions
{
EnvironmentName = "Development",
});

var app = builder.Build();
await using var app = builder.Build();
var routeBuilder = (IEndpointRouteBuilder)app;
app.MapChannelCallbackEndpoints();

Expand Down
Loading