feat: expose AAO brand logo asset endpoints in RegistryClient

[bokelley]

Why

Interchange can now use @adcp/sdk RegistryClient for AAO brand resolve, enrich, and community registry save. The remaining hand-written AAO REST calls are only for brand logo assets because the SDK does not appear to expose first-class methods for those endpoints.

We currently need to call these directly:

• GET /api/brands/:domain/logos to list approved/pending brand logo assets, optionally filtered by tags.
• POST /api/brands/:domain/logos to upload a logo asset for AAO review.

Requested SDK surface

Add typed RegistryClient helpers, for example:

• listBrandLogos(domain: string, tags?: string[]): Promise<BrandLogoAsset[]>
• uploadBrandLogo(input: { domain: string; data: Blob | Buffer | ArrayBuffer; filename: string; mimeType: string; tags?: string[]; note?: string }): Promise<UploadBrandLogoResponse>

Notes

The response shape we are using today includes fields like id, content_type, source, review_status, tags, url, legacy_url, width, height, message, and review_sla_hours. Community uploads can return review_status=pending; callers must not treat pending URLs as brand.json-ready until listed as approved.

This would let downstream apps avoid bespoke AAO REST wrappers and keep all registry interactions on the SDK client.

[bokelley]

Triage

Classification: Feature request
Bucket(s): library
Status: ready-to-implement

What the experts said:

• code-reviewer: Additive and non-breaking; uploadBrandLogo needs an apiKey gate (like saveBrand); a new private postFormData multipart helper is required (existing post() is JSON-only); Buffer must be normalized to new Blob([data], { type: mimeType }) before formData.append() for cross-platform correctness; BrandLogoAsset/UploadBrandLogoResponse must be hand-rolled (absent from OpenAPI spec) with a @remarks flagging spec-drift risk; changeset required (minor).
• dx-expert: upload* verb breaks the repo-wide save* convention — consider saveBrandLogo; positional tags? should be options?: { tags?: string[] } for extensibility; return type should wrap as { assets: BrandLogoAsset[]; stats: Record<string, unknown> } to match listBrands; a discriminated union on review_status would make url non-optional only on the 'approved' branch, surfacing the pending-URL footgun at type level.

My take: Both experts agree this is non-breaking and clearly worth doing. Two API surface calls should be settled before opening a PR: (1) verb (uploadBrandLogo vs saveBrandLogo), (2) return shape for listBrandLogos (bare array vs { assets, stats } wrapper).

• Files: src/lib/registry/index.ts (two new public methods + private postFormData multipart helper), src/lib/registry/types.ts (hand-rolled BrandLogoAsset, UploadBrandLogoResponse with @remarks noting absence from generated types)
• URL: ${this.baseUrl}/api/brands/${encodeURIComponent(domain)}/logos — path param, not query string; tags as repeated &tags= params via appendParamValues
• Auth: uploadBrandLogo must gate on this.apiKey; confirm whether listBrandLogos requires auth and gate accordingly
• Tests: Happy path, empty array, missing-apiKey throws, Blob/Buffer/ArrayBuffer each accepted, tags serialized as repeated query keys
• Changeset: minor bump (new public surface)

---

Triaged by Claude Code. Session: https://claude.ai/code/session_015EymaDrgS3nZcr75Rz1KiB

---

Generated by Claude Code