Follow-up: align stale adcp.ts error_code hand type with generated ErrorSchema

[bokelley]

Argus follow-up from #2229.\n\nsrc/lib/types/adcp.ts still names a nested error field error_code, while generated ErrorSchema uses code. This is orthogonal to the conformance fix, but the stale hand type can mislead future reasoning about accepted error shapes.\n\nSuggested fix: audit the hand-authored type, align it with the generated schema naming, and add/update type coverage if this surface is still intended to be public.\n\nNon-blocking follow-up from merged PR #2229.

[bokelley]

Triage

Classification: Bug (type drift)
Bucket(s): library
Status: ready-for-human

What the experts said:

• code-reviewer: ManageCreativeAssetsResponse is publicly exported (src/lib/types/index.ts:15) — renaming error_code → code is a semver-major TypeScript API break; adopters reading .errors[].error_code already get undefined at runtime since the wire sends code. The SDK's own internals defensively coalesce error_code ?? code in validations.ts and canonical-format-satisfaction.ts, surfacing that this drift is known.
• ad-tech-protocol-expert: manage_creative_assets does not appear in the 3.x generated surface (tools.generated.ts, llms.txt) — this is a pre-3.x hand-authored artifact with no current spec backing, raising whether aligning it is better than deprecating the whole type surface.

My take: Both experts agree the diagnosis is correct (the wire field is code; the hand type says error_code) but the fix requires a breaking decision that belongs with @bokelley. Three paths: (1) non-breaking bridge — add code: string alongside /** @deprecated */ error_code?: string, remove in next major; (2) clean rename — major bump, replace inline struct with TaskErrorDetail from core.generated, changeset required; (3) deprecation candidate — since the tool has no 3.x spec entry, mark the entire ManageCreativeAssetsRequest/Response surface as @deprecated and plan removal. Any path requires a changeset before pushing.

---

Triaged by Claude Code. Session: https://claude.ai/code/cse_01Jmp5W6jQf1SCjEEUvHgxmE

---

Generated by Claude Code