From 30cb7a1639b67474791e72495e6dddcbf31d107e Mon Sep 17 00:00:00 2001 From: Jonas Alves Date: Mon, 4 May 2026 22:27:49 +0100 Subject: [PATCH] fix(ci): install libsecret-1-dev for keytar native build MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Previous publish on ea6889d failed at `bun install --frozen-lockfile`: keytar's node-gyp couldn't find libsecret-1 to compile against. Some ubuntu-latest runner images come with libsecret-1-dev pre-installed, others don't — installing it explicitly removes the flake. Added the install step to every job that runs `bun install` (lint, test matrix, build, live-test, publish). --- .github/workflows/_ci-checks.yml | 9 +++++++++ .github/workflows/main.yml | 3 +++ .github/workflows/publish.yml | 3 +++ 3 files changed, 15 insertions(+) diff --git a/.github/workflows/_ci-checks.yml b/.github/workflows/_ci-checks.yml index 998a5dd..991345f 100644 --- a/.github/workflows/_ci-checks.yml +++ b/.github/workflows/_ci-checks.yml @@ -22,6 +22,9 @@ jobs: with: node-version: '22' + - name: Install libsecret (keytar build dep) + run: sudo apt-get update && sudo apt-get install -y libsecret-1-dev + - run: bun install --frozen-lockfile - name: Prettier check @@ -45,6 +48,9 @@ jobs: with: node-version: ${{ matrix.node-version }} + - name: Install libsecret (keytar build dep) + run: sudo apt-get update && sudo apt-get install -y libsecret-1-dev + - run: bun install --frozen-lockfile - name: Run tests @@ -71,6 +77,9 @@ jobs: with: node-version: '22' + - name: Install libsecret (keytar build dep) + run: sudo apt-get update && sudo apt-get install -y libsecret-1-dev + - run: bun install --frozen-lockfile - run: bun tsc diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 6a9175e..4869a6a 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -25,6 +25,9 @@ jobs: with: node-version: '22' + - name: Install libsecret (keytar build dep) + run: sudo apt-get update && sudo apt-get install -y libsecret-1-dev + - run: bun install --frozen-lockfile - name: Run live API tests diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 8a0ff0e..c16e288 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -59,6 +59,9 @@ jobs: with: node-version: '22' + - name: Install libsecret (keytar build dep) + run: sudo apt-get update && sudo apt-get install -y libsecret-1-dev + - run: bun install --frozen-lockfile - run: bun tsc