remove redundant "else" / "else if"

Author: ivandrofly

Algorithms/Graphs/BellmanFordShortestPaths.cs

@@ -37,7 +37,7 @@ public BellmanFordShortestPaths(TGraph Graph, TVertex Source)
         {
             if (Graph == null)
                 throw new ArgumentNullException();
-            else if (!Graph.HasVertex(Source))
+            if (!Graph.HasVertex(Source))
                 throw new ArgumentException("The source vertex doesn't belong to graph.");
 
             // Init
@@ -252,7 +252,7 @@ public IEnumerable<TVertex> ShortestPathTo(TVertex destination)
         {
             if (!_nodesToIndices.ContainsKey(destination))
                 throw new Exception("Graph doesn't have the specified vertex.");
-            else if (!HasPathTo(destination))
+            if (!HasPathTo(destination))
                 return null;
 
             int dstIndex = _nodesToIndices[destination];

Algorithms/Graphs/BipartiteColoring.cs

@@ -57,7 +57,7 @@ public BipartiteColoring(IGraph<TVertex> Graph)
             // Validate Graph parameter
             if (Graph == null)
                 throw new ArgumentNullException();
-            else if (Graph.VerticesCount < 2)
+            if (Graph.VerticesCount < 2)
                 throw new InvalidOperationException("Graph contains less elements than required.");
 
             // Init data members
@@ -177,7 +177,7 @@ public BipartiteColor ColorOf(TVertex vertex)
         {
             if (!_isBipartite)
                 throw new InvalidOperationException("Graph is not bipartite.");
-            else if (!_nodesToIndices.ContainsKey(vertex))
+            if (!_nodesToIndices.ContainsKey(vertex))
                 throw new InvalidOperationException("Vertex doesn't belong to graph.");
 
             return _nodesColors[_nodesToIndices[vertex]];

Algorithms/Graphs/BreadthFirstShortestPaths.cs

@@ -38,7 +38,7 @@ public BreadthFirstShortestPaths(IGraph<T> Graph, T Source)
         {
             if (Graph == null)
                 throw new ArgumentNullException();
-            else if (!Graph.HasVertex(Source))
+            if (!Graph.HasVertex(Source))
                 throw new ArgumentException("The source vertex doesn't belong to graph.");
 
             // Init
@@ -60,7 +60,7 @@ public BreadthFirstShortestPaths(IGraph<T> Graph, IList<T> Sources)
         {
             if (Graph == null)
                 throw new ArgumentNullException();
-            else if (Sources == null || Sources.Count == 0)
+            if (Sources == null || Sources.Count == 0)
                 throw new ArgumentException("Sources list is either null or empty.");
 
             // Init
@@ -281,7 +281,7 @@ public IEnumerable<T> ShortestPathTo(T destination)
         {
             if (!_nodesToIndices.ContainsKey(destination))
                 throw new Exception("Graph doesn't have the specified vertex.");
-            else if (!HasPathTo(destination))
+            if (!HasPathTo(destination))
                 return null;
 
             int dstIndex = _nodesToIndices[destination];

Algorithms/Graphs/ConnectedComponents.cs

@@ -56,9 +56,9 @@ public static List<List<TVertex>> Compute<TVertex>(IGraph<TVertex> Graph) where
             // Validate the graph parameter
             if (Graph == null)
                 throw new ArgumentNullException();
-            else if (Graph.IsDirected == true)
+            if (Graph.IsDirected == true)
                 throw new NotSupportedException("Directed Graphs are not supported.");
-            else if(Graph.VerticesCount == 0)
+            if(Graph.VerticesCount == 0)
                 return components;
 
             // Get connected components using BFS

Algorithms/Graphs/CyclesDetector.cs

@@ -38,7 +38,7 @@ private static bool _isUndirectedCyclic<T>(IGraph<T> graph, T source, object par
                         return true;
 
                     // If an adjacent is visited and NOT parent of current vertex, then there is a cycle.
-                    else if (parent != (object)null && !adjacent.IsEqualTo((T)parent))
+                    if (parent != (object)null && !adjacent.IsEqualTo((T)parent))
                         return true;
                 }
             }
@@ -72,7 +72,7 @@ private static bool _isDirectedCyclic<T>(IGraph<T> graph, T source, ref HashSet<
                         return true;
 
                     // If an adjacent is visited and is on the recursion stack then there is a cycle.
-                    else if (recursionStack.Contains(adjacent))
+                    if (recursionStack.Contains(adjacent))
                         return true;
                 }
             }

Algorithms/Graphs/DijkstraShortestPaths.cs

@@ -282,7 +282,8 @@ public IEnumerable<TVertex> ShortestPathTo(TVertex destination)
             {
                 throw new Exception("Graph doesn't have the specified vertex.");
             }
-            else if (!HasPathTo(destination))
+
+            if (!HasPathTo(destination))
             {
                 return null;
             }

Algorithms/Graphs/TopologicalSorter.cs

@@ -34,7 +34,7 @@ public static IEnumerable<T> Sort<T>(IGraph<T> Graph) where T : IComparable<T>
             // If the graph is either null or is not a DAG, throw exception.
             if (Graph == null)
                 throw new ArgumentNullException();
-            else if (!Graph.IsDirected || CyclesDetector.IsCyclic<T>(Graph))
+            if (!Graph.IsDirected || CyclesDetector.IsCyclic<T>(Graph))
                 throw new Exception("The graph is not a DAG.");
 
             var visited = new HashSet<T>();

Algorithms/Numeric/GreatestCommonDivisor.cs

@@ -15,7 +15,7 @@ public static uint FindGCD(uint a, uint b)
         {
             if (a == 0)
                 return b;
-            else if (b == 0)
+            if (b == 0)
                 return a;
 
             uint _a = a, _b = b;

Algorithms/Sorting/LSDRadixSorter.cs

@@ -69,12 +69,9 @@ public static void LSDRadixSort(this IList<String> collection, int stringFixedWi
             // Validate input
             if (collection == null || collection.Count <= 1)
                 return;
-            else
-            {
-                for (int i = 0; i < collection.Count; ++i)
-                    if (collection[i] == null || collection[i].Length != stringFixedWidth)
-                        throw new InvalidOperationException("Not all strings have the same width");
-            }
+            for (int i = 0; i < collection.Count; ++i)
+                if (collection[i] == null || collection[i].Length != stringFixedWidth)
+                    throw new InvalidOperationException("Not all strings have the same width");
 
             // extend ASCII alphabet size
             int asciiSize = 256;

Algorithms/Sorting/MergeSorter.cs

@@ -24,7 +24,8 @@ private static List<T> InternalMergeSort<T>(List<T> collection, int startIndex,
             {
                 return collection;
             }
-            else if (collection.Count == 2)
+
+            if (collection.Count == 2)
             {
                 if (comparer.Compare(collection[endIndex], collection[startIndex]) < 0)
                 {
@@ -33,18 +34,16 @@ private static List<T> InternalMergeSort<T>(List<T> collection, int startIndex,
 
                 return collection;
             }
-            else
-            {
-                int midIndex = collection.Count / 2;
 
-                var leftCollection = collection.GetRange(startIndex, midIndex);
-                var rightCollection = collection.GetRange(midIndex, (endIndex - midIndex) + 1);
+            int midIndex = collection.Count / 2;
 
-                leftCollection = InternalMergeSort<T>(leftCollection, 0, leftCollection.Count - 1, comparer);
-                rightCollection = InternalMergeSort<T>(rightCollection, 0, rightCollection.Count - 1, comparer);
+            var leftCollection = collection.GetRange(startIndex, midIndex);
+            var rightCollection = collection.GetRange(midIndex, (endIndex - midIndex) + 1);
 
-                return InternalMerge<T>(leftCollection, rightCollection, comparer);
-            }
+            leftCollection = InternalMergeSort<T>(leftCollection, 0, leftCollection.Count - 1, comparer);
+            rightCollection = InternalMergeSort<T>(rightCollection, 0, rightCollection.Count - 1, comparer);
+
+            return InternalMerge<T>(leftCollection, rightCollection, comparer);
         }