fix suggestions

Author: guglielmo-san

src/a2a/server/routes/agent_card_routes.py

@@ -63,24 +63,21 @@ def __init__(
                 'The `starlette` package is required to use `AgentCardRoutes`. '
                 'It can be installed as part of `a2a-sdk` optional dependencies, `a2a-sdk[http-server]`.'
             )
-            )
 
         self.agent_card = agent_card
         self.card_modifier = card_modifier
 
-        async def get_agent_card(request: Request) -> Response:
-            card_to_serve = self.agent_card
-            if self.card_modifier:
-                card_to_serve = await maybe_await(
-                    self.card_modifier(card_to_serve)
-                )
-            return JSONResponse(agent_card_to_dict(card_to_serve))
-
         self.routes = [
             Route(
                 path=card_url,
-                endpoint=get_agent_card,
+                endpoint=self._get_agent_card,
                 methods=['GET'],
                 middleware=middleware,
             )
         ]
+
+    async def _get_agent_card(self, request: Request) -> Response:
+        card_to_serve = self.agent_card
+        if self.card_modifier:
+            card_to_serve = await maybe_await(self.card_modifier(card_to_serve))
+        return JSONResponse(agent_card_to_dict(card_to_serve))

src/a2a/server/routes/jsonrpc_dispatcher.py

@@ -47,9 +47,6 @@
     SubscribeToTaskRequest,
     TaskPushNotificationConfig,
 )
-from a2a.utils.constants import (
-    DEFAULT_MAX_CONTENT_LENGTH,
-)
 from a2a.utils.errors import (
     A2AError,
     UnsupportedOperationError,
@@ -202,7 +199,6 @@ def __init__(  # noqa: PLR0913
         ]
         | None = None,
         enable_v0_3_compat: bool = False,
-        max_content_length: int | None = DEFAULT_MAX_CONTENT_LENGTH,
     ) -> None:
         """Initializes the JsonRpcDispatcher.
 
@@ -220,8 +216,6 @@ def __init__(  # noqa: PLR0913
             extended_card_modifier: An optional callback to dynamically modify
               the extended agent card before it is served. It receives the
               call context.
-            max_content_length: The maximum allowed content length for incoming
-              requests. Defaults to 10MB. Set to None for unbounded maximum.
             enable_v0_3_compat: Whether to enable v0.3 backward compatibility on the same endpoint.
         """
         if not _package_starlette_installed:
@@ -242,7 +236,6 @@ def __init__(  # noqa: PLR0913
             extended_card_modifier=extended_card_modifier,
         )
         self._context_builder = context_builder or DefaultCallContextBuilder()
-        self._max_content_length = max_content_length
         self.enable_v0_3_compat = enable_v0_3_compat
         self._v03_adapter: JSONRPC03Adapter | None = None
 
@@ -298,22 +291,6 @@ def _generate_error_response(
             status_code=200,
         )
 
-    def _allowed_content_length(self, request: Request) -> bool:
-        """Checks if the request content length is within the allowed maximum.
-
-        Args:
-            request: The incoming Starlette Request object.
-
-        Returns:
-            False if the content length is larger than the allowed maximum, True otherwise.
-        """
-        if self._max_content_length is not None:
-            with contextlib.suppress(ValueError):
-                content_length = int(request.headers.get('content-length', '0'))
-                if content_length and content_length > self._max_content_length:
-                    return False
-        return True
-
     async def _handle_requests(self, request: Request) -> Response:  # noqa: PLR0911, PLR0912
         """Handles incoming POST requests to the main A2A endpoint.
 
@@ -344,12 +321,6 @@ async def _handle_requests(self, request: Request) -> Response:  # noqa: PLR0911
                     request_id, str | int
                 ):
                     request_id = None
-            # Treat payloads lager than allowed as invalid request (-32600) before routing
-            if not self._allowed_content_length(request):
-                return self._generate_error_response(
-                    request_id,
-                    InvalidRequestError(message='Payload too large'),
-                )
             logger.debug('Request body: %s', body)
             # 1) Validate base JSON-RPC structure only (-32600 on failure)
             try:

src/a2a/utils/constants.py

@@ -20,7 +20,6 @@ class TransportProtocol(str, Enum):
     GRPC = 'GRPC'
 
 
-DEFAULT_MAX_CONTENT_LENGTH = 10 * 1024 * 1024  # 10MB
 JSONRPC_PARSE_ERROR_CODE = -32700
 VERSION_HEADER = 'A2A-Version'
 

tests/server/routes/test_agent_card_routes.py

@@ -6,6 +6,7 @@
 import pytest
 from starlette.testclient import TestClient
 from starlette.middleware import Middleware
+from starlette.applications import Starlette
 
 from a2a.server.routes.agent_card_routes import AgentCardRoutes
 from a2a.types.a2a_pb2 import AgentCard
@@ -20,8 +21,6 @@ def test_get_agent_card_success(agent_card):
     """Tests that the agent card route returns the card correctly."""
     routes = AgentCardRoutes(agent_card=agent_card).routes
 
-    from starlette.applications import Starlette
-
     app = Starlette(routes=routes)
     client = TestClient(app)
 
@@ -52,8 +51,6 @@ async def modifier(card: AgentCard) -> AgentCard:
         agent_card=agent_card, card_modifier=mock_modifier
     ).routes
 
-    from starlette.applications import Starlette
-
     app = Starlette(routes=routes)
     client = TestClient(app)
 
@@ -67,8 +64,6 @@ def test_agent_card_custom_url(agent_card):
     custom_url = '/custom/path/agent.json'
     routes = AgentCardRoutes(agent_card=agent_card, card_url=custom_url).routes
 
-    from starlette.applications import Starlette
-
     app = Starlette(routes=routes)
     client = TestClient(app)
 
@@ -95,8 +90,6 @@ async def __call__(self, scope, receive, send):
         agent_card=agent_card, middleware=[Middleware(MyMiddleware)]
     ).routes
 
-    from starlette.applications import Starlette
-
     app = Starlette(routes=routes)
     client = TestClient(app)
 

tests/server/routes/test_jsonrpc_routes.py

@@ -5,6 +5,7 @@
 import pytest
 from starlette.testclient import TestClient
 from starlette.middleware import Middleware
+from starlette.applications import Starlette
 
 from a2a.server.routes.jsonrpc_routes import JsonRpcRoutes
 from a2a.server.request_handlers.request_handler import RequestHandler
@@ -44,8 +45,6 @@ def test_jsonrpc_custom_url(agent_card, mock_handler):
         agent_card=agent_card, request_handler=mock_handler, rpc_url=custom_url
     )
 
-    from starlette.applications import Starlette
-
     app = Starlette(routes=jsonrpc_routes.routes)
     client = TestClient(app)
 
@@ -83,8 +82,6 @@ async def __call__(self, scope, receive, send):
         rpc_url='/',
     )
 
-    from starlette.applications import Starlette
-
     app = Starlette(routes=jsonrpc_routes.routes)
     client = TestClient(app)