Skip to content

Commit a4f7d91

Browse files
committed
fix: merging errors
1 parent 6ff94da commit a4f7d91

3 files changed

Lines changed: 14 additions & 15 deletions

File tree

src/a2a/client/transports/base.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
from collections.abc import AsyncGenerator, Callable
33
from types import TracebackType
44

5-
from typing_extensions import Self
65
from google.protobuf.message import Message
6+
from typing_extensions import Self
77

88
from a2a.client.middleware import ClientCallContext
99
from a2a.types.a2a_pb2 import (
@@ -179,7 +179,7 @@ def update_tenant(self, request: Message) -> str | None:
179179
return current_tenant
180180

181181
if self._tenant and hasattr(request, 'tenant'):
182-
request.tenant = self._tenant
182+
setattr(request, 'tenant', self._tenant)
183183
return self._tenant
184184
return None
185185

@@ -249,7 +249,7 @@ async def cancel_task(
249249
request, context=context, extensions=extensions
250250
)
251251

252-
async def set_task_callback(
252+
async def create_task_push_notification_config(
253253
self,
254254
request: CreateTaskPushNotificationConfigRequest,
255255
*,
@@ -258,11 +258,11 @@ async def set_task_callback(
258258
) -> TaskPushNotificationConfig:
259259
"""Sets or updates the push notification configuration for a specific task."""
260260
self.update_tenant(request)
261-
return await self._base.set_task_callback(
261+
return await self._base.create_task_push_notification_config(
262262
request, context=context, extensions=extensions
263263
)
264264

265-
async def get_task_callback(
265+
async def get_task_push_notification_config(
266266
self,
267267
request: GetTaskPushNotificationConfigRequest,
268268
*,
@@ -271,11 +271,11 @@ async def get_task_callback(
271271
) -> TaskPushNotificationConfig:
272272
"""Retrieves the push notification configuration for a specific task."""
273273
self.update_tenant(request)
274-
return await self._base.get_task_callback(
274+
return await self._base.get_task_push_notification_config(
275275
request, context=context, extensions=extensions
276276
)
277277

278-
async def list_task_callback(
278+
async def list_task_push_notification_configs(
279279
self,
280280
request: ListTaskPushNotificationConfigsRequest,
281281
*,
@@ -284,11 +284,11 @@ async def list_task_callback(
284284
) -> ListTaskPushNotificationConfigsResponse:
285285
"""Lists push notification configurations for a specific task."""
286286
self.update_tenant(request)
287-
return await self._base.list_task_callback(
287+
return await self._base.list_task_push_notification_configs(
288288
request, context=context, extensions=extensions
289289
)
290290

291-
async def delete_task_callback(
291+
async def delete_task_push_notification_config(
292292
self,
293293
request: DeleteTaskPushNotificationConfigRequest,
294294
*,
@@ -297,7 +297,7 @@ async def delete_task_callback(
297297
) -> None:
298298
"""Deletes the push notification configuration for a specific task."""
299299
self.update_tenant(request)
300-
await self._base.delete_task_callback(
300+
await self._base.delete_task_push_notification_config(
301301
request, context=context, extensions=extensions
302302
)
303303

src/a2a/client/transports/rest.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import httpx
88

99
from google.protobuf.json_format import MessageToDict, Parse, ParseDict
10-
from google.protobuf.message import Message
1110
from httpx_sse import SSEError, aconnect_sse
1211

1312
from a2a.client.errors import (

tests/client/transports/test_rest_client.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -401,28 +401,28 @@ class TestRestTransportTenant:
401401
'/my-tenant/v1/tasks/task-123:cancel',
402402
),
403403
(
404-
'set_task_callback',
404+
'create_task_push_notification_config',
405405
CreateTaskPushNotificationConfigRequest(
406406
tenant='my-tenant', task_id='task-123'
407407
),
408408
'/my-tenant/v1/tasks/task-123/pushNotificationConfigs',
409409
),
410410
(
411-
'get_task_callback',
411+
'get_task_push_notification_config',
412412
GetTaskPushNotificationConfigRequest(
413413
tenant='my-tenant', task_id='task-123', id='cfg-1'
414414
),
415415
'/my-tenant/v1/tasks/task-123/pushNotificationConfigs/cfg-1',
416416
),
417417
(
418-
'list_task_callback',
418+
'list_task_push_notification_configs',
419419
ListTaskPushNotificationConfigsRequest(
420420
tenant='my-tenant', task_id='task-123'
421421
),
422422
'/my-tenant/v1/tasks/task-123/pushNotificationConfigs',
423423
),
424424
(
425-
'delete_task_callback',
425+
'delete_task_push_notification_config',
426426
DeleteTaskPushNotificationConfigRequest(
427427
tenant='my-tenant', task_id='task-123', id='cfg-1'
428428
),

0 commit comments

Comments
 (0)