remove warning import. Few improvements

Author: sokoliva

src/a2a/server/tasks/base_push_notification_sender.py

@@ -1,6 +1,5 @@
 import asyncio
 import logging
-import warnings
 
 import httpx
 
@@ -40,20 +39,18 @@ def __init__(
               backward compatibility with 1.0 callers that constructed
               the sender with a (typically dummy) ServerCallContext.
               Pass None (the default) in new code. A non-None
-              value triggers a DeprecationWarning and is otherwise
+              value logs a deprecation warning and is otherwise
               ignored.
         """
         if context is not None:
-            warnings.warn(
+            logger.warning(
                 'BasePushNotificationSender no longer uses the context '
                 'parameter; it is accepted only for backward compatibility '
                 'with 1.0 and will be removed in a future major version. '
                 'Push notifications now fan out across all owners via '
                 'PushNotificationConfigStore.get_info_for_dispatch; the '
                 'caller identity is not carried into dispatch. Drop the '
-                'context argument from the constructor call.',
-                DeprecationWarning,
-                stacklevel=2,
+                'context argument from the constructor call.'
             )
         self._client = httpx_client
         self._config_store = config_store

src/a2a/server/tasks/database_push_notification_config_store.py

@@ -7,7 +7,7 @@
 
 
 try:
-    from sqlalchemy import Table, and_, delete, select
+    from sqlalchemy import ColumnElement, Table, and_, delete, select
     from sqlalchemy.ext.asyncio import (
         AsyncEngine,
         AsyncSession,
@@ -304,24 +304,14 @@ async def set_info(
                 owner,
             )
 
-    async def get_info(
+    async def _select_configs(
         self,
-        task_id: str,
-        context: ServerCallContext,
+        *predicates: 'ColumnElement[bool]',
     ) -> list[TaskPushNotificationConfig]:
-        """Retrieves all push notification configurations for a task, for the given owner.
-
-        Used by the user-callable read endpoints.
-        """
+        """Loads configs matching the given predicates and decodes them."""
         await self._ensure_initialized()
-        owner = self.owner_resolver(context)
         async with self.async_session_maker() as session:
-            stmt = select(self.config_model).where(
-                and_(
-                    self.config_model.task_id == task_id,
-                    self.config_model.owner == owner,
-                )
-            )
+            stmt = select(self.config_model).where(and_(*predicates))
             result = await session.execute(stmt)
             models = result.scalars().all()
 
@@ -334,10 +324,25 @@ async def get_info(
                         'Could not deserialize push notification config for task %s, config %s, owner %s',
                         model.task_id,
                         model.config_id,
-                        owner,
+                        model.owner,
                     )
             return configs
 
+    async def get_info(
+        self,
+        task_id: str,
+        context: ServerCallContext,
+    ) -> list[TaskPushNotificationConfig]:
+        """Retrieves all push notification configurations for a task, for the given owner.
+
+        Used by the user-callable read endpoints.
+        """
+        owner = self.owner_resolver(context)
+        return await self._select_configs(
+            self.config_model.task_id == task_id,
+            self.config_model.owner == owner,
+        )
+
     async def get_info_for_dispatch(
         self,
         task_id: str,
@@ -346,26 +351,9 @@ async def get_info_for_dispatch(
 
         Used by the push-notification dispatch path.
         """
-        await self._ensure_initialized()
-        async with self.async_session_maker() as session:
-            stmt = select(self.config_model).where(
-                self.config_model.task_id == task_id
-            )
-            result = await session.execute(stmt)
-            models = result.scalars().all()
-
-            configs = []
-            for model in models:
-                try:
-                    configs.append(self._from_orm(model))
-                except ValueError:  # noqa: PERF203
-                    logger.exception(
-                        'Could not deserialize push notification config for task %s, config %s, owner %s',
-                        model.task_id,
-                        model.config_id,
-                        model.owner,
-                    )
-            return configs
+        return await self._select_configs(
+            self.config_model.task_id == task_id,
+        )
 
     async def delete_info(
         self,

src/a2a/server/tasks/push_notification_config_store.py

@@ -1,5 +1,4 @@
 import logging
-import warnings
 
 from abc import ABC, abstractmethod
 
@@ -54,19 +53,18 @@ async def get_info_for_dispatch(
         but is INCORRECT for any deployment with multiple owners: the
         empty context resolves to the empty-string owner partition and
         returns no configs (silently dropping every notification). A
-        DeprecationWarning is emitted on every call to flag the
-        misconfiguration. Custom subclasses MUST override this method
-        to deliver notifications correctly in multi-owner deployments.
+        warning is logged on every call to flag the misconfiguration.
+        Custom subclasses MUST override this method to deliver
+        notifications correctly in multi-owner deployments.
         """
-        warnings.warn(
-            f'{type(self).__name__} does not override '
+        logger.warning(
+            '%s does not override '
             'PushNotificationConfigStore.get_info_for_dispatch; falling back '
             'to a context-less get_info call which silently drops '
             'notifications in any deployment with multiple owners. Override '
             'get_info_for_dispatch to return all configs for task_id across '
             'every owner.',
-            DeprecationWarning,
-            stacklevel=2,
+            type(self).__name__,
         )
         return await self.get_info(task_id, ServerCallContext())
 

tests/server/tasks/test_inmemory_push_notifications.py

@@ -543,11 +543,10 @@ async def test_cross_user_dispatch_alice_registers_bob_triggers(
     ) -> None:
         """Alice registers; Bob triggers; Alice's webhook receives the POST.
 
-        This is the §2 worked example. ``send_notification`` carries no
-        identity, so there is no notion of "who triggered this event"
-        at the store layer. ``get_info_for_dispatch`` returns Alice's
-        config because Alice registered it. The fact that the event
-        was caused by Bob is not visible to (and not relevant for) the
+        The send_notification carries no identity, so there is no notion of
+        "who triggered this event" at the store layer. get_info_for_dispatch
+        returns Alice's config because Alice registered it. The fact that the
+        event was caused by Bob is not visible to (and not relevant for) the
         dispatch path.
         """
         alice_context = ServerCallContext(user=SampleUser(user_name='alice'))