Skip to content

Commit 8e5ab33

Browse files
committed
fix: replace non-inclusive language in optionals.py
Signed-off-by: Luca Muscariello <muscariello@ieee.org>
1 parent 7433e04 commit 8e5ab33

6 files changed

Lines changed: 9 additions & 9 deletions

File tree

src/a2a/client/optionals.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@
55
try:
66
from grpc.aio import Channel # pyright: ignore[reportAssignmentType]
77
except ImportError:
8-
# If grpc.aio is not available, define a dummy type for type checking.
9-
# This dummy type will only be used by type checkers.
8+
# If grpc.aio is not available, define a stub type for type checking.
9+
# This stub type will only be used by type checkers.
1010
if TYPE_CHECKING:
1111

1212
class Channel: # type: ignore[no-redef]
13-
"""Dummy class for type hinting when grpc.aio is not available."""
13+
"""Stub class for type hinting when grpc.aio is not available."""
1414

1515
else:
1616
Channel = None # At runtime, pd will be None if the import failed.

tests/client/test_auth_middleware.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -351,7 +351,7 @@ async def test_auth_interceptor_skips_when_scheme_not_in_security_schemes(
351351
"""Tests that AuthInterceptor skips a scheme if it's listed in security requirements but not defined in security_schemes."""
352352
scheme_name = 'missing'
353353
session_id = 'session-id'
354-
credential = 'dummy-token'
354+
credential = 'test-token'
355355
request_payload = {'foo': 'bar'}
356356
http_kwargs = {'fizz': 'buzz'}
357357
await store.set_credentials(session_id, scheme_name, credential)

tests/server/agent_execution/test_simple_request_context_builder.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ async def test_build_basic_context_no_populate(self) -> None:
9292
)
9393
# Pass a valid User instance, e.g., UnauthenticatedUser or a mock spec'd as User
9494
server_call_context = ServerCallContext(
95-
user=UnauthenticatedUser(), auth_token='dummy_token'
95+
user=UnauthenticatedUser(), auth_token='test_token'
9696
)
9797

9898
request_context = await builder.build(

tests/server/events/test_event_queue.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ async def test_close_sets_flag_and_handles_internal_queue_new_python(
297297
) -> None:
298298
"""Test close behavior on Python >= 3.13 (using queue.shutdown)."""
299299
with patch('sys.version_info', (3, 13, 0)):
300-
# Inject a dummy shutdown method for non-3.13 runtimes
300+
# Inject a stub shutdown method for non-3.13 runtimes
301301
from typing import cast
302302

303303
queue = cast('Any', event_queue.queue)

tests/server/request_handlers/test_default_request_handler.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1828,10 +1828,10 @@ async def test_cleanup_producer_task_id_not_in_running_agents():
18281828
task_id = 'task_already_cleaned'
18291829

18301830
# Create a real, completed asyncio.Task for the test
1831-
async def dummy_coro_for_task():
1831+
async def noop_coro_for_task():
18321832
pass
18331833

1834-
mock_producer_task = asyncio.create_task(dummy_coro_for_task())
1834+
mock_producer_task = asyncio.create_task(noop_coro_for_task())
18351835
await asyncio.sleep(
18361836
0
18371837
) # Ensure the task has a chance to complete/be scheduled

tests/utils/test_signing.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ def test_signer_and_verifier_symmetric_multiple_signatures(
147147

148148
def test_signer_and_verifier_asymmetric(sample_agent_card: AgentCard):
149149
"""Test the agent card signing and verification process with an asymmetric key encryption."""
150-
# Generate a dummy EC private key for ES256
150+
# Generate a sample EC private key for ES256
151151
private_key = asymmetric.ec.generate_private_key(asymmetric.ec.SECP256R1())
152152
public_key = private_key.public_key()
153153
# Generate another key pair for negative test

0 commit comments

Comments
 (0)