wip

Author: guglielmo-san

src/a2a/helpers/__init__.py

@@ -9,7 +9,7 @@
     new_artifact,
     new_message,
     new_task,
-    new_task_from_request,
+    new_task_from_user_message,
     new_text_artifact,
     new_text_artifact_update_event,
     new_text_message,
@@ -25,7 +25,7 @@
     'new_artifact',
     'new_message',
     'new_task',
-    'new_task_from_request',
+    'new_task_from_user_message',
     'new_text_artifact',
     'new_text_artifact_update_event',
     'new_text_message',

src/a2a/helpers/types.py

@@ -97,21 +97,19 @@ def get_artifact_text(artifact: Artifact, delimiter: str = '\n') -> str:
 # --- Task Helpers ---
 
 
-def new_task_from_request(request: Message) -> Task:
+def new_task_from_user_message(user_message: Message) -> Task:
     """Creates a new Task object from an initial user message."""
-    if not request.role:
-        raise TypeError('Message role cannot be None')
-    if not request.parts:
+    if not user_message.parts:
         raise ValueError('Message parts cannot be empty')
-    for part in request.parts:
+    for part in user_message.parts:
         if part.HasField('text') and not part.text:
             raise ValueError('Message.text cannot be empty')
 
     return Task(
         status=TaskStatus(state=TaskState.TASK_STATE_SUBMITTED),
-        id=request.task_id or str(uuid.uuid4()),
-        context_id=request.context_id or str(uuid.uuid4()),
-        history=[request],
+        id=user_message.task_id or str(uuid.uuid4()),
+        context_id=user_message.context_id or str(uuid.uuid4()),
+        history=[user_message],
     )
 
 
@@ -123,13 +121,12 @@ def new_task(
     history: list[Message] | None = None,
 ) -> Task:
     """Creates a Task object with a specified status."""
-    if not artifacts or not all(isinstance(a, Artifact) for a in artifacts):
-        raise ValueError(
-            'artifacts must be a non-empty list of Artifact objects'
-        )
 
     if history is None:
         history = []
+    if artifacts is None:
+        artifacts = []
+
     return Task(
         status=TaskStatus(state=state),
         id=task_id,

tests/e2e/push_notifications/agent_app.py

@@ -26,7 +26,7 @@
 )
 from a2a.helpers.types import (
     new_text_message,
-    new_task_from_request,
+    new_task_from_user_message,
 )
 
 
@@ -124,7 +124,7 @@ async def execute(
 
         task = context.current_task
         if not task:
-            task = new_task_from_request(context.message)
+            task = new_task_from_user_message(context.message)
             await event_queue.enqueue_event(task)
         updater = TaskUpdater(event_queue, task.id, task.context_id)
 

tests/integration/test_end_to_end.py

@@ -38,7 +38,7 @@
     a2a_pb2_grpc,
 )
 from a2a.utils import TransportProtocol
-from a2a.helpers.types import new_task_from_request
+from a2a.helpers.types import new_task_from_user_message
 from a2a.utils.errors import InvalidParamsError
 
 
@@ -102,7 +102,7 @@ async def execute(self, context: RequestContext, event_queue: EventQueue):
         # Task-based response.
         task = context.current_task
         if not task:
-            task = new_task_from_request(context.message)
+            task = new_task_from_user_message(context.message)
             await event_queue.enqueue_event(task)
 
         task_updater = TaskUpdater(

tests/server/request_handlers/test_default_request_handler.py

@@ -73,7 +73,7 @@
     TaskStatus,
     TaskStatusUpdateEvent,
 )
-from a2a.helpers.types import new_text_message, new_task_from_request
+from a2a.helpers.types import new_text_message, new_task_from_user_message
 
 
 class MockAgentExecutor(AgentExecutor):
@@ -957,7 +957,7 @@ async def execute(self, context: RequestContext, event_queue: EventQueue):
             assert context.message is not None, (
                 'A message is required to create a new task'
             )
-            task = new_task_from_request(context.message)  # type: ignore
+            task = new_task_from_user_message(context.message)  # type: ignore
             await event_queue.enqueue_event(task)
         updater = TaskUpdater(event_queue, task.id, task.context_id)
 

tests/server/request_handlers/test_default_request_handler_v2.py

@@ -54,7 +54,7 @@
     TaskState,
     TaskStatus,
 )
-from a2a.helpers.types import new_text_message, new_task_from_request
+from a2a.helpers.types import new_text_message, new_task_from_user_message
 
 
 def create_default_agent_card():
@@ -274,7 +274,7 @@ async def execute(self, context: RequestContext, event_queue: EventQueue):
             assert context.message is not None, (
                 'A message is required to create a new task'
             )
-            task = new_task_from_request(context.message)
+            task = new_task_from_user_message(context.message)
             await event_queue.enqueue_event(task)
         updater = TaskUpdater(event_queue, task.id, task.context_id)
         try: