Skip to content

Commit 6640dcd

Browse files
committed
ci: install all extras in linter workflow to fix type checking
Remove local type ignores for optional dependencies Signed-off-by: Luca Muscariello <muscariello@ieee.org>
1 parent 1647415 commit 6640dcd

6 files changed

Lines changed: 22 additions & 18 deletions

File tree

.github/workflows/linter.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
- name: Install Buf
2626
uses: bufbuild/buf-setup-action@v1
2727
- name: Install dependencies
28-
run: uv sync --dev
28+
run: uv sync --dev --all-extras
2929

3030
- name: Run Ruff Linter
3131
id: ruff-lint

src/a2a/client/transports/grpc.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55

66
try:
7-
import grpc # type: ignore[reportMissingModuleSource, reportMissingImports]
7+
import grpc # type: ignore[reportMissingModuleSource]
88
except ImportError as e:
99
raise ImportError(
1010
'A2AGrpcClient requires grpcio and grpcio-tools to be installed. '

src/a2a/server/models.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,20 +18,20 @@ def override(func): # noqa: ANN001, ANN201
1818

1919

2020
try:
21-
from sqlalchemy import ( # type: ignore[reportMissingImports]
21+
from sqlalchemy import (
2222
JSON,
2323
Dialect,
2424
LargeBinary,
2525
String,
2626
)
27-
from sqlalchemy.orm import ( # type: ignore[reportMissingImports]
27+
from sqlalchemy.orm import (
2828
DeclarativeBase,
2929
Mapped,
3030
declared_attr,
3131
mapped_column,
3232
)
3333
from sqlalchemy.types import (
34-
TypeDecorator, # type: ignore[reportMissingImports]
34+
TypeDecorator,
3535
)
3636
except ImportError as e:
3737
raise ImportError(

src/a2a/server/tasks/database_push_notification_config_store.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,18 @@
88

99

1010
try:
11-
from sqlalchemy import ( # type: ignore[reportMissingImports]
11+
from sqlalchemy import (
1212
Table,
1313
delete,
1414
select,
1515
)
16-
from sqlalchemy.ext.asyncio import ( # type: ignore[reportMissingImports]
16+
from sqlalchemy.ext.asyncio import (
1717
AsyncEngine,
1818
AsyncSession,
1919
async_sessionmaker,
2020
)
2121
from sqlalchemy.orm import (
22-
class_mapper, # type: ignore[reportMissingImports]
22+
class_mapper,
2323
)
2424
except ImportError as e:
2525
raise ImportError(
@@ -43,7 +43,7 @@
4343

4444

4545
if TYPE_CHECKING:
46-
from cryptography.fernet import Fernet # type: ignore[reportMissingImports]
46+
from cryptography.fernet import Fernet
4747

4848

4949
logger = logging.getLogger(__name__)
@@ -98,7 +98,9 @@ def __init__(
9898

9999
if encryption_key:
100100
try:
101-
from cryptography.fernet import Fernet
101+
from cryptography.fernet import (
102+
Fernet,
103+
)
102104
except ImportError as e:
103105
raise ImportError(
104106
"DatabasePushNotificationConfigStore with encryption requires the 'cryptography' "
@@ -170,7 +172,9 @@ def _from_orm(
170172
payload = model_instance.config_data
171173

172174
if self._fernet:
173-
from cryptography.fernet import InvalidToken
175+
from cryptography.fernet import (
176+
InvalidToken,
177+
)
174178

175179
try:
176180
decrypted_payload = self._fernet.decrypt(payload)

src/a2a/server/tasks/database_task_store.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,18 @@
44

55

66
try:
7-
from sqlalchemy import ( # type: ignore[reportMissingImports]
7+
from sqlalchemy import (
88
Table,
99
delete,
1010
select,
1111
)
12-
from sqlalchemy.ext.asyncio import ( # type: ignore[reportMissingImports]
12+
from sqlalchemy.ext.asyncio import (
1313
AsyncEngine,
1414
AsyncSession,
1515
async_sessionmaker,
1616
)
1717
from sqlalchemy.orm import (
18-
class_mapper, # type: ignore[reportMissingImports]
18+
class_mapper,
1919
)
2020
except ImportError as e:
2121
raise ImportError(

src/a2a/utils/telemetry.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,19 +66,19 @@ def internal_method(self):
6666

6767
if TYPE_CHECKING:
6868
from opentelemetry.trace import (
69-
SpanKind as SpanKindType, # type: ignore[reportMissingImports]
69+
SpanKind as SpanKindType,
7070
)
7171
else:
7272
SpanKindType = object
7373

7474
logger = logging.getLogger(__name__)
7575

7676
try:
77-
from opentelemetry import trace # type: ignore[reportMissingImports]
78-
from opentelemetry.trace import ( # type: ignore[reportMissingImports]
77+
from opentelemetry import trace
78+
from opentelemetry.trace import (
7979
SpanKind as _SpanKind,
8080
)
81-
from opentelemetry.trace import ( # type: ignore[reportMissingImports]
81+
from opentelemetry.trace import (
8282
StatusCode,
8383
)
8484

0 commit comments

Comments
 (0)