Revert not wanted

Author: ishymko

tests/client/test_base_client.py

@@ -1,4 +1,3 @@
-from typing import cast
 from unittest.mock import AsyncMock, MagicMock, patch
 
 import pytest
@@ -72,11 +71,11 @@ async def test_transport_async_context_manager() -> None:
         patch.object(ClientTransport, '__abstractmethods__', set()),
         patch.object(ClientTransport, 'close', new_callable=AsyncMock),
     ):
-        transport = ClientTransport()  # type: ignore[abstract]
+        transport = ClientTransport()
         async with transport as t:
             assert t is transport
-            cast(AsyncMock, transport.close).assert_not_awaited()
-        cast(AsyncMock, transport.close).assert_awaited_once()
+            transport.close.assert_not_awaited()
+        transport.close.assert_awaited_once()
 
 
 @pytest.mark.asyncio
@@ -85,11 +84,11 @@ async def test_transport_async_context_manager_on_exception() -> None:
         patch.object(ClientTransport, '__abstractmethods__', set()),
         patch.object(ClientTransport, 'close', new_callable=AsyncMock),
     ):
-        transport = ClientTransport()  # type: ignore[abstract]
+        transport = ClientTransport()
         with pytest.raises(RuntimeError, match='boom'):
             async with transport:
                 raise RuntimeError('boom')
-        cast(AsyncMock, transport.close).assert_awaited_once()
+        transport.close.assert_awaited_once()
 
 
 @pytest.mark.asyncio

tests/integration/test_client_server_integration.py

@@ -1129,7 +1129,7 @@ async def test_json_transport_get_signed_extended_card(
     private_key = ec.generate_private_key(ec.SECP256R1())
     public_key = private_key.public_key()
     signer = create_agent_card_signer(
-        signing_key=private_key,  # type: ignore[arg-type]
+        signing_key=private_key,
         protected_header={
             'alg': 'ES256',
             'kid': 'testkey',
@@ -1194,7 +1194,7 @@ async def test_json_transport_get_signed_base_and_extended_cards(
     private_key = ec.generate_private_key(ec.SECP256R1())
     public_key = private_key.public_key()
     signer = create_agent_card_signer(
-        signing_key=private_key,  # type: ignore[arg-type]
+        signing_key=private_key,
         protected_header={
             'alg': 'ES256',
             'kid': 'testkey',
@@ -1271,7 +1271,7 @@ async def test_rest_transport_get_signed_card(
     private_key = ec.generate_private_key(ec.SECP256R1())
     public_key = private_key.public_key()
     signer = create_agent_card_signer(
-        signing_key=private_key,  # type: ignore[arg-type]
+        signing_key=private_key,
         protected_header={
             'alg': 'ES256',
             'kid': 'testkey',
@@ -1340,7 +1340,7 @@ async def test_grpc_transport_get_signed_card(
     private_key = ec.generate_private_key(ec.SECP256R1())
     public_key = private_key.public_key()
     signer = create_agent_card_signer(
-        signing_key=private_key,  # type: ignore[arg-type]
+        signing_key=private_key,
         protected_header={
             'alg': 'ES256',
             'kid': 'testkey',

tests/integration/test_end_to_end.py

@@ -1,5 +1,5 @@
 from collections.abc import AsyncGenerator
-from typing import NamedTuple, cast
+from typing import NamedTuple
 
 import grpc
 import httpx
@@ -74,8 +74,6 @@ def assert_events_match(events, expected_events):
 
 class MockAgentExecutor(AgentExecutor):
     async def execute(self, context: RequestContext, event_queue: EventQueue):
-        assert context.task_id is not None
-        assert context.context_id is not None
         task_updater = TaskUpdater(
             event_queue,
             context.task_id,
@@ -183,7 +181,7 @@ def rest_setup(agent_card, base_e2e_setup) -> ClientSetup:
             supported_protocol_bindings=[TransportProtocol.HTTP_JSON],
         )
     )
-    client = cast(BaseClient, factory.create(agent_card))
+    client = factory.create(agent_card)
     return ClientSetup(
         client=client,
         task_store=task_store,
@@ -206,7 +204,7 @@ def jsonrpc_setup(agent_card, base_e2e_setup) -> ClientSetup:
             supported_protocol_bindings=[TransportProtocol.JSONRPC],
         )
     )
-    client = cast(BaseClient, factory.create(agent_card))
+    client = factory.create(agent_card)
     return ClientSetup(
         client=client,
         task_store=task_store,
@@ -243,7 +241,7 @@ async def grpc_setup(
             supported_protocol_bindings=[TransportProtocol.GRPC],
         )
     )
-    client = cast(BaseClient, factory.create(grpc_agent_card))
+    client = factory.create(grpc_agent_card)
     yield ClientSetup(
         client=client,
         task_store=task_store,

tests/server/apps/jsonrpc/test_jsonrpc_app.py

@@ -141,7 +141,7 @@ def test_create_jsonrpc_based_app_with_present_deps_succeeds(
         class MockJSONRPCApp(JSONRPCApplication):
             def build(  # type: ignore[override]
                 self,
-                agent_card_url='/custom.json',
+                agent_card_url='/.well-known/agent.json',
                 rpc_url='/',
                 **kwargs,
             ):
@@ -162,7 +162,7 @@ def test_create_jsonrpc_based_app_with_missing_deps_raises_importerror(
         class MockJSONRPCApp(JSONRPCApplication):
             def build(  # type: ignore[override]
                 self,
-                agent_card_url='/custom.json',
+                agent_card_url='/.well-known/agent.json',
                 rpc_url='/',
                 **kwargs,
             ):

tests/utils/test_signing.py

@@ -59,7 +59,7 @@ def test_signer_and_verifier_symmetric(sample_agent_card: AgentCard):
     wrong_key = 'wrongkey'
 
     agent_card_signer = signing.create_agent_card_signer(
-        signing_key=key,  # type: ignore[arg-type]
+        signing_key=key,
         protected_header={
             'alg': 'HS384',
             'kid': 'key1',
@@ -109,7 +109,7 @@ def test_signer_and_verifier_symmetric_multiple_signatures(
     wrong_key = 'wrongkey'
 
     agent_card_signer = signing.create_agent_card_signer(
-        signing_key=key,  # type: ignore[arg-type]
+        signing_key=key,
         protected_header={
             'alg': 'HS384',
             'kid': 'key1',
@@ -148,7 +148,7 @@ def test_signer_and_verifier_asymmetric(sample_agent_card: AgentCard):
     public_key_error = private_key_error.public_key()
 
     agent_card_signer = signing.create_agent_card_signer(
-        signing_key=private_key,  # type: ignore[arg-type]
+        signing_key=private_key,
         protected_header={
             'alg': 'ES256',
             'kid': 'key2',