Subscribe post fix v2.

Author: bartek-w

src/a2a/client/transports/rest.py

@@ -262,7 +262,6 @@ async def subscribe(
             f'/tasks/{request.id}:subscribe',
             request.tenant,
             context=context,
-            json=MessageToDict(request),
         ):
             yield event
 

src/a2a/server/request_handlers/rest_handler.py

@@ -159,15 +159,9 @@ async def on_subscribe_to_task(
         Yields:
             JSON serialized objects containing streaming events
         """
-        params = SubscribeToTaskRequest()
-        if request.method == 'POST':
-            body = await request.body()
-            if body:
-                Parse(body, params)
-
-        params.id = request.path_params['id']
+        task_id = request.path_params['id']
         async for event in self.request_handler.on_subscribe_to_task(
-            params, context
+            SubscribeToTaskRequest(id=task_id), context
         ):
             yield MessageToDict(proto_utils.to_stream_response(event))
 

tests/client/transports/test_rest_client.py

@@ -732,7 +732,10 @@ async def empty_aiter():
         args, kwargs = mock_aconnect_sse.call_args
         # method is 2nd positional argument
         assert args[1] == 'POST'
-        assert kwargs.get('json') == json_format.MessageToDict(request_obj)
+        if method_name == 'subscribe':
+            assert kwargs.get('json') is None
+        else:
+            assert kwargs.get('json') == json_format.MessageToDict(request_obj)
 
         # url is 3rd positional argument in aconnect_sse(client, method, url, ...)
         assert args[2] == f'http://agent.example.com/api{expected_path}'

tests/compat/v0_3/test_rest_transport.py

@@ -337,6 +337,7 @@ async def test_compat_rest_transport_subscribe_post_405_get_405_fails(
 
     method_count = {}
 
+    method_count = {}
     async def mock_stream(method, path, context=None, json=None):
         method_count[method] = method_count.get(method, 0) + 1
         if method == 'POST':

tests/server/apps/rest/test_rest_fastapi_app.py

@@ -438,7 +438,7 @@ async def mock_stream_response():
 async def test_subscribe_to_task_post(
     streaming_client: AsyncClient, request_handler: MagicMock
 ) -> None:
-    """Test that POST /tasks/{id}:subscribe works and parses body."""
+    """Test that POST /tasks/{id}:subscribe works."""
 
     async def mock_stream_response():
         yield Task(
@@ -449,11 +449,8 @@ async def mock_stream_response():
 
     request_handler.on_subscribe_to_task.return_value = mock_stream_response()
 
-    request = a2a_pb2.SubscribeToTaskRequest(id='task-1')
-
     response = await streaming_client.post(
         '/tasks/task-1:subscribe',
-        json=json_format.MessageToDict(request),
         headers={'Accept': 'text/event-stream'},
     )
 
@@ -595,7 +592,7 @@ def extended_card_modifier(self) -> MagicMock:
             ('/message:send', 'POST', 'on_message_send', {'message': {}}),
             ('/tasks/1:cancel', 'POST', 'on_cancel_task', None),
             ('/tasks/1:subscribe', 'GET', 'on_subscribe_to_task', None),
-            ('/tasks/1:subscribe', 'POST', 'on_subscribe_to_task', {'id': '1'}),
+            ('/tasks/1:subscribe', 'POST', 'on_subscribe_to_task', None),
             ('/tasks/1', 'GET', 'on_get_task', None),
             ('/tasks', 'GET', 'on_list_tasks', None),
             (