Skip to content

Commit 38d1102

Browse files
committed
Cosmetics
1 parent 7ced3be commit 38d1102

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

src/a2a/client/client_factory.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,9 @@ class ClientFactory:
7575

7676
def __init__(
7777
self,
78-
config: ClientConfig,
78+
config: ClientConfig | None = None,
7979
):
80+
config = config or ClientConfig()
8081
httpx_client = config.httpx_client or httpx.AsyncClient()
8182
httpx_client.headers.setdefault(
8283
VERSION_HEADER, PROTOCOL_VERSION_CURRENT
@@ -393,7 +394,7 @@ async def create_client( # noqa: PLR0913
393394
Returns:
394395
A `Client` object.
395396
"""
396-
factory = ClientFactory(client_config or ClientConfig())
397+
factory = ClientFactory(client_config)
397398
if isinstance(agent, str):
398399
return await factory.create_from_url(
399400
agent,

tests/client/test_client_factory.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ def test_client_factory_create_with_default_config(
129129
base_agent_card: AgentCard,
130130
):
131131
"""Verify that create works correctly with a default ClientConfig."""
132-
factory = ClientFactory(ClientConfig())
132+
factory = ClientFactory()
133133
client = factory.create(base_agent_card)
134134
assert isinstance(client._transport, JsonRpcTransport) # type: ignore[attr-defined]
135135
assert client._transport.url == 'http://primary-url.com' # type: ignore[attr-defined]
@@ -144,7 +144,7 @@ async def test_client_factory_create_from_url(base_agent_card: AgentCard):
144144
)
145145

146146
agent_url = 'http://example.com'
147-
factory = ClientFactory(ClientConfig())
147+
factory = ClientFactory()
148148
client = await factory.create_from_url(agent_url)
149149

150150
mock_resolver.assert_called_once()
@@ -223,7 +223,7 @@ async def test_client_factory_create_from_url_with_default_config(
223223
relative_path = '/extendedAgentCard'
224224
http_kwargs = {'headers': {'X-Test': 'true'}}
225225

226-
factory = ClientFactory(ClientConfig())
226+
factory = ClientFactory()
227227

228228
await factory.create_from_url(
229229
agent_url,
@@ -311,7 +311,7 @@ def test_client_factory_create_with_interceptors(
311311
interceptor1 = MagicMock()
312312

313313
with patch('a2a.client.client_factory.BaseClient') as mock_base_client:
314-
factory = ClientFactory(ClientConfig())
314+
factory = ClientFactory()
315315
factory.create(
316316
base_agent_card,
317317
interceptors=[interceptor1],

0 commit comments

Comments
 (0)