Skip to content

Commit 36e818a

Browse files
committed
refactor: remove query parameter conversion utilities from REST transport and simplify gRPC timeout retrieval.
1 parent 17302b2 commit 36e818a

2 files changed

Lines changed: 1 addition & 22 deletions

File tree

src/a2a/client/transports/grpc.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -303,9 +303,7 @@ def _get_grpc_metadata(
303303
def _get_grpc_timeout(
304304
self, context: ClientCallContext | None
305305
) -> float | None:
306-
if context:
307-
return context.timeout
308-
return None
306+
return context.timeout if context else None
309307

310308
async def _call_grpc(
311309
self,

src/a2a/client/transports/rest.py

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import httpx
88

99
from google.protobuf.json_format import MessageToDict, Parse, ParseDict
10-
from google.protobuf.message import Message
1110

1211
from a2a.client.errors import A2AClientError
1312
from a2a.client.middleware import ClientCallContext, ClientCallInterceptor
@@ -369,21 +368,3 @@ async def _execute_request( # noqa: PLR0913
369368
**http_kwargs,
370369
)
371370
return await self._send_request(request)
372-
373-
374-
def _model_to_query_params(instance: Message) -> dict[str, str]:
375-
data = MessageToDict(instance, preserving_proto_field_name=True)
376-
return _json_to_query_params(data)
377-
378-
379-
def _json_to_query_params(data: dict[str, Any]) -> dict[str, str]:
380-
query_dict = {}
381-
for key, value in data.items():
382-
if isinstance(value, list):
383-
query_dict[key] = ','.join(map(str, value))
384-
elif isinstance(value, bool):
385-
query_dict[key] = str(value).lower()
386-
else:
387-
query_dict[key] = str(value)
388-
389-
return query_dict

0 commit comments

Comments
 (0)