Skip to content

Commit 30fe2d3

Browse files
author
Rajesh Ramamoorthy
committed
feat: Fixed build issues related to linting and formatting
1 parent 52b2d01 commit 30fe2d3

7 files changed

Lines changed: 25 additions & 26 deletions

File tree

src/a2a/server/events/queue_lifecycle_manager.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ async def provision(self) -> QueueProvisionResult:
156156
self.region_name,
157157
)
158158

159-
async with self._resolved_session.client(
159+
async with self._resolved_session.client( # pyright: ignore[reportGeneralTypeIssues]
160160
'sqs', region_name=self.region_name
161161
) as sqs:
162162
# Step 1: Create the SQS queue.
@@ -202,7 +202,7 @@ async def provision(self) -> QueueProvisionResult:
202202
# Step 4: Subscribe the SQS queue to the SNS topic.
203203
subscription_arn = ''
204204
try:
205-
async with self._resolved_session.client(
205+
async with self._resolved_session.client( # pyright: ignore[reportGeneralTypeIssues]
206206
'sns', region_name=self.region_name
207207
) as sns:
208208
sub_resp = await sns.subscribe(
@@ -220,7 +220,7 @@ async def provision(self) -> QueueProvisionResult:
220220
queue_url,
221221
)
222222
try:
223-
async with self._resolved_session.client(
223+
async with self._resolved_session.client( # pyright: ignore[reportGeneralTypeIssues]
224224
'sqs', region_name=self.region_name
225225
) as sqs:
226226
await sqs.delete_queue(QueueUrl=queue_url)
@@ -261,7 +261,7 @@ async def teardown(self) -> None:
261261

262262
# Step 1: Unsubscribe from SNS (best-effort).
263263
try:
264-
async with self._resolved_session.client(
264+
async with self._resolved_session.client( # pyright: ignore[reportGeneralTypeIssues]
265265
'sns', region_name=self.region_name
266266
) as sns:
267267
await sns.unsubscribe(SubscriptionArn=result.subscription_arn)
@@ -276,7 +276,7 @@ async def teardown(self) -> None:
276276

277277
# Step 2: Delete the SQS queue.
278278
try:
279-
async with self._resolved_session.client(
279+
async with self._resolved_session.client( # pyright: ignore[reportGeneralTypeIssues]
280280
'sqs', region_name=self.region_name
281281
) as sqs:
282282
await sqs.delete_queue(QueueUrl=result.queue_url)

src/a2a/server/events/sns_queue_manager.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ async def _sns_publish(self, message: str) -> None:
245245
Args:
246246
message: JSON string in the distributed wire format.
247247
"""
248-
async with self._session.client(
248+
async with self._session.client( # pyright: ignore[reportGeneralTypeIssues]
249249
'sns', region_name=self._region_name
250250
) as sns:
251251
await sns.publish(TopicArn=self._topic_arn, Message=message)
@@ -268,7 +268,7 @@ async def _poll_loop(self) -> None:
268268
self._instance_id,
269269
self._sqs_queue_url,
270270
)
271-
async with self._session.client(
271+
async with self._session.client( # pyright: ignore[reportGeneralTypeIssues]
272272
'sqs', region_name=self._region_name
273273
) as sqs:
274274
while not self._stop_event.is_set():

src/a2a/server/tasks/dynamodb_task_store.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ async def save(
8484
'Saving task %s to DynamoDB table %s.', task.id, self._table_name
8585
)
8686
task_data = task.model_dump_json()
87-
async with self._session.client(
87+
async with self._session.client( # pyright: ignore[reportGeneralTypeIssues]
8888
'dynamodb', region_name=self._region_name
8989
) as client:
9090
await client.put_item(
@@ -113,7 +113,7 @@ async def get(
113113
task_id,
114114
self._table_name,
115115
)
116-
async with self._session.client(
116+
async with self._session.client( # pyright: ignore[reportGeneralTypeIssues]
117117
'dynamodb', region_name=self._region_name
118118
) as client:
119119
response = await client.get_item(
@@ -147,7 +147,7 @@ async def delete(
147147
task_id,
148148
self._table_name,
149149
)
150-
async with self._session.client(
150+
async with self._session.client( # pyright: ignore[reportGeneralTypeIssues]
151151
'dynamodb', region_name=self._region_name
152152
) as client:
153153
await client.delete_item(

tests/server/events/test_queue_lifecycle_manager.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,7 @@ def _make_sns_client() -> AsyncMock:
3636
return client
3737

3838

39-
def _make_session(
40-
sqs_client: AsyncMock, sns_client: AsyncMock
41-
) -> MagicMock:
39+
def _make_session(sqs_client: AsyncMock, sns_client: AsyncMock) -> MagicMock:
4240
session = MagicMock()
4341

4442
def make_ctx(inner_client: AsyncMock) -> MagicMock:

tests/server/events/test_sns_queue_manager.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -292,13 +292,15 @@ async def test_poll_unwraps_sns_notification_envelope(
292292
) -> None:
293293
"""SNS notification envelope (non-raw delivery) is properly unwrapped."""
294294
task_data = json.loads(TASK_OBJ.model_dump_json())
295-
inner = json.dumps({
296-
'instance_id': 'instance-B',
297-
'task_id': 'task-001',
298-
'type': 'event',
299-
'event_kind': 'task',
300-
'event_data': task_data,
301-
})
295+
inner = json.dumps(
296+
{
297+
'instance_id': 'instance-B',
298+
'task_id': 'task-001',
299+
'type': 'event',
300+
'event_kind': 'task',
301+
'event_data': task_data,
302+
}
303+
)
302304
sns_envelope = {
303305
'Type': 'Notification',
304306
'MessageId': 'notif-001',
@@ -310,9 +312,7 @@ async def test_poll_unwraps_sns_notification_envelope(
310312
'ReceiptHandle': 'rh-002',
311313
'Body': json.dumps(sns_envelope),
312314
}
313-
sqs_client.receive_message = AsyncMock(
314-
return_value={'Messages': [sqs_msg]}
315-
)
315+
sqs_client.receive_message = AsyncMock(return_value={'Messages': [sqs_msg]})
316316

317317
dist_queue = DistributedEventQueue(
318318
publish_fn=AsyncMock(), task_id='task-001', instance_id='instance-A'

tests/server/integration/test_distributed_stack.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,7 @@ def factory(service: str, **kwargs):
9090
return _make(sqs_client_a), _make(sqs_client_b)
9191

9292

93-
def _wire_event(
94-
instance_id: str, task_id: str, event: Task
95-
) -> dict[str, Any]:
93+
def _wire_event(instance_id: str, task_id: str, event: Task) -> dict[str, Any]:
9694
task_data = json.loads(event.model_dump_json())
9795
return {
9896
'instance_id': instance_id,

tests/server/tasks/test_dynamodb_task_store.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ def mock_session(dynamodb_client: AsyncMock) -> MagicMock:
4848
def store(mock_session: MagicMock):
4949
with patch.dict('sys.modules', {'aioboto3': MagicMock()}):
5050
from a2a.server.tasks.dynamodb_task_store import DynamoDBTaskStore
51+
5152
s = DynamoDBTaskStore('test-table', session=mock_session)
5253
return s
5354

@@ -145,6 +146,7 @@ async def fake_get_item(**kwargs):
145146

146147
with patch.dict('sys.modules', {'aioboto3': MagicMock()}):
147148
from a2a.server.tasks.dynamodb_task_store import DynamoDBTaskStore
149+
148150
s = DynamoDBTaskStore('test-table', session=session)
149151

150152
await s.save(task)
@@ -162,6 +164,7 @@ def test_import_error_without_aioboto3() -> None:
162164
sys.modules['aioboto3'] = None # type: ignore[assignment]
163165
from importlib import reload
164166
import a2a.server.tasks.dynamodb_task_store as mod
167+
165168
reload(mod)
166169
with pytest.raises(ImportError, match='aws extra'):
167170
mod.DynamoDBTaskStore('test-table')

0 commit comments

Comments
 (0)