Skip to content

Commit 1876aef

Browse files
committed
Gemini fixes
1 parent d16a1f8 commit 1876aef

4 files changed

Lines changed: 4 additions & 14 deletions

File tree

tests/client/transports/test_grpc_client.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -568,9 +568,7 @@ async def test_delete_task_callback(
568568
sample_task_push_notification_config: TaskPushNotificationConfig,
569569
) -> None:
570570
"""Test deleting task push notification config."""
571-
mock_grpc_stub.DeleteTaskPushNotificationConfig.return_value = (
572-
sample_task_push_notification_config
573-
)
571+
mock_grpc_stub.DeleteTaskPushNotificationConfig.return_value = None
574572

575573
await grpc_transport.delete_task_callback(
576574
DeleteTaskPushNotificationConfigRequest(

tests/client/transports/test_jsonrpc_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ async def test_delete_task_callback_success(
416416
)
417417
response = await transport.delete_task_callback(request)
418418

419-
mock_httpx_client.post.assert_called_once() # Assuming mock_send_request was a typo for mock_httpx_client.post
419+
mock_httpx_client.post.assert_called_once()
420420
assert response is None
421421
call_args = mock_httpx_client.post.call_args
422422
payload = call_args[1]['json']

tests/client/transports/test_rest_client.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -340,13 +340,7 @@ async def test_delete_task_callback_success(
340340
task_id = 'task-1'
341341
mock_response = AsyncMock(spec=httpx.Response)
342342
mock_response.status_code = 200
343-
mock_response.json.return_value = {
344-
'taskId': task_id,
345-
'pushNotificationConfig': {
346-
'id': 'config-1',
347-
'url': 'https://example.com',
348-
},
349-
}
343+
mock_response.json.return_value = {}
350344
mock_httpx_client.send.return_value = mock_response
351345

352346
# Mock the build_request method to capture its inputs

tests/integration/test_client_server_integration.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -137,9 +137,7 @@ async def stream_side_effect(*args, **kwargs):
137137
handler.on_list_task_push_notification_configs.return_value = (
138138
ListTaskPushNotificationConfigsResponse(configs=[CALLBACK_CONFIG])
139139
)
140-
handler.on_delete_task_push_notification_config.return_value = (
141-
CALLBACK_CONFIG
142-
)
140+
handler.on_delete_task_push_notification_config.return_value = None
143141

144142
async def resubscribe_side_effect(*args, **kwargs):
145143
yield RESUBSCRIBE_EVENT

0 commit comments

Comments
 (0)