Merge branch '1.0-dev' into guglielmoc/refactor_server_call_context

Author: guglielmo-san

.github/workflows/coverage-comment.yaml

@@ -18,22 +18,22 @@ jobs:
       github.event.workflow_run.conclusion == 'success'
     steps:
       - name: Download Coverage Artifacts
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v8
         with:
           run-id: ${{ github.event.workflow_run.id }}
           github-token: ${{ secrets.A2A_BOT_PAT }}
           name: coverage-data
 
       - name: Upload Coverage Report
         id: upload-report
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v7
         with:
           name: coverage-report
           path: coverage/
           retention-days: 14
 
       - name: Post Comment
-        uses: actions/github-script@v6
+        uses: actions/github-script@v8
         env:
           ARTIFACT_URL: ${{ steps.upload-report.outputs.artifact-url }}
         with:

.github/workflows/spelling.yaml

@@ -1,8 +1,8 @@
 ---
 name: Check Spelling
 on:
-  pull_request_target:
-    branches: ["**"]
+  pull_request:
+    branches: ['**']
     types: [opened, reopened, synchronize]
   issue_comment:
     types: [created]
@@ -11,7 +11,6 @@ jobs:
     name: Check Spelling
     permissions:
       contents: read
-      pull-requests: read
       actions: read
       security-events: write
     outputs:
@@ -28,7 +27,7 @@ jobs:
     steps:
       - name: check-spelling
         id: spelling
-        uses: check-spelling/check-spelling@main
+        uses: check-spelling/check-spelling@a35147f799f30f8739c33f92222c847214e82e67 # https://github.com/check-spelling/check-spelling/issues/103#issuecomment-4181666219
         with:
           suppress_push_for_open_pull_request: ${{ github.actor != 'dependabot[bot]' && 1 }}
           checkout: true
@@ -75,6 +74,6 @@ jobs:
             cspell:sql/src/tsql.txt
             cspell:terraform/dict/terraform.txt
             cspell:typescript/dict/typescript.txt
-          check_extra_dictionaries: ""
+          check_extra_dictionaries: ''
           only_check_changed_files: true
-          longest_word: "10"
+          longest_word: '10'

.github/workflows/unit-tests.yml

@@ -59,7 +59,7 @@ jobs:
       # Coverage comparison for PRs (only on Python 3.14 to avoid duplicate work)
       - name: Checkout Base Branch
         if: github.event_name == 'pull_request' && matrix.python-version == '3.14'
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
         with:
           ref: ${{ github.event.pull_request.base.ref || 'main' }}
           clean: true
@@ -75,7 +75,7 @@ jobs:
 
       - name: Checkout PR Branch (Restore)
         if: github.event_name == 'pull_request' && matrix.python-version == '3.14'
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
         with:
           clean: true
 
@@ -93,7 +93,7 @@ jobs:
           echo ${{ github.event.pull_request.base.ref || 'main' }} > ./BASE_BRANCH
 
       - name: Upload Coverage Artifacts
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v7
         if: github.event_name == 'pull_request' && matrix.python-version == '3.14'
         with:
           name: coverage-data
@@ -111,7 +111,7 @@ jobs:
         run: uv run pytest --cov=a2a --cov-report term --cov-fail-under=88
 
       - name: Upload Artifact (base)
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v7
         if: github.event_name != 'pull_request' && matrix.python-version == '3.14'
         with:
           name: coverage-report

src/a2a/compat/v0_3/jsonrpc_adapter.py

@@ -62,7 +62,7 @@ class JSONRPC03Adapter:
         'tasks/pushNotificationConfig/list': types_v03.ListTaskPushNotificationConfigRequest,
         'tasks/pushNotificationConfig/delete': types_v03.DeleteTaskPushNotificationConfigRequest,
         'tasks/resubscribe': types_v03.TaskResubscriptionRequest,
-        'agent/authenticatedExtendedCard': types_v03.GetAuthenticatedExtendedCardRequest,
+        'agent/getAuthenticatedExtendedCard': types_v03.GetAuthenticatedExtendedCardRequest,
     }
 
     def __init__(  # noqa: PLR0913
@@ -224,7 +224,7 @@ async def _process_non_streaming_request(
                     id=request_id, result=None
                 )
             )
-        elif method == 'agent/authenticatedExtendedCard':
+        elif method == 'agent/getAuthenticatedExtendedCard':
             res_card = await self.get_authenticated_extended_card(
                 request_obj, context
             )
@@ -247,7 +247,7 @@ async def get_authenticated_extended_card(
         request: types_v03.GetAuthenticatedExtendedCardRequest,
         context: ServerCallContext,
     ) -> types_v03.AgentCard:
-        """Handles the 'agent/authenticatedExtendedCard' JSON-RPC method."""
+        """Handles the 'agent/getAuthenticatedExtendedCard' JSON-RPC method."""
         if not self.agent_card.capabilities.extended_agent_card:
             raise ExtendedAgentCardNotConfiguredError(
                 message='Authenticated card not supported'

src/a2a/compat/v0_3/jsonrpc_transport.py

@@ -376,7 +376,7 @@ async def get_extended_agent_card(
             return card
 
         rpc_request = JSONRPC20Request(
-            method='agent/authenticatedExtendedCard',
+            method='agent/getAuthenticatedExtendedCard',
             params={},
             _id=str(uuid4()),
         )

tests/compat/v0_3/test_jsonrpc_app_compat.py

@@ -11,13 +11,16 @@
 from a2a.server.request_handlers.request_handler import RequestHandler
 from a2a.types.a2a_pb2 import (
     AgentCard,
+    AgentCapabilities,
+    AgentInterface,
     Message as Message10,
     Part as Part10,
     Role as Role10,
     Task as Task10,
     TaskStatus as TaskStatus10,
     TaskState as TaskState10,
 )
+
 from a2a.compat.v0_3 import a2a_v0_3_pb2
 
 
@@ -44,15 +47,21 @@ def mock_handler():
 
 @pytest.fixture
 def test_app(mock_handler):
-    mock_agent_card = MagicMock(spec=AgentCard)
-    mock_agent_card.url = 'http://mockurl.com'
-    # Set up capabilities.streaming to avoid validation issues
-    mock_agent_card.capabilities = MagicMock()
-    mock_agent_card.capabilities.streaming = False
-    mock_agent_card.capabilities.push_notifications = True
-    mock_agent_card.capabilities.extended_agent_card = True
+    agent_card = AgentCard(
+        name='TestAgent',
+        description='Test Description',
+        version='1.0.0',
+        capabilities=AgentCapabilities(
+            streaming=False, push_notifications=True, extended_agent_card=True
+        ),
+    )
+    interface = agent_card.supported_interfaces.add()
+    interface.url = 'http://mockurl.com'
+    interface.protocol_binding = 'jsonrpc'
+    interface.protocol_version = '0.3'
+
     jsonrpc_routes = create_jsonrpc_routes(
-        agent_card=mock_agent_card,
+        agent_card=agent_card,
         request_handler=mock_handler,
         enable_v0_3_compat=True,
         rpc_url='/',
@@ -111,3 +120,25 @@ def test_get_task_v03_compat(
     assert 'result' in data
     assert data['result']['id'] == 'test_task_id'
     assert data['result']['status']['state'] == 'completed'
+
+
+def test_get_extended_agent_card_v03_compat(
+    client: TestClient,
+) -> None:
+    """Test that the v0.3 method name 'agent/getAuthenticatedExtendedCard' is correctly routed."""
+    request_payload = {
+        'jsonrpc': '2.0',
+        'id': '3',
+        'method': 'agent/getAuthenticatedExtendedCard',
+        'params': {},
+    }
+
+    response = client.post('/', json=request_payload)
+    assert response.status_code == 200
+    data = response.json()
+
+    assert data['jsonrpc'] == '2.0'
+    assert data['id'] == '3'
+    assert 'result' in data
+    # The result should be a v0.3 AgentCard
+    assert 'supportsAuthenticatedExtendedCard' in data['result']

tests/compat/v0_3/test_jsonrpc_transport.py

@@ -348,6 +348,39 @@ async def test_compat_jsonrpc_transport_get_extended_agent_card_not_supported(
     assert response == transport.agent_card
 
 
+@pytest.mark.asyncio
+async def test_compat_jsonrpc_transport_get_extended_agent_card_method_name(
+    transport,
+):
+    """Verify the correct v0.3 method name 'agent/getAuthenticatedExtendedCard' is used."""
+    captured_request: dict | None = None
+
+    async def mock_send_request(data, *args, **kwargs):
+        nonlocal captured_request
+        captured_request = data
+        return {
+            'result': {
+                'name': 'ExtendedAgent',
+                'url': 'http://agent',
+                'version': '1.0.0',
+                'description': 'Description',
+                'skills': [],
+                'defaultInputModes': [],
+                'defaultOutputModes': [],
+                'capabilities': {},
+                'supportsAuthenticatedExtendedCard': True,
+            }
+        }
+
+    transport._send_request = mock_send_request
+
+    req = GetExtendedAgentCardRequest()
+    await transport.get_extended_agent_card(req)
+
+    assert captured_request is not None
+    assert captured_request['method'] == 'agent/getAuthenticatedExtendedCard'
+
+
 @pytest.mark.asyncio
 async def test_compat_jsonrpc_transport_close(transport, mock_httpx_client):
     await transport.close()