Skip to content

Commit 091499c

Browse files
Apply suggestions from code review
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent b500742 commit 091499c

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

src/a2a/server/context.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,5 @@ class ServerCallContext(BaseModel):
2121

2222
state: State = Field(default={})
2323
user: User = Field(default=UnauthenticatedUser())
24-
requested_extensions: set[str] = Field(default=set())
25-
activated_extensions: set[str] = Field(default=set())
24+
requested_extensions: set[str] = Field(default_factory=set)
25+
activated_extensions: set[str] = Field(default_factory=set)

tests/server/request_handlers/test_grpc_handler.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -320,9 +320,9 @@ def side_effect(request, context: ServerCallContext):
320320
assert isinstance(call_context, ServerCallContext)
321321
assert call_context.requested_extensions == {'foo', 'bar'}
322322

323-
mock_grpc_context.set_trailing_metadata.assert_called_once_with(
324-
[(HTTP_EXTENSION_HEADER, 'foo'), (HTTP_EXTENSION_HEADER, 'baz')]
325-
)
323+
mock_grpc_context.set_trailing_metadata.assert_called_once()
324+
called_metadata = mock_grpc_context.set_trailing_metadata.call_args.args[0]
325+
assert set(called_metadata) == {(HTTP_EXTENSION_HEADER, 'foo'), (HTTP_EXTENSION_HEADER, 'baz')}
326326

327327
@patch(
328328
'a2a.server.request_handlers.grpc_handler.DefaultCallContextBuilder.build'
@@ -364,6 +364,6 @@ async def side_effect(request, context: ServerCallContext):
364364
assert isinstance(call_context, ServerCallContext)
365365
assert call_context.requested_extensions == {'foo', 'bar'}
366366

367-
mock_grpc_context.set_trailing_metadata.assert_called_once_with(
368-
[(HTTP_EXTENSION_HEADER, 'foo'), (HTTP_EXTENSION_HEADER, 'baz')]
369-
)
367+
mock_grpc_context.set_trailing_metadata.assert_called_once()
368+
called_metadata = mock_grpc_context.set_trailing_metadata.call_args.args[0]
369+
assert set(called_metadata) == {(HTTP_EXTENSION_HEADER, 'foo'), (HTTP_EXTENSION_HEADER, 'baz')}

0 commit comments

Comments
 (0)