Commit b36c4f6
authored
refactor: Resolve most of the open TODOs (#420)
# Description
There are currently 4 real TODOs in the codebase:
- Usage of `any` in `jsonrpc_transport_handler.ts` - **FIXED**
- Snake case and camel case acceptance for `historyLength` - **FIXED**
- Stale TODO in cli.ts mentioning exposing protocolName which was
already implemented - **TODO REMOVED**
- gRPC error mapping should be removed and the errors themselves
enriched - **NOT TACKLED, WILL BE DONE IN THE SEPARATE PR**.1 parent 4bfcf5f commit b36c4f6
5 files changed
Lines changed: 8 additions & 9 deletions
File tree
- src
- samples
- server
- express
- transports/jsonrpc
- test/server
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
| 12 | + | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
254 | 254 | | |
255 | 255 | | |
256 | 256 | | |
257 | | - | |
258 | 257 | | |
259 | 258 | | |
260 | 259 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
345 | 345 | | |
346 | 346 | | |
347 | 347 | | |
348 | | - | |
349 | | - | |
| 348 | + | |
350 | 349 | | |
351 | 350 | | |
352 | 351 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
66 | | - | |
67 | | - | |
| 65 | + | |
68 | 66 | | |
69 | 67 | | |
70 | 68 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | | - | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
60 | 63 | | |
61 | 64 | | |
62 | 65 | | |
| |||
0 commit comments