Skip to content

Adding plugin by name (pluginInstall) results in "NOTONBUKKITDEV" #30

@bugler

Description

@bugler

SpaceBukkit manager (PHP) correctly calls SpaceBukkit server (java) with pluginName.

This appears to trigger code at:
https://github.com/SpaceDev/SpaceRTK/blob/master/src/me/neatmonster/spacertk/actions/PluginActions.java
Around line 171 ( pluginsManager.getPlugin(pluginName) )

pluginsManager.getPlugin(pluginName) will always return false if the plugin is not already managed -- triggering "NOTONBUKKITDEV". This seems to be a mistake, since if it's not yet installed, it shouldn't be managed.

Unless I misunderstand this, the issue seems to be in:
https://github.com/SpaceDev/SpaceRTK/blob/master/src/me/neatmonster/spacertk/plugins/PluginsManager.java
Around line 107 ( if (contains(pluginName)) { )

Here, it looks like if we manage the plugin, then we'll add it. Shouldn't it be the opposite? This seems to make it impossible to install a plugin using the BukGet UI.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions