Fix LIKE in SHOW COLUMN being applied to table name instead of column name (#211)

Author: adamziel

tests/WP_SQLite_Driver_Metadata_Tests.php

@@ -412,6 +412,32 @@ public function testShowTableStatus() {
 		);
 	}
 
+	public function testShowColumnsLike(): void {
+		$this->assertQuery( 'CREATE TABLE t (id INT, val1 INT, val2 INT, name TEXT)' );
+		$result = $this->assertQuery( "SHOW COLUMNS FROM t LIKE 'val%'" );
+		$this->assertEquals(
+			array(
+				(object) array(
+					'Field'   => 'val1',
+					'Type'    => 'int',
+					'Null'    => 'YES',
+					'Key'     => '',
+					'Default' => null,
+					'Extra'   => '',
+				),
+				(object) array(
+					'Field'   => 'val2',
+					'Type'    => 'int',
+					'Null'    => 'YES',
+					'Key'     => '',
+					'Default' => null,
+					'Extra'   => '',
+				),
+			),
+			$result
+		);
+	}
+
 	private function assertTableEmpty( $table_name, $empty_var ) {
 
 		$this->assertQuery(

wp-includes/sqlite-ast/class-wp-sqlite-driver.php

@@ -1713,7 +1713,7 @@ private function execute_show_table_status_statement( WP_Parser_Node $node ): vo
 		// LIKE and WHERE clauses.
 		$like_or_where = $node->get_first_child_node( 'likeOrWhere' );
 		if ( null !== $like_or_where ) {
-			$condition = $this->translate_show_like_or_where_condition( $like_or_where );
+			$condition = $this->translate_show_like_or_where_condition( $like_or_where, 'table_name' );
 		}
 
 		// Fetch table information.
@@ -1782,7 +1782,7 @@ private function execute_show_tables_statement( WP_Parser_Node $node ): void {
 		// LIKE and WHERE clauses.
 		$like_or_where = $node->get_first_child_node( 'likeOrWhere' );
 		if ( null !== $like_or_where ) {
-			$condition = $this->translate_show_like_or_where_condition( $like_or_where );
+			$condition = $this->translate_show_like_or_where_condition( $like_or_where, 'table_name' );
 		}
 
 		// Fetch table information.
@@ -1867,7 +1867,7 @@ private function execute_show_columns_statement( WP_Parser_Node $node ): void {
 		// LIKE and WHERE clauses.
 		$like_or_where = $node->get_first_child_node( 'likeOrWhere' );
 		if ( null !== $like_or_where ) {
-			$condition = $this->translate_show_like_or_where_condition( $like_or_where );
+			$condition = $this->translate_show_like_or_where_condition( $like_or_where, 'column_name' );
 		}
 
 		// Fetch column information.
@@ -3003,16 +3003,21 @@ private function recreate_table_from_information_schema(
 	 * Translate a MySQL SHOW LIKE ... or SHOW WHERE ... condition to SQLite.
 	 *
 	 * @param  WP_Parser_Node $like_or_where The "likeOrWhere" AST node.
+	 * @param  string         $like_column   The column name to use in the LIKE clause ("table_name", "column_name", etc.).
 	 * @return string                        The translated value.
 	 * @throws WP_SQLite_Driver_Exception    When the translation fails.
 	 */
-	private function translate_show_like_or_where_condition( WP_Parser_Node $like_or_where ): string {
+	private function translate_show_like_or_where_condition( WP_Parser_Node $like_or_where, string $like_column ): string {
 		$like_clause = $like_or_where->get_first_child_node( 'likeClause' );
 		if ( null !== $like_clause ) {
 			$value = $this->translate(
 				$like_clause->get_first_child_node( 'textStringLiteral' )
 			);
-			return sprintf( "AND table_name LIKE %s ESCAPE '\\'", $value );
+			return sprintf(
+				"AND %s LIKE %s ESCAPE '\\'",
+				$this->quote_sqlite_identifier( $like_column ),
+				$value
+			);
 		}
 
 		$where_clause = $like_or_where->get_first_child_node( 'whereClause' );