Patch Turso effective_temp_store to always return Memory

The disk-temp pager has a state-dependent `short read on page N`
bug that breaks testCreateTemporaryTable +
testTemporaryTableHasPriorityOverStandardTable mid-suite. Setting
PRAGMA temp_store = MEMORY at runtime fixes those tests but
crashes testReconstructTable in Turso's pager — `set_temp_store`
calls `bump_prepare_context_generation` which seems to corrupt
state testReconstructTable depends on later
(project_turso_testreconstructtable_fragile).

Patch `effective_temp_store` in core/connection.rs to return
`TempStore::Memory` unconditionally, at compile time. This forces
`create_temp_database` to take the MemoryIO branch always, but
without going through any runtime mutator, so prepared-statement
caches and other transient state aren't invalidated.

Author: JanJakes

.github/workflows/phpunit-tests-turso.yml

@@ -595,6 +595,50 @@ jobs:
           print('patched CreateTrigger to preserve original SQL text')
           PY_TRIGGER_SQL
 
+          # Force temp tables to use MemoryIO under all conditions, to
+          # bypass the disk-temp pager's state-dependent
+          # `short read on page N` bug that breaks
+          # testCreateTemporaryTable + testTemporaryTableHasPriorityOverStandardTable.
+          #
+          # Setting this via runtime PRAGMA temp_store = MEMORY crashes
+          # testReconstructTable in the pager (memory:
+          # project_turso_testreconstructtable_fragile). Instead, patch
+          # `effective_temp_store` so it returns `TempStore::Memory`
+          # unconditionally — a compile-time change that doesn't go
+          # through `set_temp_store` / `bump_prepare_context_generation`,
+          # so testReconstructTable's prepared-statement cache is
+          # untouched.
+          python3 - <<'PY_TEMP_MEMORY'
+          p = 'core/connection.rs'
+          s = open(p).read()
+          old = (
+              "    fn effective_temp_store(&self) -> crate::TempStore {\n"
+              "        let temp_store = self.get_temp_store();\n"
+              "        #[cfg(feature = \"fs\")]\n"
+              "        {\n"
+              "            temp_store\n"
+              "        }\n"
+              "        #[cfg(not(feature = \"fs\"))]\n"
+              "        {\n"
+              "            let _ = temp_store;\n"
+              "            crate::TempStore::Memory\n"
+              "        }\n"
+              "    }\n"
+          )
+          new = (
+              "    fn effective_temp_store(&self) -> crate::TempStore {\n"
+              "        // Always use MemoryIO for temp tables: avoids a state-dependent\n"
+              "        // `short read on page N` bug in the disk-temp pager that breaks\n"
+              "        // testCreateTemporaryTable mid-suite under PHPUnit.\n"
+              "        let _ = self.get_temp_store();\n"
+              "        crate::TempStore::Memory\n"
+              "    }\n"
+          )
+          assert old in s, 'effective_temp_store block not found'
+          open(p, 'w').write(s.replace(old, new, 1))
+          print('patched effective_temp_store to always return TempStore::Memory')
+          PY_TEMP_MEMORY
+
           echo '--- Patched stub! macro ---'
           sed -n '/macro_rules! stub/,/^}$/p' sqlite3/src/lib.rs