Experiment: patch Doltlite to skip WITHOUT ROWID auto-conversion

Doltlite auto-converts tables with composite/TEXT primary keys to
WITHOUT ROWID, which strips the ROWID column and breaks the driver's
ORDER BY ROWID tie-breaks in info-schema reads. The auto-conversion
is a single tabOpts |= TF_WithoutRowid in src/build.c.

Sed that line to a no-op before building so composite-PK tables take
SQLite's normal rowid + unique-PK-index path, and assert at runtime
that a composite-PK test table exposes a rowid.

Author: JanJakes

.github/workflows/phpunit-tests-doltlite.yml

@@ -31,6 +31,26 @@ jobs:
           repository: dolthub/doltlite
           path: doltlite-src
 
+      - name: Disable Doltlite's auto-conversion of PK tables to WITHOUT ROWID
+        # Experimental: Doltlite normally auto-converts tables with a
+        # non-INTEGER / composite PK to WITHOUT ROWID, which strips `ROWID`.
+        # The mysql-on-sqlite driver uses `ORDER BY ROWID` as a tie-break in
+        # its info-schema reads, so that auto-conversion produces hundreds
+        # of "no such column: ROWID" failures. We neutralize the single
+        # assignment in src/build.c that flips TF_WithoutRowid on so those
+        # tables take SQLite's normal rowid+unique-PK-index path.
+        run: |
+          FILE=doltlite-src/src/build.c
+          BEFORE=$(grep -cF '    tabOpts |= TF_WithoutRowid;' "$FILE")
+          if [ "$BEFORE" != "1" ]; then
+            echo "::error::expected exactly 1 match for the auto-convert line, found $BEFORE"
+            exit 1
+          fi
+          # Use @ as sed delimiter because the match contains `|=`.
+          sed -i 's@^    tabOpts |= TF_WithoutRowid;$@    /* patched off in CI: do not auto-convert composite-PK tables */ (void)0;@' "$FILE"
+          echo "Patched line:"
+          grep -n 'patched off in CI' "$FILE"
+
       - name: Build Doltlite shared library
         run: |
           mkdir -p build
@@ -74,7 +94,7 @@ jobs:
           echo "ldd pdo_sqlite:"
           ldd "$(php -r 'echo ini_get("extension_dir");')/pdo_sqlite.so"
 
-      - name: Verify Doltlite is active in PHP
+      - name: Verify Doltlite is active in PHP and rowid patch took effect
         run: |
           VERSION=$(php -r 'echo (new PDO("sqlite::memory:"))->query("SELECT SQLITE_VERSION()")->fetch()[0];')
           ENGINE=$(php -r 'echo (new PDO("sqlite::memory:"))->query("SELECT doltlite_engine()")->fetch()[0];')
@@ -84,6 +104,20 @@ jobs:
             echo "::error::Doltlite is not active (expected doltlite_engine() = 'prolly', got '${ENGINE}')"
             exit 1
           fi
+          # Confirm the build.c patch took effect: a composite-PK table
+          # would normally be auto-converted to WITHOUT ROWID (no rowid
+          # column); with the patch, rowid should be accessible.
+          ROWID=$(php -r '
+            $db = new PDO("sqlite::memory:");
+            $db->exec("CREATE TABLE t (a INT, b INT, PRIMARY KEY(a, b))");
+            $db->exec("INSERT INTO t VALUES (1, 2)");
+            echo $db->query("SELECT rowid FROM t")->fetch()[0];
+          ' 2>&1)
+          echo "composite-PK rowid = ${ROWID}"
+          if ! [[ "${ROWID}" =~ ^[0-9]+$ ]]; then
+            echo "::error::rowid-preservation patch did not take effect: ${ROWID}"
+            exit 1
+          fi
 
       - name: Install Composer dependencies (root)
         uses: ramsey/composer-install@v3