Skip to content

Commit 9b35d57

Browse files
committed
Add a TODO for database-qualified identifiers
1 parent d5add40 commit 9b35d57

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

wp-includes/sqlite-ast/class-wp-sqlite-driver.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2939,6 +2939,9 @@ private function translate_query_expression( WP_Parser_Node $node ): string {
29392939
* SELECT t1.name FROM t1 JOIN t2 ON t2.t1_id = t1.id ORDER BY t1.name
29402940
*
29412941
* Note that the ORDER BY column was rewritten from "name" to "t1.name".
2942+
*
2943+
* @TODO: When multi-database support is implemented, we'll also need to
2944+
* consider column references in forms like "db.table.column".
29422945
*/
29432946
$disambiguated_order_list = array();
29442947
$order_clause = $node->get_first_child_node( 'orderClause' );

0 commit comments

Comments
 (0)