Fxi support for valid date field default values

Author: wojtekn

tests/WP_SQLite_Translator_Tests.php

@@ -292,14 +292,19 @@ public function testShowCreateTable1() {
 
 	public function testShowCreateTableWithEmptyDatetimeDefault() {
 		$this->assertQuery(
-			'CREATE TABLE _tmp_table (
+			"CREATE TABLE _tmp_table (
 				ID BIGINT PRIMARY KEY AUTO_INCREMENT,
 				timestamp1 datetime NOT NULL,
 				timestamp2 date NOT NULL,
 				timestamp3 time NOT NULL,
 				timestamp4 timestamp NOT NULL,
-				timestamp5 year NOT NULL
-			);'
+				timestamp5 year NOT NULL,
+				notempty1 datetime DEFAULT '1999-12-12 12:12:12',
+				notempty2 date DEFAULT '1999-12-12',
+				notempty3 time DEFAULT '12:12:12',
+				notempty4 year DEFAULT '2024',
+				notempty5 timestamp DEFAULT '1734539165',
+			);"
 		);
 
 		$this->assertQuery(
@@ -308,15 +313,20 @@ public function testShowCreateTableWithEmptyDatetimeDefault() {
 		$results = $this->engine->get_query_results();
 
 		$this->assertEquals(
-			'CREATE TABLE `_tmp_table` (
+			"CREATE TABLE `_tmp_table` (
 	`ID` bigint AUTO_INCREMENT,
 	`timestamp1` datetime NOT NULL,
 	`timestamp2` date NOT NULL,
 	`timestamp3` time NOT NULL,
 	`timestamp4` timestamp NOT NULL,
 	`timestamp5` year NOT NULL,
+	`notempty1` datetime DEFAULT '1999-12-12 12:12:12',
+	`notempty2` date DEFAULT '1999-12-12',
+	`notempty3` time DEFAULT '12:12:12',
+	`notempty4` year DEFAULT '2024',
+	`notempty5` timestamp DEFAULT '1734539165',
 	PRIMARY KEY (`ID`)
-);',
+);",
 			$results[0]->{'Create Table'}
 		);
 	}

wp-includes/sqlite/class-wp-sqlite-translator.php

@@ -3868,11 +3868,22 @@ function ( $row ) use ( $name_map ) {
 	 * @return boolean If column should have a default definition.
 	 */
 	private function column_has_default( $column, $mysql_type ) {
-		if ( null !== $column->dflt_value && '' !== $column->dflt_value && ! in_array( strtolower( $mysql_type ), array( 'datetime', 'date', 'time', 'timestamp', 'year' ), true ) ) {
-			return true;
+		if ( null === $column->dflt_value ) {
+			return false;
 		}
 
-		return false;
+		if ( '' === $column->dflt_value ) {
+			return false;
+		}
+
+		if (
+			in_array( strtolower( $mysql_type ), array( 'datetime', 'date', 'time', 'timestamp', 'year' ), true ) &&
+			"''" === $column->dflt_value
+		) {
+			return false;
+		}
+
+		return true;
 	}
 
 	/**