Reflect SQLite < 3.33.0 edge case behavior in tests

Author: JanJakes

tests/WP_SQLite_Driver_Metadata_Tests.php

@@ -251,51 +251,83 @@ public function testCheckTable() {
 			$result
 		);
 
+		/**
+		 * With SQLite < 3.33.0, the integrity check operation doesn't throw
+		 * an error for missing tables. Let's reflect this in the assertions.
+		 */
+		$is_strict_integrity_check_supported = version_compare( $this->engine->get_sqlite_version(), '3.33.0', '>=' );
+
 		// A missing table.
-		$result = $this->assertQuery( 'CHECK TABLE missing' );
-		$this->assertEquals(
-			array(
-				(object) array(
-					'Table'    => 'wp.missing',
-					'Op'       => 'check',
-					'Msg_type' => 'Error',
-					'Msg_text' => "Table 'missing' doesn't exist",
-				),
+		$result   = $this->assertQuery( 'CHECK TABLE missing' );
+		$expected = array(
+			(object) array(
+				'Table'    => 'wp.missing',
+				'Op'       => 'check',
+				'Msg_type' => 'Error',
+				'Msg_text' => "Table 'missing' doesn't exist",
+			),
+			(object) array(
+				'Table'    => 'wp.missing',
+				'Op'       => 'check',
+				'Msg_type' => 'status',
+				'Msg_text' => 'Operation failed',
+			),
+		);
+
+		if ( ! $is_strict_integrity_check_supported ) {
+			$expected = array(
 				(object) array(
 					'Table'    => 'wp.missing',
 					'Op'       => 'check',
 					'Msg_type' => 'status',
-					'Msg_text' => 'Operation failed',
+					'Msg_text' => 'OK',
 				),
+			);
+		}
+
+		$this->assertEquals( $expected, $result );
+
+		// One good and one missing table.
+		$result   = $this->assertQuery( 'CHECK TABLE t1, missing' );
+		$expected = array(
+			(object) array(
+				'Table'    => 'wp.t1',
+				'Op'       => 'check',
+				'Msg_type' => 'status',
+				'Msg_text' => 'OK',
+			),
+			(object) array(
+				'Table'    => 'wp.missing',
+				'Op'       => 'check',
+				'Msg_type' => 'Error',
+				'Msg_text' => "Table 'missing' doesn't exist",
+			),
+			(object) array(
+				'Table'    => 'wp.missing',
+				'Op'       => 'check',
+				'Msg_type' => 'status',
+				'Msg_text' => 'Operation failed',
 			),
-			$result
 		);
 
-		// One good and one missing table.
-		$result = $this->assertQuery( 'CHECK TABLE t1, missing' );
-		$this->assertEquals(
-			array(
+		if ( ! $is_strict_integrity_check_supported ) {
+			$expected = array(
 				(object) array(
 					'Table'    => 'wp.t1',
 					'Op'       => 'check',
 					'Msg_type' => 'status',
 					'Msg_text' => 'OK',
 				),
-				(object) array(
-					'Table'    => 'wp.missing',
-					'Op'       => 'check',
-					'Msg_type' => 'Error',
-					'Msg_text' => "Table 'missing' doesn't exist",
-				),
 				(object) array(
 					'Table'    => 'wp.missing',
 					'Op'       => 'check',
 					'Msg_type' => 'status',
-					'Msg_text' => 'Operation failed',
+					'Msg_text' => 'OK',
 				),
-			),
-			$result
-		);
+			);
+		}
+
+		$this->assertEquals( $expected, $result );
 	}
 
 	public function testOptimizeTable() {