Skip to content

Commit 5f879cf

Browse files
committed
Revert "Run the 3 failing tests in separate PHP processes under Turso"
This reverts commit 647ed4d.
1 parent 647ed4d commit 5f879cf

1 file changed

Lines changed: 0 additions & 46 deletions

File tree

.github/workflows/phpunit-tests-turso.yml

Lines changed: 0 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -1896,52 +1896,6 @@ jobs:
18961896
open(path, 'w').write(src)
18971897
print('patched testCreateTableWithDefaultExpressions PRAGMA expectations for Turso')
18981898
1899-
# 22. The three failing tests are all state-dependent — every probe
1900-
# of their SQL on a fresh PDO returns the correct rows, but
1901-
# they fail mid-suite. The tests are:
1902-
#
1903-
# testCreateTemporaryTable
1904-
# testTemporaryTableHasPriorityOverStandardTable
1905-
# testInformationSchemaTablesFilterByAutoIncrement
1906-
#
1907-
# Annotate each with PHPUnit's `@runInSeparateProcess` +
1908-
# `@preserveGlobalState disabled` so they execute in a
1909-
# fresh PHP subprocess. That recreates the fresh-state
1910-
# conditions the probes verified work under.
1911-
path = 'tests/WP_SQLite_Driver_Tests.php'
1912-
src = open(path).read()
1913-
for marker in (
1914-
"\tpublic function testCreateTemporaryTable() {\n",
1915-
"\tpublic function testTemporaryTableHasPriorityOverStandardTable(): void {\n",
1916-
):
1917-
ann = (
1918-
"\t/**\n"
1919-
"\t * Run in a separate process to avoid mid-suite Turso state buildup\n"
1920-
"\t * triggering a `short read on page N` pager I/O bug.\n"
1921-
"\t * @runInSeparateProcess\n"
1922-
"\t * @preserveGlobalState disabled\n"
1923-
"\t */\n"
1924-
)
1925-
assert marker in src and src.count(marker) == 1, f'marker not unique: {marker!r}'
1926-
src = src.replace(marker, ann + marker, 1)
1927-
open(path, 'w').write(src)
1928-
1929-
path2 = 'tests/WP_SQLite_Driver_Metadata_Tests.php'
1930-
src2 = open(path2).read()
1931-
marker2 = "\tpublic function testInformationSchemaTablesFilterByAutoIncrement(): void {\n"
1932-
ann2 = (
1933-
"\t/**\n"
1934-
"\t * Run in a separate process to avoid mid-suite Turso state buildup\n"
1935-
"\t * causing the WHERE filter on a correlated-subquery alias to return 0 rows.\n"
1936-
"\t * @runInSeparateProcess\n"
1937-
"\t * @preserveGlobalState disabled\n"
1938-
"\t */\n"
1939-
)
1940-
assert marker2 in src2 and src2.count(marker2) == 1, 'metadata marker not unique'
1941-
src2 = src2.replace(marker2, ann2 + marker2, 1)
1942-
open(path2, 'w').write(src2)
1943-
print('annotated 3 failing tests with @runInSeparateProcess / @preserveGlobalState disabled')
1944-
19451899
# 20. NOTE: setting PRAGMA temp_store = MEMORY (either globally
19461900
# at connection setup or scoped to the two failing temp
19471901
# tests) consistently crashes testReconstructTable in

0 commit comments

Comments
 (0)