Rename native node helper to was_mutated()

The previous helper name (has_unmaterialized_native_ast) implied a runtime
check for native-extension presence. It's actually a per-instance state
flag tracking whether this node's children have been copied into PHP.
was_mutated() reads that intent more directly.

Author: adamziel

packages/mysql-on-sqlite/src/mysql/native/class-wp-mysql-native-parser-node.php

@@ -3,13 +3,34 @@
 /**
  * Native-backed parser node.
  *
- * This subclass keeps the regular WP_Parser_Node API while delegating lazy AST
- * reads to the optional native MySQL parser extension. The base node remains a
- * plain PHP tree node for the polyfill parser.
+ * Instances of this class are constructed exclusively by the native MySQL
+ * parser extension: when the extension parses a query, it produces a tree of
+ * `WP_MySQL_Native_Parser_Node` objects whose `$native_ast` and
+ * `$native_node_index` fields point into a Rust-owned AST buffer. Read methods
+ * (`get_start`, `has_child`, `get_children`, ...) delegate to the extension so
+ * children are never materialized into PHP arrays unless something actually
+ * asks for them.
+ *
+ * Read methods eagerly call `materialize_native_children()` — once the
+ * children have been copied into PHP, `was_mutated()` returns true and the
+ * call falls through to the parent implementation. The `was_mutated` flag is
+ * NOT a runtime check for whether the native extension is loaded — if this
+ * class is in use, the extension is loaded by definition. It tracks whether
+ * THIS specific node has had its children pulled into the inherited
+ * `$children` array (which happens on first read or first mutation via
+ * `append_child()` / `merge_fragment()`). From that point on, the node is a
+ * plain PHP-backed `WP_Parser_Node`.
+ *
+ * Mutation from PHP is real and intentional — query rewriters in
+ * `WP_PDO_MySQL_On_SQLite` (e.g. building synthetic `count(*)` expressions)
+ * call `append_child()` on parsed nodes. The lazy-then-materialize design
+ * keeps the fast path (read-only traversal) cheap while still allowing
+ * mutation when callers need it.
  */
 class WP_MySQL_Native_Parser_Node extends WP_Parser_Node {
 	private $native_ast        = null;
 	private $native_node_index = null;
+	private $was_mutated       = false;
 
 	public function __construct( $rule_id, $rule_name, $native_ast = null, $native_node_index = null ) {
 		parent::__construct( $rule_id, $rule_name );
@@ -129,17 +150,38 @@ public function get_length(): int {
 		return parent::get_length();
 	}
 
-	private function has_native_ast(): bool {
-		return null !== $this->native_ast;
-	}
-
+	/**
+	 * Indicates whether this node has been mutated from PHP.
+	 *
+	 * Returns false for freshly-parsed nodes whose children still live in the
+	 * Rust-owned AST buffer; returns true once `append_child()` or
+	 * `merge_fragment()` has copied the children into the inherited
+	 * `$children` array and dropped the native AST reference.
+	 *
+	 * This is a per-instance state check, not a check for whether the native
+	 * extension is loaded.
+	 */
+	private function was_mutated(): bool {
+		return $this->was_mutated;
+	}
+
+	/**
+	 * Copies native children into the inherited PHP $children array and drops
+	 * the native AST reference for this node.
+	 *
+	 * Called before any mutation (append_child, merge_fragment) so the node's
+	 * authoritative state lives in PHP from that point on. After this runs,
+	 * was_mutated() returns true and read methods fall through to the parent
+	 * WP_Parser_Node implementation.
+	 */
 	private function materialize_native_children(): void {
-		if ( ! $this->has_native_ast() ) {
+		if ( $this->was_mutated ) {
 			return;
 		}
 
 		$this->children          = wp_sqlite_mysql_native_ast_get_children( $this->native_ast, $this->native_node_index );
 		$this->native_ast        = null;
 		$this->native_node_index = null;
+		$this->was_mutated       = true;
 	}
 }