Build WASM extension for all Playground PHP versions

Author: adamziel

.github/workflows/wasm-spike.yml

@@ -26,7 +26,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php: ['8.4']
+        php: ['8.5', '8.4', '8.3', '8.2', '8.1', '8.0', '7.4']
         async-mode: ['jspi']
 
     steps:
@@ -55,7 +55,13 @@ jobs:
             /packages/php-wasm/fs-journal/
             /packages/php-wasm/logger/
             /packages/php-wasm/node/
+            /packages/php-wasm/node-builds/7-4/
+            /packages/php-wasm/node-builds/8-0/
+            /packages/php-wasm/node-builds/8-1/
+            /packages/php-wasm/node-builds/8-2/
+            /packages/php-wasm/node-builds/8-3/
             /packages/php-wasm/node-builds/8-4/
+            /packages/php-wasm/node-builds/8-5/
             /packages/php-wasm/progress/
             /packages/php-wasm/scopes/
             /packages/php-wasm/stream-compression/
@@ -116,6 +122,7 @@ jobs:
         working-directory: sqlite-database-integration/packages/php-ext-wp-mysql-parser/wasm-spike
         env:
           PLAYGROUND_REPO: ${{ github.workspace }}/wordpress-playground
+          PHP_VERSION: ${{ matrix.php }}
         run: node run-spike.mjs
 
       - name: Upload artifacts on success

packages/php-ext-wp-mysql-parser/wasm-spike/Dockerfile.rust

@@ -11,35 +11,47 @@
 # Build with:
 #   docker build \
 #     --build-arg BASE_IMAGE=playground-php-wasm:compile-extension-php8-4-jspi \
+#     --build-arg HOST_PHP_VERSION=8.4 \
 #     -t playground-php-wasm-ext-rust:8.4-jspi \
 #     -f Dockerfile.rust .
 
 ARG BASE_IMAGE=playground-php-wasm:compile-extension-php8-4-jspi
+ARG HOST_PHP_VERSION=8.4
 
-# Stage providing a host PHP 8.4 CLI binary. ext-php-rs's build.rs shells
+# Stage providing a host PHP CLI binary. ext-php-rs's build.rs shells
 # out to `php` to detect the PHP version (PHP_VERSION_ID drives the cfg
-# flags php80..php85). The wasm-targeted PHP install in /usr/local has no
-# CLI binary (--disable-cli), Ubuntu noble ships only PHP 8.3, and
-# packages.sury.org blocks our datacenter IP, so we steal a CLI from the
-# official php:8.4-cli image.
-FROM php:8.4-cli AS host-php-cli
+# flags such as php74, php80, and php85). The wasm-targeted PHP install in
+# /usr/local has no CLI binary (--disable-cli), so copy a matching CLI from
+# the official PHP image for the target version.
+FROM php:${HOST_PHP_VERSION}-cli AS host-php-cli
+
+RUN set -eux; \
+    mkdir -p /opt/host-php/libdeps; \
+    ldd /usr/local/bin/php \
+        | awk '($2 == "=>") { print $3 } ($1 ~ /^\//) { print $1 }' \
+        | grep -v '^$' \
+        | sort -u \
+        | while read -r lib; do cp -L "$lib" /opt/host-php/libdeps/; done
 
 FROM ${BASE_IMAGE}
 
 COPY --from=host-php-cli /usr/local/bin/php /opt/host-php/bin/php
 COPY --from=host-php-cli /usr/local/lib/php /opt/host-php/lib/php
 COPY --from=host-php-cli /usr/local/etc/php /opt/host-php/etc/php
 COPY --from=host-php-cli /usr/local/include/php /opt/host-php/include/php
+COPY --from=host-php-cli /opt/host-php/libdeps /opt/host-php/libdeps
 
 ENV RUSTUP_HOME=/root/rustup \
     CARGO_HOME=/root/cargo \
-    PATH=/root/cargo/bin:/root/rustup/bin:/usr/local/bin:/usr/bin:/bin
+    PATH=/root/cargo/bin:/root/rustup/bin:/usr/local/bin:/usr/bin:/bin \
+    LD_LIBRARY_PATH=/opt/host-php/libdeps:/opt/host-php/lib
 
 RUN apt-get update && apt-get install -y --no-install-recommends \
         curl ca-certificates build-essential \
         libclang-dev clang llvm-dev pkg-config libxml2 libonig5 libsqlite3-0 \
         libargon2-1 libssl3 zlib1g libreadline8 \
     && rm -rf /var/lib/apt/lists/* \
+    && /opt/host-php/bin/php -v \
     && ln -sf /opt/host-php/bin/php /usr/local/bin/php-host
 
 # ext-php-rs's build.rs needs a host `php` executable to query include paths

packages/php-ext-wp-mysql-parser/wasm-spike/RESULT.md

@@ -2,10 +2,11 @@
 
 ## Current status
 
-The spike now builds and loads `wp_mysql_parser` in Playground on PHP 8.4
-JSPI. CI verifies the generated side module by loading its manifest through
-Playground's `@php-wasm/compile-extension` test harness and running a native
-lexer smoke test.
+The spike now builds and loads `wp_mysql_parser` in Playground across every
+PHP version currently supported by Playground's `@php-wasm/compile-extension`
+helper: 7.4 and 8.0 through 8.5, all JSPI. CI verifies each generated side
+module by loading its manifest through Playground's compile-extension test
+harness and running a native lexer smoke test.
 
 The build uses the upstream Playground compile-extension tooling for the
 phpize side-module build, static archive force-linking, wasm-opt pass, and
@@ -27,10 +28,11 @@ Stage 2 path that previously lived in this spike:
 - Emits a manifest with `sha256` hashes that the Playground runtime can load
   at startup.
 
-The helper is not a full Rust build system. This crate still needs a prebuild
-step that produces a wasm32-unknown-emscripten `staticlib`, plus a tiny phpize
-shim (`config.m4` and `wp_mysql_parser_shim.c`) so the helper has a normal
-extension source directory to compile.
+The helper is not a full Rust build system. This crate still needs a
+per-PHP-version prebuild step that produces a wasm32-unknown-emscripten
+`staticlib` with matching PHP headers and host PHP CLI version, plus a tiny
+phpize shim (`config.m4` and `wp_mysql_parser_shim.c`) so the helper has a
+normal extension source directory to compile.
 
 ## Remaining local compatibility patches
 
@@ -69,7 +71,7 @@ cd packages/php-ext-wp-mysql-parser/wasm-spike
 PLAYGROUND_REPO=/abs/path/to/wordpress-playground \
   bash build-in-docker-rust.sh
 
-PLAYGROUND_REPO=/abs/path/to/wordpress-playground \
+PLAYGROUND_REPO=/abs/path/to/wordpress-playground PHP_VERSION=8.4 \
   node run-spike.mjs
 ```
 

packages/php-ext-wp-mysql-parser/wasm-spike/build-in-docker-rust.sh

@@ -12,7 +12,7 @@
 #
 # Outputs:
 #   wasm-spike/dist/libwp_mysql_parser.a  (Stage 1)
-#   wasm-spike/dist/wp_mysql_parser-php8.4-jspi.so (Stage 2, wasm side module)
+#   wasm-spike/dist/wp_mysql_parser-php<version>-jspi.so (Stage 2, wasm side module)
 #   wasm-spike/dist/manifest.json (written by @php-wasm/compile-extension)
 set -euo pipefail
 
@@ -69,6 +69,7 @@ echo "==> Stage 0: preparing $BASE_IMAGE via Playground compile-extension toolin
 echo "==> Stage 0: building $RUST_IMAGE"
 docker build \
   --build-arg "BASE_IMAGE=$BASE_IMAGE" \
+  --build-arg "HOST_PHP_VERSION=$PHP_VERSION" \
   -t "$RUST_IMAGE" \
   -f "$SPIKE_DIR/Dockerfile.rust" \
   "$SPIKE_DIR"

packages/php-ext-wp-mysql-parser/wasm-spike/run-spike.mjs

@@ -16,7 +16,7 @@ import { fileURLToPath } from 'node:url';
 const here = dirname(fileURLToPath(import.meta.url));
 const SPIKE_DIR = here;
 const MANIFEST = resolve(SPIKE_DIR, 'dist/manifest.json');
-const PHP_VERSION = '8.4';
+const PHP_VERSION = process.env.PHP_VERSION || '8.4';
 
 if (!existsSync(MANIFEST)) {
   console.error(`[spike] Missing ${MANIFEST}. Run build-in-docker-rust.sh first.`);