Use bit-shift math in unseeded RAND() compile path

JanJakes · JanJakes · commit 409a43c5e9fe · 2026-05-04T16:10:29.000+02:00
Replace the literal `0x001FFFFFFFFFFFFF` / `9007199254740992.0` with `(1 << 53) - 1` and `(1 << 53)` written directly in the SQL. SQLite's query optimizer folds them at prepare time, so there's no runtime cost, and the math is now self-documenting. Per review feedback on #363.
diff --git a/packages/mysql-on-sqlite/src/sqlite/class-wp-pdo-mysql-on-sqlite.php b/packages/mysql-on-sqlite/src/sqlite/class-wp-pdo-mysql-on-sqlite.php
@@ -4418,7 +4418,7 @@ private function translate_function_call( WP_Parser_Node $node ): string {
 				 * The UDF also handles RAND(NULL) as RAND(0), matching MySQL.
 				 */
 				if ( 0 === count( $args ) ) {
-					return '((RANDOM() & 0x001FFFFFFFFFFFFF) / 9007199254740992.0)';
+					return '((RANDOM() & ((1 << 53) - 1)) / ((1 << 53) * 1.0))';
 				}
 				return $this->translate_sequence( $node->get_children() );
 			case 'DATE_FORMAT':

Original file line number	Diff line number	Diff line change
`@@ -4418,7 +4418,7 @@ private function translate_function_call( WP_Parser_Node $node ): string {`
`4418`	`4418`	`* The UDF also handles RAND(NULL) as RAND(0), matching MySQL.`
`4419`	`4419`	`*/`
`4420`	`4420`	`if ( 0 === count( $args ) ) {`
`4421`		`- return '((RANDOM() & 0x001FFFFFFFFFFFFF) / 9007199254740992.0)';`
	`4421`	`+ return '((RANDOM() & ((1 << 53) - 1)) / ((1 << 53) * 1.0))';`
`4422`	`4422`	`}`
`4423`	`4423`	`return $this->translate_sequence( $node->get_children() );`
`4424`	`4424`	`case 'DATE_FORMAT':`