Support whitespace in PDO DSN as per PHP PDO

Author: JanJakes

tests/WP_PDO_MySQL_On_SQLite_PDO_API_Tests.php

@@ -19,6 +19,24 @@ public function test_connection(): void {
 		$this->assertInstanceOf( PDO::class, $driver );
 	}
 
+	public function test_dsn_parsing(): void {
+		// Standard DSN.
+		$driver = new WP_PDO_MySQL_On_SQLite( 'mysql-on-sqlite:path=:memory:;dbname=wp' );
+		$this->assertSame( 'wp', $driver->query( 'SELECT DATABASE()' )->fetch()[0] );
+
+		// DSN with trailing semicolon.
+		$driver = new WP_PDO_MySQL_On_SQLite( 'mysql-on-sqlite:path=:memory:;dbname=wp;' );
+		$this->assertSame( 'wp', $driver->query( 'SELECT DATABASE()' )->fetch()[0] );
+
+		// DSN with whitespace before argument names.
+		$driver = new WP_PDO_MySQL_On_SQLite( "mysql-on-sqlite:  path=:memory:;\t dbname=wp" );
+		$this->assertSame( 'wp', $driver->query( 'SELECT DATABASE()' )->fetch()[0] );
+
+		// DSN with whitespace in the database name.
+		$driver = new WP_PDO_MySQL_On_SQLite( 'mysql-on-sqlite:path=:memory:;dbname= w p ' );
+		$this->assertSame( ' w p ', $driver->query( 'SELECT DATABASE()' )->fetch()[0] );
+	}
+
 	public function test_query(): void {
 		$result = $this->driver->query( "SELECT 1, 'abc'" );
 		$this->assertInstanceOf( PDOStatement::class, $result );

wp-includes/sqlite-ast/class-wp-pdo-mysql-on-sqlite.php

@@ -619,6 +619,10 @@ public function __construct(
 
 		$args = array();
 		foreach ( explode( ';', $dsn_parts[1] ) as $arg ) {
+			$arg = ltrim( $arg ); // PDO DSN allows whitespace before argument name.
+			if ( '' === $arg ) {
+				continue;
+			}
 			$arg_parts             = explode( '=', $arg, 2 );
 			$args[ $arg_parts[0] ] = $arg_parts[1] ?? null;
 		}