Wrap AUTO_INCREMENT correlated subquery in MAX aggregate

Author: JanJakes

.github/workflows/phpunit-tests-turso.yml

@@ -1199,6 +1199,66 @@ jobs:
           open(path, 'w').write(src)
           print('patched hex-literal alias force under Turso')
 
+          # 18. Rewrite AUTO_INCREMENT subquery in information_schema.tables
+          #     from a correlated scalar subquery (which Turso evaluates
+          #     incorrectly for some rows) to a plain SELECT with a correlated
+          #     SELECT aggregated via MAX so the result is stable per outer
+          #     row. Both testInformationSchemaTablesFilterByAutoIncrement
+          #     and testCreateTableSetAutoIncrement rely on this returning
+          #     NULL for tables without auto_increment columns.
+          src = open(path).read()
+          old = (
+              "\t\t\t\t\t$auto_increment_subquery = sprintf(\n"
+              "\t\t\t\t\t\t\"(\n"
+              "\t\t\t\t\t\t\tSELECT COALESCE(s.seq + 1, 1)\n"
+              "\t\t\t\t\t\t\tFROM %s AS c\n"
+              "\t\t\t\t\t\t\t%s\n"
+              "\t\t\t\t\t\t\tWHERE c.extra = 'auto_increment'\n"
+              "\t\t\t\t\t\t\tAND c.table_schema = %s.table_schema\n"
+              "\t\t\t\t\t\t\tAND c.table_name = %s.table_name\n"
+              "\t\t\t\t\t\t)\",\n"
+          )
+          new = (
+              "\t\t\t\t\t$auto_increment_subquery = sprintf(\n"
+              "\t\t\t\t\t\t\"(\n"
+              "\t\t\t\t\t\t\tSELECT MAX(COALESCE(s.seq + 1, 1))\n"
+              "\t\t\t\t\t\t\tFROM %s AS c\n"
+              "\t\t\t\t\t\t\t%s\n"
+              "\t\t\t\t\t\t\tWHERE c.extra = 'auto_increment'\n"
+              "\t\t\t\t\t\t\tAND c.table_schema = %s.table_schema\n"
+              "\t\t\t\t\t\t\tAND c.table_name = %s.table_name\n"
+              "\t\t\t\t\t\t)\",\n"
+          )
+          assert old in src, 'AUTO_INCREMENT subquery (tables view) not found'
+          src = src.replace(old, new, 1)
+          # Also the SHOW TABLE STATUS variant at line 3018.
+          old2 = (
+              "\t\t$auto_increment_subquery = sprintf(\n"
+              "\t\t\t\"(\n"
+              "\t\t\t\tSELECT COALESCE(s.seq + 1, 1)\n"
+              "\t\t\t\tFROM %s AS c\n"
+              "\t\t\t\t%s\n"
+              "\t\t\t\tWHERE c.extra = 'auto_increment'\n"
+              "\t\t\t\tAND c.table_schema = t.table_schema\n"
+              "\t\t\t\tAND c.table_name = t.table_name\n"
+              "\t\t\t)\",\n"
+          )
+          new2 = (
+              "\t\t$auto_increment_subquery = sprintf(\n"
+              "\t\t\t\"(\n"
+              "\t\t\t\tSELECT MAX(COALESCE(s.seq + 1, 1))\n"
+              "\t\t\t\tFROM %s AS c\n"
+              "\t\t\t\t%s\n"
+              "\t\t\t\tWHERE c.extra = 'auto_increment'\n"
+              "\t\t\t\tAND c.table_schema = t.table_schema\n"
+              "\t\t\t\tAND c.table_name = t.table_name\n"
+              "\t\t\t)\",\n"
+          )
+          assert old2 in src, 'AUTO_INCREMENT subquery (show status) not found'
+          src = src.replace(old2, new2, 1)
+          open(path, 'w').write(src)
+          print('patched AUTO_INCREMENT correlated subquery with MAX aggregate')
+
           # 10. CHECK TABLE on a missing table on real SQLite raises from
           #     `PRAGMA integrity_check(<tbl>)`; on Turso the PRAGMA is a
           #     no-op for unknown tables, so testCheckTable sees status=OK