Clean up native parser follow-up comments

Author: adamziel

packages/mysql-on-sqlite/src/sqlite/class-wp-pdo-mysql-on-sqlite.php

@@ -1160,17 +1160,14 @@ public function get_insert_id() {
 	 * @return WP_MySQL_Parser        A parser initialized for the MySQL query.
 	 */
 	public function create_parser( string $query ): WP_MySQL_Parser {
-		$lexer = new WP_MySQL_Lexer(
+		$lexer  = new WP_MySQL_Lexer(
 			$query,
 			80038,
 			$this->active_sql_modes
 		);
-		if ( $lexer instanceof WP_MySQL_Native_Lexer ) {
-			$tokens = $lexer->native_token_stream();
-			return $this->reset_or_create_parser( $tokens );
-		}
-
-		$tokens = $lexer->remaining_tokens();
+		$tokens = $lexer instanceof WP_MySQL_Native_Lexer
+			? $lexer->native_token_stream()
+			: $lexer->remaining_tokens();
 		return $this->reset_or_create_parser( $tokens );
 	}
 

packages/mysql-on-sqlite/tests/mysql/native/WP_MySQL_Native_Parser_Node_Identity_Tests.php

@@ -5,13 +5,13 @@
 /**
  * Regression tests for the per-AST identity map on native parser nodes.
  *
- * The native extension constructs a fresh PHP wrapper for every accessor
- * call. Without interning, two reads of the same logical node would yield
- * distinct objects, and a mutation made through a still-live wrapper would be
- * invisible through the second. WP_Parser_Node exposes public mutators and
- * stable child identity, so the native wrapper must preserve both.
+ * The native extension materializes PHP wrappers from Rust-owned arena nodes.
+ * Without interning, two reads of the same logical node would yield distinct
+ * objects, and a mutation made through a still-live wrapper would be invisible
+ * through the second. WP_Parser_Node exposes public mutators and stable child
+ * identity, so the native wrapper must preserve both.
  *
- * Skipped when the native extension is not loaded — the pure-PHP code
+ * Skipped when the native extension is not loaded; the pure-PHP code
  * path already has stable identity by construction.
  */
 class WP_MySQL_Native_Parser_Node_Identity_Tests extends TestCase {
@@ -96,11 +96,9 @@ public function test_mutation_on_child_survives_re_read(): void {
 		$child = $tree->get_first_child_node();
 		$this->assertNotNull( $child );
 
-		// Mutate via the public WP_Parser_Node API — this is exactly the
-		// kind of state the reviewer worried would be lost when accessors
-		// hand back fresh wrappers. rule_name is a declared public property
-		// that the parser itself sets, so PHP 8.2's dynamic-property
-		// deprecation does not apply here.
+		// Mutate via the public WP_Parser_Node API. This catches regressions
+		// where accessors hand back fresh wrappers and lose state written
+		// through a previously returned child.
 		$child->rule_name = 'mutated-rule';
 
 		$same_child = $tree->get_first_child_node();

packages/mysql-on-sqlite/tests/mysql/native/WP_MySQL_Parser_Instanceof_Tests.php

@@ -5,11 +5,10 @@
 /**
  * `WP_MySQL_Parser instanceof WP_Parser` must hold in both modes.
  *
- * Pre-PR, the native-mode `WP_MySQL_Parser` was `extends WP_MySQL_Native_Parser`
- * (a Rust-registered class with no `WP_Parser` in its chain), so existing
- * downstream code doing `if ($parser instanceof WP_Parser)` silently
- * skipped the parser when the extension was loaded. This test pins the
- * contract for both modes.
+ * The native-mode `WP_MySQL_Parser` must not expose the Rust-registered
+ * parser directly. Existing downstream code may rely on
+ * `if ($parser instanceof WP_Parser)`, so this test pins the contract for
+ * both modes.
  */
 class WP_MySQL_Parser_Instanceof_Tests extends TestCase {