Diagnose createFunction with different callables

Author: JanJakes

.github/workflows/phpunit-tests-turso.yml

@@ -123,62 +123,68 @@ jobs:
           ignore-cache: "yes"
           composer-options: "--optimize-autoloader"
 
-      - name: Staged reproduction of test setUp()
+      - name: Diagnose createFunction behavior
         continue-on-error: true
         env:
           LD_PRELOAD: ${{ steps.turso-lib.outputs.path }}
         working-directory: packages/mysql-on-sqlite
         run: |
-          php -d 'output_buffering=0' <<'PHP'
+          # Use STDERR for progress logging so it is always flushed immediately.
+          php <<'PHP'
           <?php
-          require __DIR__ . '/tests/bootstrap.php';
-          echo "[1] bootstrap ok\n";
+          $log = fn(string $s) => fwrite(STDERR, $s . "\n");
 
           $pdo_class = PHP_VERSION_ID >= 80400 ? PDO\SQLite::class : PDO::class;
           $pdo = new $pdo_class('sqlite::memory:');
-          echo "[2] PDO({$pdo_class}) ok\n";
-
-          $pdo->exec('PRAGMA foreign_keys = ON');
-          echo "[3] PRAGMA foreign_keys ok\n";
-
-          // Same as WP_SQLite_PDO_User_Defined_Functions::register_for but with
-          // a running count so we see how far we got before any crash.
-          $funcs = new WP_SQLite_PDO_User_Defined_Functions();
-          $ref = new ReflectionClass($funcs);
-          $prop = $ref->getProperty('functions');
-          $prop->setAccessible(true);
-          $list = $prop->getValue($funcs);
-          echo "[4] UDF list: " . count($list) . " entries\n";
-
-          $n = 0;
-          foreach ($list as $name => $method) {
-              $n++;
-              if ($pdo instanceof PDO\SQLite) {
-                  $pdo->createFunction($name, [$funcs, $method]);
-              } else {
-                  $pdo->sqliteCreateFunction($name, [$funcs, $method]);
-              }
-              echo "[5.{$n}] registered {$name}\n";
+          $log("[a] PDO({$pdo_class}) ok");
+
+          // 1) Closure
+          try {
+              $pdo->createFunction('mk_closure', function ($x) { return $x . '!'; });
+              $log('[b] createFunction(closure) ok');
+              $r = $pdo->query("SELECT mk_closure('x') AS v")->fetch(PDO::FETCH_ASSOC);
+              $log('[b.call] ' . json_encode($r));
+          } catch (\Throwable $e) {
+              $log('[b] EXC ' . $e->getMessage());
           }
-          echo "[6] all UDFs registered\n";
 
-          // Register a tiny extra query to see if calling a registered UDF from SQL works.
-          $row = $pdo->query("SELECT md5('x') AS v")->fetch(PDO::FETCH_ASSOC);
-          echo "[7] md5('x') -> " . json_encode($row) . "\n";
+          // 2) String callable
+          try {
+              $pdo->createFunction('mk_builtin', 'md5');
+              $log('[c] createFunction("md5") ok');
+              $r = $pdo->query("SELECT mk_builtin('abc') AS v")->fetch(PDO::FETCH_ASSOC);
+              $log('[c.call] ' . json_encode($r));
+          } catch (\Throwable $e) {
+              $log('[c] EXC ' . $e->getMessage());
+          }
 
-          // Now build the full driver.
-          $conn = new WP_SQLite_Connection(['pdo' => $pdo]);
-          echo "[8] Connection ok\n";
+          // 3) [object, method] callable
+          try {
+              $obj = new class {
+                  public function greet($x) { return "hi $x"; }
+              };
+              $pdo->createFunction('mk_method', [$obj, 'greet']);
+              $log('[d] createFunction([obj,method]) ok');
+              $r = $pdo->query("SELECT mk_method('bob') AS v")->fetch(PDO::FETCH_ASSOC);
+              $log('[d.call] ' . json_encode($r));
+          } catch (\Throwable $e) {
+              $log('[d] EXC ' . $e->getMessage());
+          }
 
-          $engine = new WP_SQLite_Driver($conn, 'wp');
-          echo "[9] Driver ok\n";
+          // 4) Register many to see if limit matters.
+          try {
+              for ($i = 0; $i < 40; $i++) {
+                  $pdo->createFunction("fn_{$i}", function () { return 1; });
+                  if ($i === 30 || $i === 31 || $i === 32 || $i === 33 || $i === 39) {
+                      $log("[e.{$i}] registered fn_{$i}");
+                  }
+              }
+              $log('[e] bulk registration ok');
+          } catch (\Throwable $e) {
+              $log('[e] EXC at N=' . ($i ?? '?') . ': ' . $e->getMessage());
+          }
 
-          $engine->query("CREATE TABLE _options (
-              ID INTEGER PRIMARY KEY AUTO_INCREMENT NOT NULL,
-              option_name TEXT NOT NULL default '',
-              option_value TEXT NOT NULL default ''
-          );");
-          echo "[10] CREATE TABLE _options ok\n";
+          $log('[done] script finished cleanly');
           PHP
 
       - name: Run PHPUnit tests against Turso DB