Skip to content

Commit 0e7338a

Browse files
committed
Fail the job when PHPUnit crashes or tests fail
continue-on-error: true on the PHPUnit step made the job report green even when the tests segfaulted, which is misleading. Drop it so the job status reflects real pass/fail.
1 parent 441d211 commit 0e7338a

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

.github/workflows/phpunit-tests-turso.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,6 @@ jobs:
363363
--args "$(command -v php)"
364364
365365
- name: Run PHPUnit tests against Turso DB (under gdb)
366-
continue-on-error: true
367366
env:
368367
PRELOAD: ${{ steps.preload.outputs.value }}
369368
working-directory: packages/mysql-on-sqlite
@@ -374,4 +373,4 @@ jobs:
374373
-ex "set environment LD_PRELOAD=$PRELOAD" \
375374
-ex "run ./vendor/bin/phpunit -c ./phpunit.xml.dist" \
376375
-ex "bt 30" \
377-
--args "$(command -v php)" || true
376+
--args "$(command -v php)"

0 commit comments

Comments
 (0)