Refactor: Remove unnecessary ob buffering in Settings API, reformat repeater wrapper

- Remove ob_start()/ob_get_clean() from plugin_settings() and show_form() — direct output is sufficient
- Reformat repeater wrapper div to multi-line for readability
- Extract data attributes into named variables before output

Author: ajaydsouza

includes/admin/settings/class-settings-api.php

@@ -917,7 +917,6 @@ public function settings_sanitize( $input ) {
 	 * Render the settings page.
 	 */
 	public function plugin_settings() {
-		ob_start();
 		?>
 			<div class="wrap">
 				<?php do_action( $this->prefix . '_settings_page_header_before' ); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound ?>
@@ -961,7 +960,6 @@ public function plugin_settings() {
 			</div><!-- /.wrap -->
 
 			<?php
-			echo ob_get_clean(); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
 	}
 
 	/**
@@ -1006,7 +1004,6 @@ public function show_navigation() {
 	 * This public function displays every sections in a different form
 	 */
 	public function show_form() {
-		ob_start();
 		?>
 
 			<form method="post" action="options.php" id="<?php echo esc_attr( "{$this->prefix}-settings-form" ); ?>">
@@ -1064,7 +1061,6 @@ public function show_form() {
 			</form>
 
 			<?php
-			echo ob_get_clean(); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
 	}
 
 	/**

includes/admin/settings/class-settings-form.php

@@ -945,9 +945,19 @@ public function callback_repeater( $args ) {
 			$attributes .= sprintf( ' %1$s="%2$s"', sanitize_key( $attribute ), esc_attr( $val ) );
 		}
 
+		$data_index        = (string) count( $value );
+		$live_update_field = ! empty( $args['live_update_field'] ) ? $args['live_update_field'] : 'name';
+		$fallback_title    = ! empty( $args['new_item_text'] ) ? $args['new_item_text'] : $this->translation_strings['repeater_new_item'];
+
 		ob_start();
 		?>
-		<div class="<?php echo esc_attr( $class ); ?> wz-repeater-wrapper" id="<?php echo esc_attr( $args['id'] ); ?>-wrapper" data-index="<?php echo esc_attr( (string) count( $value ) ); ?>" data-live-update-field="<?php echo esc_attr( ! empty( $args['live_update_field'] ) ? $args['live_update_field'] : 'name' ); ?>" data-fallback-title="<?php echo esc_attr( ! empty( $args['new_item_text'] ) ? $args['new_item_text'] : $this->translation_strings['repeater_new_item'] ); ?>" <?php echo $attributes; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>>
+		<div class="<?php echo esc_attr( $class ); ?> wz-repeater-wrapper"
+			id="<?php echo esc_attr( $args['id'] ); ?>-wrapper"
+			data-index="<?php echo esc_attr( $data_index ); ?>"
+			data-live-update-field="<?php echo esc_attr( $live_update_field ); ?>"
+			data-fallback-title="<?php echo esc_attr( $fallback_title ); ?>"
+			<?php echo $attributes; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>>
+
 			<div class="<?php echo esc_attr( $args['id'] ); ?>-items wz-repeater-items">
 				<?php
 				if ( ! empty( $value ) ) {