fix for failing test

Author: arcuri82

core/src/main/kotlin/org/evomaster/core/search/gene/Gene.kt

@@ -1180,18 +1180,21 @@ abstract class Gene(
      * @param updateValue lambda performs update of value of the gene
      * @param undoIfUpdateFails represents whether it needs to undo the value update if [updateValue] returns false
      *
-     * @return if the value is updated with [updateValue]
+     * @return if the value is updated with [updateValue]. note if for any reason the current gene was not valid,
+     *         the validity of the update will not be checked.
      */
     fun updateValueOnlyIfValid(updateValue: () -> Boolean, undoIfUpdateFails: Boolean): Boolean {
 
         if(!undoIfUpdateFails) {
             return updateValue()
         }
 
+        val currentlyValid = isGloballyValid()
+
         val current = copy()
         val ok = updateValue()
 
-        if (!ok || !isGloballyValid()) {
+        if (!ok || (currentlyValid && !isGloballyValid())) {
             val success = unsafeCopyValueFrom(current)
             assert(success)
             return false

core/src/main/kotlin/org/evomaster/core/search/gene/sql/SqlAutoIncrementGene.kt

@@ -36,8 +36,17 @@ class SqlAutoIncrementGene(name: String) : SimpleGene(name) {
      * Man: need to check with Andrea, copyValueFrom of [ImmutableDataHolderGene] throw an exception
      */
     override fun unsafeCopyValueFrom(other: Gene): Boolean {
-        //do nothing
-        return containsSameValueAs(other)
+        if (other !is SqlAutoIncrementGene) {
+            return false
+        }
+        /*
+            auto-increment are always unique... so a copy over should never work.
+            however, here we return true instead of false to fulfill invariant that
+            copyFrom a copy should always work...
+
+            TODO might check for side-effects, and see if need more complex handling
+         */
+        return true
     }
 
     /**

core/src/test/kotlin/org/evomaster/core/search/structuralelement/gene/GeneStructuralElementBaseTest.kt

@@ -38,10 +38,10 @@ abstract class GeneStructuralElementBaseTest : StructuralElementBaseTest() {
 
         if (throwExceptionInCopyFromTest()){
             assertThrows<Exception> {
-                base.unsafeCopyValueFrom(template)
+                base.copyValueFrom(template)
             }
         }else{
-            base.unsafeCopyValueFrom(template)
+            base.copyValueFrom(template)
             assertCopyFrom(base)
             // keep structure after copyfrom
             assertChildren(base, -1)

core/src/test/kotlin/org/evomaster/core/search/structuralelement/gene/RegexGeneStructureTest.kt

@@ -37,11 +37,11 @@ class CharacterClassEscapeRxGeneStructureTest : GeneStructuralElementBaseTest()
     }
 
     @Test
-    fun testUnsafeCopyValueFromFailure(){
+    fun testCopyValueFromFailure(){
         val base = getStructuralElement().copy()
         val copy = getCopyFromTemplate().copy()
 
-        assertFalse(base.unsafeCopyValueFrom(copy))
+        assertFalse(base.copyValueFrom(copy))
     }