fixed series of bugs

Author: arcuri82

core/src/main/kotlin/org/evomaster/core/search/gene/ObjectGene.kt

@@ -112,11 +112,10 @@ class ObjectGene(
                 .forEach { it.randomize(randomness, tryToForceNewValue) }
 
         if (!isFixed){
-            Lazy.assert {
-                template != null && additionalFields != null
-            }
-            if (additionalFields!!.isNotEmpty())
+            Lazy.assert { template != null && additionalFields != null }
+            if (additionalFields!!.isNotEmpty()) {
                 killChildren(additionalFields!!)
+            }
             val num = randomness.nextInt(MAX_SIZE_ADDITIONAL_FIELDS)
             repeat(num){
                 val added = sampleElementToAdd(randomness)
@@ -265,9 +264,12 @@ class ObjectGene(
         }
 
         if(!isFixed){
-            //TODO what if there is a mismatch here? semantic of this function is unclear
-            for (i in additionalFields!!.indices){
-                ok = ok && this.additionalFields!![i].unsafeCopyValueFrom(other.additionalFields!![i])
+            if (additionalFields!!.isNotEmpty()) {
+                killChildren(additionalFields!!)
+            }
+            val otherAdditionalFields = other.additionalFields
+            otherAdditionalFields?.forEach {
+                addChild(it.copy())
             }
         }
 

core/src/main/kotlin/org/evomaster/core/search/gene/UUIDGene.kt

@@ -92,7 +92,7 @@ class UUIDGene(
         val gene = other.getPhenotype()
 
         if (gene !is UUIDGene) {
-            throw IllegalArgumentException("Invalid gene type ${gene.javaClass}")
+            return false
         }
         return this.mostSigBits.unsafeCopyValueFrom(gene.mostSigBits)
                 && this.leastSigBits.unsafeCopyValueFrom(gene.leastSigBits)

core/src/main/kotlin/org/evomaster/core/search/gene/collection/FlexibleMapGene.kt

@@ -58,10 +58,18 @@ where T : Gene {
     }
 
     override fun unsafeCopyValueFrom(other: Gene): Boolean {
-        //TODO
-        LoggingUtil.uniqueWarn(log,"unsafeCopyValueFrom() not implemented for FlexibleMapGene")
 
-        return false
+        if(other !is FlexibleMapGene<*>) {
+            return false
+        }
+
+        killAllChildren()
+        val elements = other.elements
+            .mapNotNull { it.copy() as? PairGene<T, FlexibleGene> }
+            .toMutableList()
+        elements.forEach { it.resetLocalIdRecursively() }
+        addChildren(elements)
+        return true
     }
 
     override fun isPrintable(): Boolean {

core/src/main/kotlin/org/evomaster/core/search/gene/sql/geometric/SqlPolygonGene.kt

@@ -46,14 +46,15 @@ class SqlPolygonGene(
         val pointList = mutableListOf<SqlPointGene>()
         repeat(minLengthOfPolygonRing) {
             val newGene = points.template.copy() as SqlPointGene
+            newGene.doInitialize(randomness)
             pointList.add(newGene)
             do {
                 newGene.randomize(randomness, tryToForceNewValue)
             } while (onlyNonIntersectingPolygons && !noCrossOvers(pointList))
         }
         points.randomize(randomness, tryToForceNewValue)
         points.killAllChildren()
-        pointList.map { points.addChild(it) }
+        pointList.forEach { points.addChild(it) }
         assert(isLocallyValid())
     }
 

core/src/main/kotlin/org/evomaster/core/search/gene/sql/textsearch/SqlTextSearchQueryGene.kt

@@ -78,6 +78,7 @@ class SqlTextSearchQueryGene(
          */
         if (queryLexemes.getViewOfElements().isEmpty()) {
             val stringGene = StringGene("lexeme")
+            stringGene.doInitialize(randomness)
             stringGene.randomize(randomness, tryToForceNewValue)
             queryLexemes.addElement(stringGene)
         }

core/src/test/kotlin/org/evomaster/core/search/gene/GeneRandomizedTest.kt

@@ -13,7 +13,6 @@ import org.junit.jupiter.api.assertThrows
 class GeneRandomizedTest : AbstractGeneTest(){
 
 
-   // @Disabled("seed 1796 is still failing")
     @TestFactory
     fun testRandomized(): Collection<DynamicTest> {
         return (1000..2000L).map {
@@ -50,7 +49,7 @@ class GeneRandomizedTest : AbstractGeneTest(){
         }
 
         //FIXME put back once fix all issues it finds
-        //verifyCopyValueFrom(mutable, rand)
+        verifyCopyValueFrom(mutable, rand)
     }
 
     private fun verifyCopyValueFrom(