fix(test): use FloatSpace::get_data_size and fix groundtruth call

- Replace invalid static_cast on Metric struct in test_helpers with feature_space.get_data_size()
- Fix undefined compute_gt call in deglib_groundtruth.cpp to compute_knn_groundtruth

Author: Neiko2002

cpp/benchmark/src/deglib_groundtruth.cpp

@@ -148,7 +148,7 @@ int main() {
         const auto query_repository = deglib::load_static_repository(query_file_uint8.c_str());
 
         const auto start = std::chrono::system_clock::now();
-        const auto topLists = compute_gt(base_repository, query_repository, deglib::Metric::L2_Uint8, k_target);
+        const auto topLists = compute_knn_groundtruth(base_repository, query_repository, deglib::Metric::L2_Uint8, k_target);
         auto duration = uint32_t(std::chrono::duration_cast<std::chrono::seconds>(std::chrono::system_clock::now() - start).count());
         fmt::print("Computing {:5} top lists of a {:8} base took {:5}s \n", query_repository.size(), base_repository.size(), duration);
         topListsUint8 = topLists;
@@ -165,7 +165,7 @@ int main() {
         const auto query_repository = deglib::load_static_repository(query_file.c_str());
 
         const auto start = std::chrono::system_clock::now();
-        const auto topLists = compute_gt(base_repository, query_repository, deglib::Metric::L2, k_target);
+        const auto topLists = compute_knn_groundtruth(base_repository, query_repository, deglib::Metric::L2, k_target);
         auto duration = uint32_t(std::chrono::duration_cast<std::chrono::seconds>(std::chrono::system_clock::now() - start).count());
         fmt::print("Computing {:5} top lists of a {:8} base took {:5}s \n", query_repository.size(), base_repository.size(), duration);
         topListsFloat = topLists;

cpp/test/src/common/test_helpers.h

@@ -454,20 +454,13 @@ inline static void run_integration_test(const char* name, deglib::Metric metric,
     const uint32_t additional_swap_tries = 0;
     const uint32_t thread_count = 1;
 
-    // Compute byte size per vector based on metric type
-    size_t feature_bytes;
-    if (metric == deglib::Metric::FP16InnerProduct)
-        feature_bytes = dim * sizeof(uint16_t);
-    else if (metric == deglib::Metric::EVPInnerProduct)
-        feature_bytes = 2 * (dim / 8);
-    else
-        feature_bytes = (static_cast<int>(metric) & 0x10) ? dim * sizeof(uint8_t) : dim * sizeof(float);
-
     // Build DEG Graph using the specified metric feature space
     const deglib::FloatSpace feature_space = dist_variant.has_value()
         ? deglib::FloatSpace(dim, metric, dist_variant.value())
         : deglib::FloatSpace(dim, metric);
 
+    const size_t feature_bytes = feature_space.get_data_size();
+
     deglib::graph::SizeBoundedGraph graph(static_cast<uint32_t>(base_count), edges_per_vertex,
                                           std::move(feature_space));
 
@@ -587,7 +580,7 @@ inline static void run_builder_integration_test(const char* name, deglib::Metric
                                                 std::optional<deglib::DistanceVariant> dist_variant,
                                                 deglib::builder::OptimizationTarget optimization_target)
 {
-    if (static_cast<int>(metric) & 0x10)
+    if (metric.get_data_type() == deglib::MetricDataType::Uint8)
     {
         // uint8 metric
         std::vector<uint8_t> base_data;
@@ -678,20 +671,13 @@ inline static void run_regression_test(const char* name, deglib::Metric metric,
     const uint32_t additional_swap_tries = 0;
     const uint32_t thread_count = 1;
 
-    // Compute byte size per vector based on metric type
-    size_t feature_bytes;
-    if (metric == deglib::Metric::FP16InnerProduct)
-        feature_bytes = dim * sizeof(uint16_t);
-    else if (metric == deglib::Metric::EVPInnerProduct)
-        feature_bytes = 2 * (dim / 8);
-    else
-        feature_bytes = (static_cast<int>(metric) & 0x10) ? dim * sizeof(uint8_t) : dim * sizeof(float);
-
     // Build DEG Graph using the specified metric feature space
     const deglib::FloatSpace feature_space = dist_variant.has_value()
         ? deglib::FloatSpace(dim, metric, dist_variant.value())
         : deglib::FloatSpace(dim, metric);
 
+    const size_t feature_bytes = feature_space.get_data_size();
+
     deglib::graph::SizeBoundedGraph graph(static_cast<uint32_t>(base_count), edges_per_vertex,
                                           std::move(feature_space));