enable strict JSON spec unmarshalling#2202
Open
AndrewChubatiuk wants to merge 1 commit into
Open
Conversation
c83563c to
6e84dfd
Compare
6e84dfd to
f79c746
Compare
f79c746 to
a984354
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related issue VictoriaMetrics/helm-charts#2882
Summary by cubic
Enable strict JSON unmarshalling for all Operator CR specs to reject unknown fields and return clear errors. This prevents typos or unsupported keys from being silently accepted.
Bug Fixes
UnmarshalSpecStrict(usesDisallowUnknownFields) and wired all CRUnmarshalJSONpaths (v1,v1alpha1,v1beta1) through it, settingParsingSpecErroron failure.VMAlertmanagerConfigtests/fixtures to use valid fields (e.g.,msteams_configs,custom_fieldsplacement).Migration
Written for commit a984354. Summary will update on new commits. Review in cubic