Skip to content

Commit ce8b689

Browse files
committed
Update ViewerProtocolTests.cs
1 parent 3780559 commit ce8b689

1 file changed

Lines changed: 6 additions & 7 deletions

File tree

src/DiffEngine.Tests/ViewerProtocolTests.cs

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,6 @@ public async Task AnOwnerAnswersAClient()
218218
{
219219
await Assert.That(ViewerServer.TryBind(0, out var bound)).IsTrue();
220220
using var server = bound!;
221-
using var cancel = new CancellationTokenSource();
222221
var listening = server.Listen(_ => ViewerResponse.Success($"heard {_.Verb}"), cancel.Token);
223222

224223
var sent = ViewerClient.TrySend(new(ViewerVerb.List), out var response, server.Port);
@@ -227,7 +226,7 @@ public async Task AnOwnerAnswersAClient()
227226
await Assert.That(response!.Ok).IsTrue();
228227
await Assert.That(response.Message).IsEqualTo("heard List");
229228

230-
cancel.Cancel();
229+
await cancel.CancelAsync();
231230
await Wait(listening);
232231
}
233232

@@ -241,7 +240,7 @@ public async Task ASlowExchangeDoesNotBlockTheNext()
241240
{
242241
await Assert.That(ViewerServer.TryBind(0, out var bound)).IsTrue();
243242
using var server = bound!;
244-
using var cancel = new CancellationTokenSource();
243+
using var cancel = new CancelSource();
245244
using var entered = new ManualResetEventSlim();
246245
using var release = new ManualResetEventSlim();
247246
var listening = server.Listen(
@@ -262,7 +261,7 @@ public async Task ASlowExchangeDoesNotBlockTheNext()
262261
var accepting = Task.Run(() =>
263262
ViewerClient.TrySend(new(ViewerVerb.Accept, "key"), out var slow, server.Port, TimeSpan.FromSeconds(15))
264263
? slow
265-
: null);
264+
: null, cancel.Token);
266265
entered.Wait(TimeSpan.FromSeconds(5));
267266

268267
// Default timeout, while the accept is still held open.
@@ -278,7 +277,7 @@ public async Task ASlowExchangeDoesNotBlockTheNext()
278277
finally
279278
{
280279
release.Set();
281-
cancel.Cancel();
280+
await cancel.CancelAsync();
282281
await Wait(listening);
283282
}
284283
}
@@ -292,7 +291,7 @@ public async Task AThrowingHandlerAnswersAnError()
292291
{
293292
await Assert.That(ViewerServer.TryBind(0, out var bound)).IsTrue();
294293
using var server = bound!;
295-
using var cancel = new CancellationTokenSource();
294+
using var cancel = new CancelSource();
296295
var listening = server.Listen(_ => throw new("the handler is broken"), cancel.Token);
297296

298297
var sent = ViewerClient.TrySend(new(ViewerVerb.List), out var response, server.Port);
@@ -301,7 +300,7 @@ public async Task AThrowingHandlerAnswersAnError()
301300
await Assert.That(response!.Ok).IsFalse();
302301
await Assert.That(response.Message).IsEqualTo("the handler is broken");
303302

304-
cancel.Cancel();
303+
await cancel.CancelAsync();
305304
await Wait(listening);
306305
}
307306

0 commit comments

Comments
 (0)